[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #7 from Jonathan Druart --- Created attachment 122935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122935=edit Bug 28617: Remove kohalib.pl and rely on PERL5LIB The purpose of this script was to load the relevant Koha lib for the different scripts (installation, cronjob, CLI, etc.) However it is not used consistently and we prefer to rely on PERL5LIB. From bug 28617 comment 6 from Galen: """ Time marches on, and one of the motivations for having kohalib.pl - making it possible to install Koha without setting a single environment variable - has been obviated by the vast improvements in the ease of installing Koha. Consequently, I think kohalib.pl can go away. """ Test plan: confirm that the changes make sense and that kohalib.pl can be removed safely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #6 from Galen Charlton --- If you're interested in the history, make yourself a hot beverage of your choice and read http://koha.1045719.n5.nabble.com/RFC-installer-changes-td3065475.html Time marches on, and one of the motivations for having kohalib.pl - making it possible to install Koha without setting a single environment variable - has been obviated by the vast improvements in the ease of installing Koha. Consequently, I think kohalib.pl can go away. As far as upgrade worries are concerned, a release note advising anybody who is still actively upgrading ancient Koha systems from tarballs that they should double-check that PERL5LIB is set in crontabs should suffice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #0) > This script is used by command line scripts to load the Koha lib. > Should not we rely on PERL5LIB instead? +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #4 from Tomás Cohen Arazi --- I think the idea was to prevent some lib being replaced by a malicious one on a different path. Pretty much like the . fix Perl added. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617
--- Comment #3 from Marcel de Rooy ---
We should remove it and replace all occurrences like:
eval { require "$FindBin::Bin/../kohalib.pl" };
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Martin Renvoize changed: What|Removed |Added CC||g...@esilibrary.com, ||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #2 from Martin Renvoize --- Must admit, I've never entirely understood what this script was all about and why we didn't set PERL5LIB somewhere instead.. I'm not sure recent scripts have included it and I've not come across issues using those (either as standard, dev or package installs). Perhaps ask Galen if he knows of a reason to keep it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 --- Comment #1 from Jonathan Druart --- This is not an enforced rule for all our CLI scripts, if it was really useful for someone we would have heard about them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28617] Is misc/kohalib.pl still useful?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28617 Jonathan Druart changed: What|Removed |Added CC||dc...@prosentient.com.au, ||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
