[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||jonathan.druart+koha@gmail.
   ||com
 Status|Passed QA   |RESOLVED

--- Comment #5 from Jonathan Druart  ---
I fixed that earlier this week with a follow-up on bug 28606
  commit af7e41d1142573666d302a8475274ea58e5c99f4
  Bug 28606: Remove warning from C4::Auth 887

*** This bug has been marked as a duplicate of bug 28606 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #122758|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 122865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122865=edit
Bug 28699: Allow for blank firstname in checkauth

When mapping the fields from the session we should map blank fieds
to blank strings

To test:
1 - Remove first name from a patron
2 - tail -f /var/log/koha/kohadev/plack-opac-error.log
3 - Login as that patron on the opac
4 - Note warns in the log like:
[2021/07/09 13:22:54] [WARN] Use of uninitialized value in sprintf at
/kohadevbox/koha/C4/Auth.pm line 888.
5 - Apply patch
6 - restart_all
7 - Log out and in to opac with user
8 - Note warns above are gone

Signed-off-by: David Nind 

Signed-off-by: Marcel de Rooy 
[EDIT] Replaced || by //, since we talk here about uninitialized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook  ---
Thank you, Nick. This has been bugging me for ages. I'll make a note to QA this
later today. (I am half-tempted to pass it just because it's so simple, but I
had better give at least one spin through...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This removes unnecessary
  release notes||warning messages in
   ||plack-opac-error.log when
   ||patrons have no first name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Nind  changed:

   What|Removed |Added

 Attachment #122745|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 122758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122758=edit
Bug 28699: Allow for blank firstname in checkauth

When mapping the fields from the session we should map blank fieds
to blank strings

To test:
1 - Remove first name from a patron
2 - tail -f /var/log/koha/kohadev/plack-opac-error.log
3 - Login as that patron on the opac
4 - Note warns in the log like:
[2021/07/09 13:22:54] [WARN] Use of uninitialized value in sprintf at
/kohadevbox/koha/C4/Auth.pm line 888.
5 - Apply patch
6 - restart_all
7 - Log out and in to opac with user
8 - Note warns above are gone

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

--- Comment #1 from Nick Clemens  ---
Created attachment 122745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122745=edit
Bug 28699: Allow for blank firstname in checkauth

When mapping the fields from the session we should map blank fieds
to blank strings

To test:
1 - Remove first name from a patron
2 - tail -f /var/log/koha/kohadev/plack-opac-error.log
3 - Login as that patron on the opac
4 - Note warns in the log like:
[2021/07/09 13:22:54] [WARN] Use of uninitialized value in sprintf at
/kohadevbox/koha/C4/Auth.pm line 888.
5 - Apply patch
6 - restart_all
7 - Log out and in to opac with user
8 - Note warns above are gone

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28699] Noisy warns in checkauth when patron has no firstname

2021-07-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28699

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/