[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #67 from David Cook --- (In reply to David Cook from comment #66) > (In reply to Jonathan Druart from comment #41) > > Pushed to master for 21.11, thanks to everybody involved! > > I don't think the libemail-address-perl got added to debian/control. > > 21.11 worked fine in koha-testing-docker > (https://gitlab.com/koha-community/koha-testing-docker/-/issues/274), but > looks like it fails to startup in a normal from-scratch installation. I'm not sure why we didn't use Email::Address::XS since Email::MIME has it as a dependency already... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #66 from David Cook --- (In reply to Jonathan Druart from comment #41) > Pushed to master for 21.11, thanks to everybody involved! I don't think the libemail-address-perl got added to debian/control. 21.11 worked fine in koha-testing-docker (https://gitlab.com/koha-community/koha-testing-docker/-/issues/274), but looks like it fails to startup in a normal from-scratch installation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Katrin Fischer changed: What|Removed |Added CC||verolenci...@yahoo.com.ar --- Comment #65 from Katrin Fischer --- *** Bug 28275 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #64 from Victor Grousset/tuxayo --- > What I did for testing in those days was installing postfix, and mutt. You > can assign localhost as the resolution for any find and have the MTA deliver > locally. That might be a little adventure ^^" In case 20.05.x turns out to be affected - it should be, since it uses Email::Valid - the patch conflicts quite a lot due to bug 22343 missing. Unless there is a way that doesn't mess with too much code. I don't think it would be wise to backport (recode more likely) this fix in the less than 48h remaining before the last minor release of 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #63 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #62) > Hi, I'm trying to see if 20.05.x is affected. How can I test this? > > I tried setting a server in koha-conf.xml like in bug 29330 comment 40 but > it still tries to connect to localhost when sending an OPAC cart. I think it > because I would need bug 22343 right? > > I can't find how it was done before bug 22343. Any hints? Prior to bug 22343, Koha expected an MTA in localhost. What I did for testing in those days was installing postfix, and mutt. You can assign localhost as the resolution for any find and have the MTA deliver locally. It was usually enough to use mutt to read the root user emails for bounces and such. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #62 from Victor Grousset/tuxayo --- Hi, I'm trying to see if 20.05.x is affected. How can I test this? I tried setting a server in koha-conf.xml like in bug 29330 comment 40 but it still tries to connect to localhost when sending an OPAC cart. I think it because I would need bug 22343 right? I can't find how it was done before bug 22343. Any hints? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #61 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #60 from Fridolin Somers --- Applying on 20.11.x I tried to use patches in this bug report but it failed on : error: sha1 information is lacking or useless (Koha/Email.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28870: Move email address validation to a specific class method So I tried to cherry-pick from 21.05.x and it works. Unit test is OK so should be OK. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #59 from Katrin Fischer --- Thx, Michael! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #58 from Michael Hafen --- Created attachment 127750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127750=edit 20.11.x: Bug 28870: non-FQDN addresses are valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #57 from Michael Hafen --- Created attachment 127749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127749=edit 20.11.x: Bug 28870: Use Email::Address->parse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #56 from Michael Hafen --- Created attachment 127748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127748=edit 20.11.x: Bug 28870: Move email address validation to a specific class method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #55 from Michael Hafen --- Created attachment 127747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127747=edit 20.11.x: Bug 28870: Remove traces of Email::Valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #54 from Michael Hafen --- Created attachment 127746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127746=edit 20.11.x: Bug 28870: Use Email::Address to validate email addresses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #53 from Michael Hafen --- Created attachment 127745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127745=edit 20.11.x: Bug 28870: Regression tests cherry-pick applied clean for all patches. So here's a backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #52 from Katrin Fischer --- This was originally found in 20.11 - problem exists there for sure. Is it possible to backport? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #51 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #50) > Pushed to 21.05.x for 21.05.05 Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #50 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added CC||m...@adminkuhn.ch --- Comment #49 from Tomás Cohen Arazi --- *** Bug 28019 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #48 from Michael Hafen --- Created attachment 127526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127526=edit 21.05.x: Bug 28870: non-FQDN addresses are valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #47 from Michael Hafen --- Created attachment 127525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127525=edit 21.05.x: Bug 28870: Use Email::Address->parse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #46 from Michael Hafen --- Created attachment 127524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127524=edit 21.05.x: Bug 28870: Move email address validation to a specific class method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #45 from Michael Hafen --- Created attachment 127523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127523=edit 21.05.x: Bug 28870: Remove traces of Email::Valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #44 from Michael Hafen --- Created attachment 127522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127522=edit 21.05.x: Bug 28870: Use Email::Address to validate email addresses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Michael Hafen changed: What|Removed |Added CC||michael.ha...@washk12.org --- Comment #43 from Michael Hafen --- Created attachment 127521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127521=edit 21.05.x: Bug 28870: Regression tests Hope this is ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master|RESOLVED --- Comment #42 from Kyle M Hall --- Please add patches for 21.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #41 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #40 from Nick Clemens --- (In reply to Katrin Fischer from comment #26) > (In reply to Jonathan Druart from comment #22) > > Ulrich, can we get your signoff on those patches please? > > We don't have a master environment we can test email functionality with > right now. Just FYI - if your email account provides SMTP settings you can enter those in the SMTP server configuration and use your email to test :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #39 from Nick Clemens --- Created attachment 124767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124767=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #38 from Nick Clemens --- Created attachment 124766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124766=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #37 from Nick Clemens --- Created attachment 124765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124765=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #36 from Nick Clemens --- Created attachment 124764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124764=edit Bug 28870: Remove traces of Email::Valid Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #35 from Nick Clemens --- Created attachment 124763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124763=edit Bug 28870: Use Email::Address to validate email addresses This patch adds a new dependency, Email::Address. It is used in Koha::Email to replace the current use of Email::Valid, which proved to be problematic when it comes to UTF-8 characters. Email::Address provides suitable regexes that -when used- keep our tests passing, but also deal better with UTF-8 data. To test: 1. Apply the regression tests patch 2. Notice the only change is that it tweaks a couple addresses so they contain umlauts and also have the "Description " format that is used when sending carts. 3. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: Tests fail! Things die because Email::Valid doesn't like the from we passed. 4. Run: $ sudo apt install libemail-address-perl 5. Apply this patch 6. Repeat 3 => SUCCESS: Tests pass! 7. Try what is described in comment 1 => SUCCESS: Things are back to normal 8. Sign off :-D 9. Send cookies Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Nick Clemens changed: What|Removed |Added Attachment #124752|0 |1 is obsolete|| Attachment #124753|0 |1 is obsolete|| Attachment #124754|0 |1 is obsolete|| Attachment #124755|0 |1 is obsolete|| Attachment #124756|0 |1 is obsolete|| Attachment #124757|0 |1 is obsolete|| --- Comment #34 from Nick Clemens --- Created attachment 124762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124762=edit Bug 28870: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #33 from Martin Renvoize --- Letting pragmatism win here. I feel the is_valid method is in the wrong context here, perhaps a Koha::Email::Address object we pass around should be created.. or the class method here could be renamed validate_address() or something. But, the code works, the tests pass. Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added Attachment #124185|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 124757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124757=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added Attachment #124184|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 124756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124756=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added Attachment #124183|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 124755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124755=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added Attachment #124004|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 124754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124754=edit Bug 28870: Remove traces of Email::Valid Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added Attachment #124003|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 124753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124753=edit Bug 28870: Use Email::Address to validate email addresses This patch adds a new dependency, Email::Address. It is used in Koha::Email to replace the current use of Email::Valid, which proved to be problematic when it comes to UTF-8 characters. Email::Address provides suitable regexes that -when used- keep our tests passing, but also deal better with UTF-8 data. To test: 1. Apply the regression tests patch 2. Notice the only change is that it tweaks a couple addresses so they contain umlauts and also have the "Description " format that is used when sending carts. 3. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: Tests fail! Things die because Email::Valid doesn't like the from we passed. 4. Run: $ sudo apt install libemail-address-perl 5. Apply this patch 6. Repeat 3 => SUCCESS: Tests pass! 7. Try what is described in comment 1 => SUCCESS: Things are back to normal 8. Sign off :-D 9. Send cookies Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Martin Renvoize changed: What|Removed |Added Attachment #124002|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 124752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124752=edit Bug 28870: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #26 from Katrin Fischer --- (In reply to Jonathan Druart from comment #22) > Ulrich, can we get your signoff on those patches please? We don't have a master environment we can test email functionality with right now. We could test with latest 20.11. I tried to rebase, resolved some 'easy' conflicts in the use statements on "Remove traces of Email::Valid", but then got stuck with below on the 4th patch: error: sha1 information is lacking or useless (about.pl). error: could not build fake ancestor Patch failed at 0001 Bug 28870: Move email address validation to a specific class method The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-28870-Move-email-address-validation-to-a-speci-qJAYKn.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #25 from Jonathan Druart --- Created attachment 124185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124185=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #24 from Jonathan Druart --- Created attachment 124184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124184=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added Attachment #124178|0 |1 is obsolete|| Attachment #124179|0 |1 is obsolete|| Attachment #124180|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 124183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124183=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added Blocks||28803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #22 from Jonathan Druart --- Ulrich, can we get your signoff on those patches please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124119|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 124180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124180=edit Bug 28870: non-FQDN addresses are valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124118|0 |1 is obsolete|| --- Comment #20 from Tomás Cohen Arazi --- Created attachment 124179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124179=edit Bug 28870: Use Email::Address->parse Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Attachment #124117|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 124178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124178=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #14) > Tomas, see the last 2 patches. > > It seems that matching the regex is not enough (last patch fixes a test). > > However there is still a test failing, root@localhost is considered valid > (FQDN no longer required). On it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28017 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > (In reply to Jonathan Druart from comment #14) > > Tomas, see the last 2 patches. > > > > It seems that matching the regex is not enough (last patch fixes a test). > > > > However there is still a test failing, root@localhost is considered valid > > (FQDN no longer required). > > Shoudl it not be valid since bug 28017? I forgot that one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #16 from Jonathan Druart --- Created attachment 124119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124119=edit Bug 28870: non-FQDN addresses are valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #15 from Katrin Fischer --- (In reply to Jonathan Druart from comment #14) > Tomas, see the last 2 patches. > > It seems that matching the regex is not enough (last patch fixes a test). > > However there is still a test failing, root@localhost is considered valid > (FQDN no longer required). Shoudl it not be valid since bug 28017? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #14 from Jonathan Druart --- Tomas, see the last 2 patches. It seems that matching the regex is not enough (last patch fixes a test). However there is still a test failing, root@localhost is considered valid (FQDN no longer required). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #13 from Jonathan Druart --- Created attachment 124118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124118=edit Bug 28870: Use Email::Address->parse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #12 from Jonathan Druart --- Created attachment 124117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124117=edit Bug 28870: Move email address validation to a specific class method To ease testing and future changes if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15349 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9815 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #11 from Tomás Cohen Arazi --- (In reply to David Nind from comment #9) > I attempted to test, but always seem to have a problem with sending > carts/list where I have an error "Problem sending the cart..." (before > patches are applied, using koha-testing-docker). Yes, that's because KTD doesn't have an SMTP server running. But you should look at the error logs before and after the patches. The errors should go from: [2021/08/23 12:45:40] [WARN] Error sending mail: Invalid 'to' parameter: tomascohen+á@gmail.com at /kohadevbox/koha/opac/opac-sendbasket.pl line 178. into [2021/08/23 13:11:22] [WARN] Error sending mail: unable to establish SMTP connection to localhost port 25 > All the tests now ass. :-D > Also, does this address the issue of being able to send emails with accents > and umlauts in them, or is that a separate bug? For example, I couldn't add > an email address for a patron or system preferences where it has an accent > or umlaut in either the address or the domain - get "Please enter a valid > email address.". It really depends on the context. But generally I'd say it is a different bug, as validation on (say) memberentry is done a JavaScript level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #10 from David Nind --- Oops... tat should have said "All tests pass"! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #9 from David Nind --- I attempted to test, but always seem to have a problem with sending carts/list where I have an error "Problem sending the cart..." (before patches are applied, using koha-testing-docker). All the tests now ass. Also, does this address the issue of being able to send emails with accents and umlauts in them, or is that a separate bug? For example, I couldn't add an email address for a patron or system preferences where it has an accent or umlaut in either the address or the domain - get "Please enter a valid email address.". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #2) > I don't know what to do. I have the feeling that what Ulrich is suggesting > is not the right thing as we are using the "Full name " format > for a while (bug 3280) now. > > On the other hand removing the validation seems bad as well. > > Adding a split in Koha::Email is not optimal (we could search for "<>" and > pass that to Email::Valid instead of the whole replyto string). > > Any good other suggestions, Tomas? I would like to add that if this solution based on Email::Address moves forward, I would like to make sure we don't build addresses manually, but pass Email::Address objects around instead. Or Koha::Email::Address objects if we wanted to do something Koha-ish on the addresses. I really like the library and the stringification it does. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 124004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124004=edit Bug 28870: Remove traces of Email::Valid Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 124003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124003=edit Bug 28870: Use Email::Address to validate email addresses This patch adds a new dependency, Email::Address. It is used in Koha::Email to replace the current use of Email::Valid, which proved to be problematic when it comes to UTF-8 characters. Email::Address provides suitable regexes that -when used- keep our tests passing, but also deal better with UTF-8 data. To test: 1. Apply the regression tests patch 2. Notice the only change is that it tweaks a couple addresses so they contain umlauts and also have the "Description " format that is used when sending carts. 3. Run: $ kshell k$ prove t/Koha/Email.t => FAIL: Tests fail! Things die because Email::Valid doesn't like the from we passed. 4. Run: $ sudo apt install libemail-address-perl 5. Apply this patch 6. Repeat 3 => SUCCESS: Tests pass! 7. Try what is described in comment 1 => SUCCESS: Things are back to normal 8. Sign off :-D 9. Send cookies Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 124002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124002=edit Bug 28870: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870
--- Comment #4 from Tomás Cohen Arazi ---
Ok, I've been playing with this. My conclusion is that Jonathan is right:
Email::Valid is buggy. I've learnt that regexps for validating RFC2822
addresses are not trivial [1]
The author/maintainer of the libraries we use, also maintains the
Email::Address library, that provides such regular expressions. My tests (on
Debian Buster) verify that Email::Address is able to handle UTF-8 characters
correctly.
I can submit a patch that replaces one library with the other (will probably do
it anyway) but I have doubts about the importance of validating email addresses
here. It feels like overkill.
[1] https://metacpan.org/pod/Email::Address#Package-Variables
The script I used for testing:
#!/usr/bin/perl
use Modern::Perl;
use utf8;
use Email::Address;
use Email::Valid;
binmode STDOUT, ':encoding(UTF-8)';
binmode STDERR, ':encoding(UTF-8)';
my $string = 'Tomás Cohen Arazi ';
my ($email) = Email::Address->parse($string);
## This construct could be used instead of manually crafting
## the address in the $string format above. Same results
# my $email = Email::Address->new(
# 'Tomás Cohen Arazi' => 'tomac...@theke.io'
# );
print "Testing address: $email\n";
say "Email::Address tests =>";
if ( "$email" =~ m/$Email::Address::mailbox/ ) {
say "Yay!";
}
else {
say "Boo!";
}
say "Email::Valid tests =>";
if (Email::Valid->address( -address => "$email", -fqdn => 0 )) {
say "Yay!";
}
else {
say "Boo!";
}
1;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |tomasco...@gmail.com --- Comment #3 from Tomás Cohen Arazi --- Trying something for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 --- Comment #2 from Jonathan Druart --- I don't know what to do. I have the feeling that what Ulrich is suggesting is not the right thing as we are using the "Full name " format for a while (bug 3280) now. On the other hand removing the validation seems bad as well. Adding a split in Koha::Email is not optimal (we could search for "<>" and pass that to Email::Valid instead of the whole replyto string). Any good other suggestions, Tomas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Jonathan Druart changed: What|Removed |Added Depends on||8000 Severity|normal |critical CC||jonathan.druart+koha@gmail. ||com, tomasco...@gmail.com --- Comment #1 from Jonathan Druart --- Email::Valid is no longer maintained and there are several known bugs (including this one). We should reconsider this module. https://github.com/Perl-Email-Project/Email-Valid/issues https://github.com/Perl-Email-Project/Email-Valid/issues/47 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 [Bug 8000] Test mode for notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Ulrich Kleiber changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28870] Cart shipping fails because of Non-ASCII characters in display-name of reply-to address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28870 Christian Stelzenmüller changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
