[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872
Bug 28872 depends on bug 26205, which changed state.

Bug 26205 Summary: News changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872
Bug 28872 depends on bug 14233, which changed state.

Bug 14233 Summary: Add logging support to notices and slips management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #25 from Fridolin Somers  ---
None are in 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Fridolin Somers  changed:

   What|Removed |Added

 Depends on||23971, 26205, 14233
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #24 from Fridolin Somers  ---
Those preferences are recent :
AcquisitionLog Bug 23971
NewsLogBug Bug 26205
NoticesLog Bug 14233


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233
[Bug 14233] Add logging support to notices and slips management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971
[Bug 23971] Add logging for basket related actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205
[Bug 26205] News changes aren't logged
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.03
released in||
 Status|Pushed to master|Pushed to stable

--- Comment #23 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #22 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #21 from Katrin Fischer  ---
(In reply to Kyle M Hall from comment #20)
> (In reply to Kyle M Hall from comment #19)
> > (In reply to Kyle M Hall from comment #18)
> > > (In reply to Katrin Fischer from comment #17)
> > > > Why do I not find any references to NewsLog outside of the log viewer 
> > > > tt?
> > > 
> > > It's from Bug 26205. You are right, something has happened
> > 
> > Removed by Bug 22544, looks like you caught a regression!
> 
> Looks like Bug 28717 is the fix.

Thx for poking this one some more - I had to run off yesterday shortly after
leaving the references comment :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #20 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #19)
> (In reply to Kyle M Hall from comment #18)
> > (In reply to Katrin Fischer from comment #17)
> > > Why do I not find any references to NewsLog outside of the log viewer tt?
> > 
> > It's from Bug 26205. You are right, something has happened
> 
> Removed by Bug 22544, looks like you caught a regression!

Looks like Bug 28717 is the fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #19 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > Why do I not find any references to NewsLog outside of the log viewer tt?
> 
> It's from Bug 26205. You are right, something has happened

Removed by Bug 22544, looks like you caught a regression!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #18 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #17)
> Why do I not find any references to NewsLog outside of the log viewer tt?

It's from Bug 26205. You are right, something has happened

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #17 from Katrin Fischer  ---
Why do I not find any references to NewsLog outside of the log viewer tt?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #123942|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 123958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123958=edit
Bug 28872: Fix QA issues on atomicupdate

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #123921|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 123957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123957=edit
Bug 28872: Atomicupdate to correct existing values

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #123911|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 123956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123956=edit
Bug 28872: make AcquisitionLog, NewsLog, NoticesLog use 1/0 for their values

To test:
1 - edit AcquisitionLog, NewsLog, NoticesLog to change their values
2 - in About Koha, see the errors noted above
3 - apply patch, restart services
4 - re-edit AcquisitionLog, NewsLog, NoticesLog to change their values again
5 - reload About, see errors are cleared
6 - confirm that actions are logged as expected when logs are on, not logged
when logs are off

Signed-off-by: Kelly 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #13 from Andrew Fuerste-Henry  ---
Thanks Jonathan and Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #12 from Jonathan Druart  ---
Sorry, I got a collision a couple of hours ago when I submitted the patch and
didn't realize until now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #11 from Jonathan Druart  ---
There was a problem in the skeleton file, I've fixed it in master and adjusted
the atomic update here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #123941|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  ---
Created attachment 123942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123942=edit
Bug 28872: Fix QA issues on atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #123940|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 123941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123941=edit
Bug 28872: (QA follow-up) Update printed messaged, fix file permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #8 from Kyle M Hall  ---
Created attachment 123940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123940=edit
Bug 28872: (QA follow-up) print a message describing what has happened

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #7 from Katrin Fischer  ---
Also my first! There are some problems noted by the QA script:

 FAIL   installer/data/mysql/atomicupdate/bug_28872_update_log_values.pl
   OK critic
   FAIL   file permissions
File must have the exec flag
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
Useless use of anonymous hash ({}) in void context 

The first one would be an easy fix, but not sure if strictly necessary.
updatedatabase still works correctly and the file will be removed.

The second one is a bit puzzling to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #6 from Andrew Fuerste-Henry  ---
Good call! I've added an atomicupdate to correct existing values. That
structure has changed a little since the last one I did, so please let me know
if I've done something wrong!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #5 from Andrew Fuerste-Henry  ---
Created attachment 123921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123921=edit
Bug 28872: Atomicupdate to correct existing values

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer  ---
Hm, I think we should add a database update here, to set the logs to 0 or 1
according to the current setting to fit what was actually selected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Kelly McElligott  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #123880|0   |1
is obsolete||

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 123911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123911=edit
Bug 28872: make AcquisitionLog, NewsLog, NoticesLog use 1/0 for their values

To test:
1 - edit AcquisitionLog, NewsLog, NoticesLog to change their values
2 - in About Koha, see the errors noted above
3 - apply patch, restart services
4 - re-edit AcquisitionLog, NewsLog, NoticesLog to change their values again
5 - reload About, see errors are cleared
6 - confirm that actions are logged as expected when logs are on, not logged
when logs are off

Signed-off-by: Kelly 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #2 from Andrew Fuerste-Henry  ---
A note on my test plan, the NewsLog is currently broken (bug 28717), so don't
expect it to log anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

--- Comment #1 from Andrew Fuerste-Henry  ---
Created attachment 123880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123880=edit
Bug 28872: make AcquisitionLog, NewsLog, NoticesLog use 1/0 for their values

To test:
1 - edit AcquisitionLog, NewsLog, NoticesLog to change their values
2 - in About Koha, see the errors noted above
3 - apply patch, restart services
4 - re-edit AcquisitionLog, NewsLog, NoticesLog to change their values again
5 - reload About, see errors are cleared
6 - confirm that actions are logged as expected when logs are on, not logged
when logs are off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2021-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com,
   ||ke...@bywatersolutions.com,
   ||sbr...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/