[Koha-bugs] [Bug 28909] Allow interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Resolution|--- |FIXED Summary|Allow Interlibrary loans|Allow interlibrary loans |illview method to use |illview method to use |backend template|backend template Status|Pushed to master|RESOLVED --- Comment #19 from Katrin Fischer --- This is marked as an enhancement - I am marking RESOLVED FIXED. But it also seems to have escaped RMaint review? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Assignee|bugzi...@warmlight.co.uk|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Martin Renvoize changed: What|Removed |Added Attachment #138857|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 138923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138923=edit Bug 28909: Fix handling if backend doesn't support If a backend hasn't been updated to support this functionality, we need to handle that gracefully Also, this commit fixes some indentation. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
Martin Renvoize changed:
What|Removed |Added
Attachment #138856|0 |1
is obsolete||
--- Comment #16 from Martin Renvoize ---
Created attachment 138922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138922=edit
Bug 28909: Allow illview to use backend template
This commit allows illview to use an intranet template supplied by the backend,
as
per other stages. The template must be named illview.inc
Test plan:
- Apply the patch
- Install FreeForm backend (https://github.com/PTFS-Europe/koha-ill-freeform)
- Create a request
- On the resulting "Manage ILL request" note the display is normal
- Create a new file in the FreeForm backend directory:
/intra-includes/illview.inc
with the following content:
[% BLOCK backend_jsinclude %]
(function() { alert("Working!"); })()
[% END %]
- Restart Plack if enabled
- Reload the page
=> TEST: Observe that the alert specified in the template is displayed
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #138858|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #15 from Katrin Fischer --- Created attachment 138858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138858=edit Bug 30484: Add ILL update notice Adds a new ILL_REQUEST_UPDATE notice which is to be used for the formation of notices informing users of updates to ILL requests. Commit includes database updates and template changes for messaging preferences Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Summary|Allow Interlibrary Loans|Allow Interlibrary loans |illview method to use |illview method to use |backend template|backend template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #124271|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 138857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138857=edit Bug 28909: Fix handling if backend doesn't support If a backend hasn't been updated to support this functionality, we need to handle that gracefully Also, this commit fixes some indentation. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
Katrin Fischer changed:
What|Removed |Added
Attachment #124174|0 |1
is obsolete||
--- Comment #13 from Katrin Fischer ---
Created attachment 138856
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138856=edit
Bug 28909: Allow illview to use backend template
This commit allows illview to use an intranet template supplied by the backend,
as
per other stages. The template must be named illview.inc
Test plan:
- Apply the patch
- Install FreeForm backend (https://github.com/PTFS-Europe/koha-ill-freeform)
- Create a request
- On the resulting "Manage ILL request" note the display is normal
- Create a new file in the FreeForm backend directory:
/intra-includes/illview.inc
with the following content:
[% BLOCK backend_jsinclude %]
(function() { alert("Working!"); })()
[% END %]
- Restart Plack if enabled
- Reload the page
=> TEST: Observe that the alert specified in the template is displayed
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Blocks||30484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484 [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Andrew Isherwood --- Hi Katrin It looks like one of the patches got obsoleted at some point, no idea how that happened! Anyway, it should apply now. I'm just working on a development that depends on this bug, and it applied cleanly, so hopefully you won't have any problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Attachment #124174|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #11 from Katrin Fischer --- I am really sorry I lost sight of this one, Andrew. I'll do better. Could you please rebase? 124271 - Bug 28909: Fix handling if backend doesn't support Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 28909: Fix handling if backend doesn't support error: sha1 information is lacking or useless (Koha/Illrequest.pm). error: could not build fake ancestor Patch failed at 0001 Bug 28909: Fix handling if backend doesn't support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #124271|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #129103|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #129102|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Attachment #129104|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #10 from Andrew Isherwood --- Hi Nick, I think you've attached your patches to the wrong bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #9 from Nick Clemens --- Created attachment 129104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129104=edit Bug 28909: (follow-up) Update test for warning and rename variable Variable was updated for params, need to update declaration too Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #8 from Nick Clemens --- Created attachment 129103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129103=edit Bug 29809: Update stockration tool to reflect method name change Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Nick Clemens changed: What|Removed |Added Attachment #124174|0 |1 is obsolete|| Attachment #124271|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 129102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129102=edit Bug 29809: Rename item relation accessor from itemnumber This patch renames the item relation accessor method in StockRotationItem to 'item' from 'itemnumber' to more clearly reflect that the method returns a Koha::Item object and not an itemnumber. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Martin Renvoize changed: What|Removed |Added CC||mag...@libriotech.no, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Attachment #124270|0 |1 is obsolete|| --- Comment #6 from Andrew Isherwood --- Created attachment 124271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124271=edit Bug 28909: Fix handling if backend doesn't support If a backend hasn't been updated to support this functionality, we need to handle that gracefully Also, this commit fixes some indentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #5 from Katrin Fischer --- Hi Andrew, thx! I'll try to come back to this, but it might take a few days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #4 from Andrew Isherwood --- Arghhh, sorry Katrin, my mistake. I'd forgotten to push up the patches to the FreeForm backend that makes this work! I now have done so, so if you pull the latest backend, it should be fine. I've also fixed the problem you saw, if a backend hasn't been updated to support this new functionality, it shouldn't break in the way you saw! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 --- Comment #3 from Andrew Isherwood --- Created attachment 124270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124270=edit Bug 28909: Fix handling if backend doesn't support If a backend hasn't been updated to support this functionality, we need to handle that gracefully Also, this commit fixes some indentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer --- Hi Andrew, I tried to test this and it's well possible I misunderstood something, but I am stuck with: Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 121 I've triple checked the contents of my illview.inc and I just can't spot any error. Also did multiple restart_all, so Plack should not be the issue. Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
--- Comment #1 from Andrew Isherwood ---
Created attachment 124174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124174=edit
Bug 28909: Allow illview to use backend template
This commit allows illview to use an intranet template supplied by the backend,
as
per other stages. The template must be named illview.inc
Test plan:
- Apply the patch
- Install FreeForm backend (https://github.com/PTFS-Europe/koha-ill-freeform)
- Create a request
- On the resulting "Manage ILL request" note the display is normal
- Create a new file in the FreeForm backend directory:
/intra-includes/illview.inc
with the following content:
[% BLOCK backend_jsinclude %]
(function() { alert("Working!"); })()
[% END %]
- Restart Plack if enabled
- Reload the page
=> TEST: Observe that the alert specified in the template is displayed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28909] Allow Interlibrary Loans illview method to use backend template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
