[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36081 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #30 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #29) > I could have sworn there were uses... the brain fades. All good :-D I'm gonna do the follow-ups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #29 from Martin Renvoize --- I could have sworn there were uses... the brain fades. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #27) > And we are not using it anywhere? Next step? I might have made a mistake/oversight when pushed this. I was sure I abandoned it. I'll file a follow-up bug for using it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #27 from Jonathan Druart --- And we are not using it anywhere? Next step? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Martin Renvoize changed: What|Removed |Added Text to go in the|This addition adds a simple |This addition adds a simple release notes|way to retrieve a pipe |way to retrieve pipe |delimited list type system |delimited list type system |preference as an|preferences as arrays. |easy-to-use array. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Martin Renvoize changed: What|Removed |Added Text to go in the||This addition adds a simple release notes||way to retrieve a pipe ||delimited list type system ||preference as an ||easy-to-use array. CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #26 from Fridolin Somers --- Enhancement not pushed to 23.05.x I'll push if is becomes a needed dependancy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords|rel_23_05_candidate |rel_23_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What|Removed |Added Attachment #125031|0 |1 is obsolete|| --- Comment #24 from Marcel de Rooy --- Created attachment 142291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142291=edit Bug 29033: Add C4::Context->multivalue_preference I've seen several places in which a syspref is retrieved and then splitted using split and the fact they are pipe-separated strings. It seems it would be simple (and handy) to add a method to do that. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Context.t => SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved as an arrayref. 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #23 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #21) > I think we are generally on the same page, but with a slightly different > approach. Trying to explain: I want to implement the ideal solution and then > migrate things one by one into it. You are proposing a somewhat intermediate > thing that will need to be redone (removing the separator). The goal is the > same. Oke. Lets push the ideal solution then ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #22 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #21) > (In reply to Marcel de Rooy from comment #20) > > > > You say All or nothing here? > > I think we are generally on the same page, but with a slightly different > approach. Trying to explain: I want to implement the ideal solution and then > migrate things one by one into it. You are proposing a somewhat intermediate > thing that will need to be redone (removing the separator). The goal is the > same. > > I'll try to provide an implementation of the YAML version ASAP. Great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #20) > > You say All or nothing here? I think we are generally on the same page, but with a slightly different approach. Trying to explain: I want to implement the ideal solution and then migrate things one by one into it. You are proposing a somewhat intermediate thing that will need to be redone (removing the separator). The goal is the same. I'll try to provide an implementation of the YAML version ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #20 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #19) > I disagree with the 'all or nothing' argument. That's why some really nice > devs have sitted for years without people willing to test them. Maybe we are not on the same level here? But imo you want all or nothing, and I recommend a gradual approach. Note that we several prefs using other separators still. > I don't like the idea of over-complicating it with a separator param (that > will need to have its own unit tests, handling the escaping that is required > on each case, etc). But... This really should be trivial. > ... Now that I think about this, we could probably just stick to YAML > internally on the DB. And not even deal with splitting manually. Sounds good but also a larger project. > PS: Honestly, I didn't know what to answer to your comment. The amount of > time needed to do the separator thing is probably the same as moving > sysprefs into making them all use the same separator. And I have my personal > preferences on what to spend time on too heh You say All or nothing here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #19 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > My comment9 still holds. > You did not spend these 5 minutes yet. > For me this is a FQA ? I disagree with the 'all or nothing' argument. That's why some really nice devs have sitted for years without people willing to test them. I don't like the idea of over-complicating it with a separator param (that will need to have its own unit tests, handling the escaping that is required on each case, etc). But... ... Now that I think about this, we could probably just stick to YAML internally on the DB. And not even deal with splitting manually. Thoughts? PS: Honestly, I didn't know what to answer to your comment. The amount of time needed to do the separator thing is probably the same as moving sysprefs into making them all use the same separator. And I have my personal preferences on what to spend time on too heh -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #18 from Marcel de Rooy --- My comment9 still holds. You did not spend these 5 minutes yet. For me this is a FQA ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31333 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #17 from Tomás Cohen Arazi --- Can we move this one forward? I keep seeing devs adding random separators and it really makes no sense not having a high-level way to handle multivalued sysprefs. Jonathan and all: the next steps are moving all multivalued sysprefs into this. And adding a generic JS tool to deal with multivalued sysprefs in a way users don't need to deal with the (internal) separator. But please, first things first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #16 from Jonathan Druart --- Next steps? Is there a plan here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|testo...@bugs.koha-communit ||y.org Status|Failed QA |Signed Off --- Comment #15 from Marcel de Rooy --- Back to SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #14 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #13) > I have filed a separate bug for the prefs - bug 29829, so maybe we could > move the discussion about the 'end user side' there. Great idea. My point was to start a discussion about all this, do we are in a good track. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #13 from Katrin Fischer --- I am more thinking of people coming new to the project - it's really hard to learn all the 'internals' already right now. You have to get familiar with a whole lot of things. That's just another perspective. I wonder if some prefs have chosen the separator because of the contents not containing it or because the way they are used makes it easier to use them like that (ILS-DI:AuthorizedIPs maybe?) I have filed a separate bug for the prefs - bug 29829, so maybe we could move the discussion about the 'end user side' there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #12 from Tomás Cohen Arazi --- I always prefer to have a high level method that you just call without knowing how it is internally implemented, and the POD tells you what it will return. It is consistent with some other methods we have for accessing sysprefs even. I don't want the callers to need to know how that syspref needs to be splitter, the same way I think it is non sense for end users to need to worry about that on the front end If there is consensus, I can spend a few hours migrating all sysprefs to use the same separator. Keep in mind that we might need to escape whichever separator we pick on sysprefs that used a different one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29829 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033
--- Comment #11 from Katrin Fischer ---
I think Tomas is right about that we should make the prefs all behave the same
(using the same separator) as this is a nuisance right now and requires
constant 'looking up' of the syntax to use for each.
Having a nice GUI component would make it even nicer.
I am always a little doubful about wrapping a one liner in perl into an
additional method. Basically this:
my $values = [ split qr{\|}, $syspref ];
So I see a lot of gain in making things more consistent and refining the GUI,
but I am not sure as it is right now a separate method is really required?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033
--- Comment #10 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #9)
> (In reply to Tomás Cohen Arazi from comment #8)
> > (In reply to Marcel de Rooy from comment #7)
> > > +sub multivalue_preference {
> > > +my ( $self, $preference ) = @_;
> > > +
> > > +my $syspref = $self->preference($preference) // q{};
> > > +my $values = [ split qr{\|}, $syspref ];
> > > +
> > > +return $values;
> > > +}
> > >
> > > I agree that we need a parameter here to pass other separators.
> > > Multi value, multi sepa :)
> >
> > Counter proposal:
> > 1. Accept this as-is
> > 2. Implement a nice UI to abstract users from the separator being used
> > 3. Migrate sysprefs into using this
>
> Point 1: No ! :)
> Point 2: Fine with me.
> Point 3: Great. (Just gradually move away from sending the sepa param.)
>
> You need 5 mins to do the thing. We need 5 years for the rest ;)
Well, it is always the same chicken-egg situation: one proposes something, for
enhancing things, and waits for feedback before moving into changing all the
things. And some people want you to do all the things to get convinced of the
idea. It's a hard one. I'm fine with ad-hoc splitting code for now. But this is
something we could do better, specially point 2. Plus, I don't think there are
that many sysprefs that require this (many == more than 20).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033
--- Comment #9 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> > +sub multivalue_preference {
> > +my ( $self, $preference ) = @_;
> > +
> > +my $syspref = $self->preference($preference) // q{};
> > +my $values = [ split qr{\|}, $syspref ];
> > +
> > +return $values;
> > +}
> >
> > I agree that we need a parameter here to pass other separators.
> > Multi value, multi sepa :)
>
> Counter proposal:
> 1. Accept this as-is
> 2. Implement a nice UI to abstract users from the separator being used
> 3. Migrate sysprefs into using this
Point 1: No ! :)
Point 2: Fine with me.
Point 3: Great. (Just gradually move away from sending the sepa param.)
You need 5 mins to do the thing. We need 5 years for the rest ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033
--- Comment #8 from Tomás Cohen Arazi ---
(In reply to Marcel de Rooy from comment #7)
> +sub multivalue_preference {
> +my ( $self, $preference ) = @_;
> +
> +my $syspref = $self->preference($preference) // q{};
> +my $values = [ split qr{\|}, $syspref ];
> +
> +return $values;
> +}
>
> I agree that we need a parameter here to pass other separators.
> Multi value, multi sepa :)
Counter proposal:
1. Accept this as-is
2. Implement a nice UI to abstract users from the separator being used
3. Migrate sysprefs into using this
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||m.de.r...@rijksmuseum.nl
--- Comment #7 from Marcel de Rooy ---
+sub multivalue_preference {
+my ( $self, $preference ) = @_;
+
+my $syspref = $self->preference($preference) // q{};
+my $values = [ split qr{\|}, $syspref ];
+
+return $values;
+}
I agree that we need a parameter here to pass other separators.
Multi value, multi sepa :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #6 from David Cook --- (In reply to Tomás Cohen Arazi from comment #5) > In my opinion, that's a totally different problem, which we could cleary > address by making all multi-valued sysprefs behave consistently. I was thinking that a bit as well. Don't we have some multi-value preferences that use select lists as well? I'm not sure how those work though. I've been debating whether it would be better to return different data types with C4::Context->preference or if having C4::Context->multivalue_preference makes sense... and I think you might be right. (I mean if we were starting over, it would make sense for the preference to be an object and then that object would have the appropriate methods, but we have to work with what we have...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #5 from Tomás Cohen Arazi --- (In reply to David Cook from comment #3) > I don't know about this one... > > There are also multi value preferences that don't use pipes. Many > preferences like "NotesToHide" and "ILS-DI:AuthorizedIPs" use commas instead. In my opinion, that's a totally different problem, which we could cleary address by making all multi-valued sysprefs behave consistently. Thanks for the examples, BTW. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #4 from David Cook --- "SubfieldsToAllowForRestrictedBatchmod", "SubfieldsToAllowForRestrictedEditing", and "SubfieldsToUseWhenPrefill" are separated by spaces. "AdvancedSearchLanguages" is separated by pipe or comma, which would make this method particularly problematic... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I don't know about this one... There are also multi value preferences that don't use pipes. Many preferences like "NotesToHide" and "ILS-DI:AuthorizedIPs" use commas instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 David Nind changed: What|Removed |Added Attachment #124921|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 125031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125031=edit Bug 29033: Add C4::Context->multivalue_preference I've seen several places in which a syspref is retrieved and then splitted using split and the fact they are pipe-separated strings. It seems it would be simple (and handy) to add a method to do that. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Context.t => SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved as an arrayref. 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 124921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124921=edit Bug 29033: Add C4::Context->multivalue_preference I've seen several places in which a syspref is retrieved and then splitted using split and the fact they are pipe-separated strings. It seems it would be simple (and handy) to add a method to do that. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Context.t => SUCCESS: Tests pass, a pipe-separated syspref is correctly retrieved as an arrayref. 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29033] Add C4::Context->multivalue_preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29033 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
