[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 --- Comment #10 from Kyle M Hall --- Created attachment 139830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139830=edit Bug 29094: Adding hold via SIP should check if patron can hold item first [21.11.x] When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Arthur Suzuki changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED CC||arthur.suz...@biblibre.com --- Comment #9 from Arthur Suzuki --- Patch applies with conflicts + tests failing. Please provide a patch for 21.11 if needed. " # Failed test 'do_hold' # at t/db_dependent/SIP/Transaction.t line 272. DBIx::Class::ResultSource::_minimal_valueset_satisfying_constraint(): Unable to satisfy requested constraint 'primary', missing values for column(s): 'itemnumber' at /kohadevbox/koha/Koha/Objects.pm line 96 # Looks like your test exited with 11 just after 7. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 6/12 subtests " -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.05 released in|| --- Comment #8 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Thanks Kyle, Works as described, contains unit tests and QA scripts are all happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Martin Renvoize changed: What|Removed |Added Attachment #136611|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 137706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137706=edit Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 David Nind changed: What|Removed |Added Text to go in the||This fixes holds placed release notes||using SIP2 to check that ||the patron can actually ||place a hold for the item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 David Nind changed: What|Removed |Added Attachment #136570|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 136611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136611=edit Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Kyle M Hall changed: What|Removed |Added Attachment #125189|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 136570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136570=edit Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind --- The patch no longer applies 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29094: Adding hold via SIP should check if patron can hold item first Using index info to reconstruct a base tree... M t/db_dependent/SIP/ILS.t M t/db_dependent/SIP/Transaction.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/SIP/Transaction.t CONFLICT (content): Merge conflict in t/db_dependent/SIP/Transaction.t Auto-merging t/db_dependent/SIP/ILS.t error: Failed to merge in the changes. Patch failed at 0001 Bug 29094: Adding hold via SIP should check if patron can hold item first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 --- Comment #1 from Kyle M Hall --- Created attachment 125189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125189=edit Bug 29094: Adding hold via SIP should check if patron can hold item first When placing holds via SIP2, there is no holdability check. This seems very incorrect. Test Plan: 1) Apply this patch 2) prove -r t/db_dependent/SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29094] Placing holds via SIP2 does not check if a patron can hold the given item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29094 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
