[Koha-bugs] [Bug 29105] Add effective_item_type_id to the API items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Katrin Fischer changed: What|Removed |Added Summary|Add effective_item_type_id |Add effective_item_type_id |to the api items responses |to the API items responses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #21 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. API doc is generated, nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Arthur Suzuki changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||arthur.suz...@biblibre.com Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in||21.11.12 --- Comment #20 from Arthur Suzuki --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Version(s)|22.11.00|22.11.00, 22.05.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #19 from Lucas Gass --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #18 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA CC||n...@bywatersolutions.com --- Comment #17 from Nick Clemens --- I think this is fine, as long as this feature (item-level_itpyes set to 'biblio') exists - libraries using biblio itemtypes seem to be in the minority according to: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29106 If we remove the feature later, we remove the extra field small patch, straight to PQA to let RM weigh in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Nick Clemens changed: What|Removed |Added Attachment #137505|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 137573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137573=edit Bug 29105: Add effective_itemtype handling to items api This patch adds effective_item_type_id to the items api. We overload the to_api method to append the effective_item_type_id field with that of the effective itemtype code. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Nick Clemens changed: What|Removed |Added Attachment #137504|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 137572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137572=edit Bug 29105: Unit test This patch adds a unit test for the addition of effective_item_type_id to the items responses. Test plan 1) Run the unit test prior to applying the second patch and confirm it fails 2) Apply the second patch and confirm the unit test now passes Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Blocks||31084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084 [Bug 31084] Display item type in bundle management table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Blocks||31128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31128 [Bug 31128] REST API item not_for_loan_status doesn't respect biblio level fallbacks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #14 from Martin Renvoize --- I'm still somewhat torn here.. it feels wrong somehow to require intimate knowledge of how Koha works with regards to overloading features to be able to use this API route.. an average consumer won't necessarily understand the difference between these fields. I wondered about taking an alternate approach of requiring a header to revert from automatically replacing item_type_id with the effective equivalent instead to allow for Koha staff client use on the editing of item pages. Difficult! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 --- Comment #13 from Martin Renvoize --- Patches updated as requested and not handling notforloan status as I'll submit that as another bug We now return both item_type_id and the new effective_item_type_id field in the same response. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29105] Add effective_item_type_id to the api items responses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29105 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Needs Signoff Summary|items responses do not |Add effective_item_type_id |respect effective_itemtype |to the api items responses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
