[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Owen Leonard changed: What|Removed |Added Blocks||35006 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35006 [Bug 35006] OPAC holdings table - sort for current library column doesn't work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/665 CC||caroline.cyr-la-rose@inlibr ||o.com Documentation||Caroline Cyr La Rose contact|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com --- Comment #77 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144
--- Comment #76 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #75)
> (In reply to Marcel de Rooy from comment #73)
> > (In reply to Jonathan Druart from comment #72)
> > > Caught by Owen on IRC: DT search is broken (general search when searching
> > > for libraries).
> > >
> > > Uncaught TypeError: col.data.split is not a function
> > >
> > > It's because opac_info is searchable but "data" is a function:
> > >
> > > "data": function( row, type, val, meta ) {
> > > return ''; // provisional placeholder for opac_info
> > > },
> > > "searchable": true,
> > > "visible": false,
> > > "orderable": false
>
> I am seeing several columns where data is a function btw.
>
> "data": function( row, type, val, meta ) {
> const library_info = [];
>
> "data": function( row, type, val, meta ) {
> var result = ' href="/cgi-bin/koha/admin/branches.pl?op=add_form&
> branchcode='+encodeURIComponent(row.library_id)+'" role="button"> class="fa fa-pencil" aria-hidden="true"> '+_("Edit")+'';
Addressed all three columns on bug 31842. Please test.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144
--- Comment #75 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #73)
> (In reply to Jonathan Druart from comment #72)
> > Caught by Owen on IRC: DT search is broken (general search when searching
> > for libraries).
> >
> > Uncaught TypeError: col.data.split is not a function
> >
> > It's because opac_info is searchable but "data" is a function:
> >
> > "data": function( row, type, val, meta ) {
> > return ''; // provisional placeholder for opac_info
> > },
> > "searchable": true,
> > "visible": false,
> > "orderable": false
I am seeing several columns where data is a function btw.
"data": function( row, type, val, meta ) {
const library_info = [];
"data": function( row, type, val, meta ) {
var result = '
'+_("Edit")+'';
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Keywords|additional_work_needed | Blocks||31842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31842 [Bug 31842] Fix rebase issue for branches.tt from 29144 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #74 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #73) > > It could be considered a bug from datatables.js, but I don't think it is. We > > should fix branch.tt instead. > > Will probably open a new report for this. Bug 31842. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144
--- Comment #73 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #72)
> Caught by Owen on IRC: DT search is broken (general search when searching
> for libraries).
>
> Uncaught TypeError: col.data.split is not a function
>
>
> It's because opac_info is searchable but "data" is a function:
>
> "data": function( row, type, val, meta ) {
> return ''; // provisional placeholder for opac_info
> },
> "searchable": true,
> "visible": false,
> "orderable": false
>
> It could be considered a bug from datatables.js, but I don't think it is. We
> should fix branch.tt instead.
Will probably open a new report for this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
CC||jonathan.druart+koha@gmail.
||com
--- Comment #72 from Jonathan Druart ---
Caught by Owen on IRC: DT search is broken (general search when searching for
libraries).
Uncaught TypeError: col.data.split is not a function
It's because opac_info is searchable but "data" is a function:
"data": function( row, type, val, meta ) {
return ''; // provisional placeholder for opac_info
},
"searchable": true,
"visible": false,
"orderable": false
It could be considered a bug from datatables.js, but I don't think it is. We
should fix branch.tt instead.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Blocks||31775 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 [Bug 31775] Show opac_info of single library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Bug 29144 depends on bug 31313, which changed state. Bug 31313 Summary: Remove GetItemsInfo from opac-detail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #71 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #70 from Tomás Cohen Arazi --- Created attachment 140707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140707&action=edit Bug 29144: (QA follow-up) Make update idempotent Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #69 from Marcel de Rooy --- Rebased for 27272 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139371|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139377|0 |1 is obsolete|| --- Comment #68 from Marcel de Rooy --- Created attachment 140030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140030&action=edit Bug 29144: (follow-up) Fix rebase issue related to bug 31313 Fixing display of holding branch name. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139376|0 |1 is obsolete|| --- Comment #67 from Marcel de Rooy --- Created attachment 140029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140029&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139375|0 |1 is obsolete|| --- Comment #66 from Marcel de Rooy --- Created attachment 140028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140028&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139374|0 |1 is obsolete|| --- Comment #65 from Marcel de Rooy --- Created attachment 140027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140027&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139373|0 |1 is obsolete|| --- Comment #64 from Marcel de Rooy --- Created attachment 140026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140026&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139372|0 |1 is obsolete|| --- Comment #63 from Marcel de Rooy --- Created attachment 140025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140025&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139370|0 |1 is obsolete|| --- Comment #62 from Marcel de Rooy --- Created attachment 140024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140024&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139369|0 |1 is obsolete|| --- Comment #61 from Marcel de Rooy --- Created attachment 140023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140023&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139368|0 |1 is obsolete|| --- Comment #60 from Marcel de Rooy --- Created attachment 140022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140022&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139367|0 |1 is obsolete|| --- Comment #59 from Marcel de Rooy --- Created attachment 140021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140021&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139366|0 |1 is obsolete|| --- Comment #58 from Marcel de Rooy --- Created attachment 140020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140020&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #57 from Martin Renvoize --- Great work, all working as expected, no regressions spotted and QA scripts are happy. Nicely broken down, the commits were generally easy to follow. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139208|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 139377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139377&action=edit Bug 29144: (follow-up) Fix rebase issue related to bug 31313 Fixing display of holding branch name. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139207|0 |1 is obsolete|| --- Comment #55 from Martin Renvoize --- Created attachment 139376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139376&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139206|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize --- Created attachment 139375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139375&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139205|0 |1 is obsolete|| --- Comment #53 from Martin Renvoize --- Created attachment 139374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139374&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139204|0 |1 is obsolete|| --- Comment #52 from Martin Renvoize --- Created attachment 139373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139373&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139203|0 |1 is obsolete|| --- Comment #51 from Martin Renvoize --- Created attachment 139372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139372&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139202|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize --- Created attachment 139371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139371&action=edit Bug 29144: Remove opac_info from GetItemsInfo Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139201|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize --- Created attachment 139370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139370&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139200|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize --- Created attachment 139369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139369&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139199|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize --- Created attachment 139368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139368&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139198|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 139367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139367&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Martin Renvoize changed: What|Removed |Added Attachment #139197|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 139366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139366&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Blocks||29190 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29190 [Bug 29190] Additional contents: Cache selected records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #44 from Marcel de Rooy --- The GetItemsInfo created the need for a fast rebase: Applying: Bug 29144: Show html opac_info on opac-detail page CONFLICT (content): Merge conflict in opac/opac-detail.pl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Related to 31313 It needed a tiny follow-up as well to fix a rebase issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Depends on||31313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 [Bug 31313] Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #43 from Marcel de Rooy --- Created attachment 139208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139208&action=edit Bug 29144: (follow-up) Fix rebase issue related to bug 31313 Fixing display of holding branch name. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139192|0 |1 is obsolete|| --- Comment #42 from Marcel de Rooy --- Created attachment 139207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139207&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139191|0 |1 is obsolete|| --- Comment #41 from Marcel de Rooy --- Created attachment 139206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139206&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139190|0 |1 is obsolete|| --- Comment #40 from Marcel de Rooy --- Created attachment 139205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139205&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139189|0 |1 is obsolete|| --- Comment #39 from Marcel de Rooy --- Created attachment 139204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139204&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139188|0 |1 is obsolete|| --- Comment #38 from Marcel de Rooy --- Created attachment 139203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139203&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139187|0 |1 is obsolete|| --- Comment #37 from Marcel de Rooy --- Created attachment 139202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139202&action=edit Bug 29144: Remove opac_info from GetItemsInfo Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139186|0 |1 is obsolete|| --- Comment #36 from Marcel de Rooy --- Created attachment 139201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139201&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139185|0 |1 is obsolete|| --- Comment #35 from Marcel de Rooy --- Created attachment 139200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139200&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139184|0 |1 is obsolete|| --- Comment #34 from Marcel de Rooy --- Created attachment 139199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139199&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139183|0 |1 is obsolete|| --- Comment #33 from Marcel de Rooy --- Created attachment 139198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139198&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #139182|0 |1 is obsolete|| --- Comment #32 from Marcel de Rooy --- Created attachment 139197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139197&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #31 from Owen Leonard --- Created attachment 139192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139192&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #30 from Owen Leonard --- Created attachment 139191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139191&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #29 from Owen Leonard --- Created attachment 139190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139190&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #28 from Owen Leonard --- Created attachment 139189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139189&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #27 from Owen Leonard --- Created attachment 139188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139188&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #26 from Owen Leonard --- Created attachment 139187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139187&action=edit Bug 29144: Remove opac_info from GetItemsInfo Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #25 from Owen Leonard --- Created attachment 139186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139186&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #24 from Owen Leonard --- Created attachment 139185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139185&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #23 from Owen Leonard --- Created attachment 139184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139184&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #22 from Owen Leonard --- Created attachment 139183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139183&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Owen Leonard changed: What|Removed |Added Attachment #138599|0 |1 is obsolete|| Attachment #138600|0 |1 is obsolete|| Attachment #138601|0 |1 is obsolete|| Attachment #138602|0 |1 is obsolete|| Attachment #138603|0 |1 is obsolete|| Attachment #138604|0 |1 is obsolete|| Attachment #138605|0 |1 is obsolete|| Attachment #138606|0 |1 is obsolete|| Attachment #138607|0 |1 is obsolete|| Attachment #138608|0 |1 is obsolete|| Attachment #138609|0 |1 is obsolete|| --- Comment #21 from Owen Leonard --- Created attachment 139182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139182&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31288 --- Comment #20 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #19) > Martin, saw this comment on irc: > > Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a > pending issue in patron->delete with lists. > > Is that a mistake comment in `Bug 29144: Add $contents->find_best_match, > $library->opac_info` > > No it wasnt. But in the meantime the fix for checking userenv on > disown_or_delete has been pushed. So it is no longer relevant. > One of the tests included a patron delete and could fail on this issue. Bug 31288 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #19 from Marcel de Rooy --- Martin, saw this comment on irc: Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Is that a mistake comment in `Bug 29144: Add $contents->find_best_match, $library->opac_info` No it wasnt. But in the meantime the fix for checking userenv on disown_or_delete has been pushed. So it is no longer relevant. One of the tests included a patron delete and could fail on this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Text to go in the||This reports moves the release notes||contents of column ||branches.opac_info to a ||HTML block under Additional ||contents, identified by the ||new location ||OpacLibraryInfo. ||This ||allows translation of this ||block too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #18 from Marcel de Rooy --- Created attachment 138609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138609&action=edit Bug 29144: (DBIx schema) Drop branches.opac_info No test plan. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #17 from Marcel de Rooy --- Created attachment 138608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138608&action=edit Bug 29144: Copy and remove branches.opac_info (dbrev) Test plan: Run dbrev. Check api URL: /api/v1/public/libraries (with/without suffix /[branch_code]. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #16 from Marcel de Rooy --- Created attachment 138607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138607&action=edit Bug 29144: Remove opac_info from a few tests Test plan: Run t/db_dependent/Circulation/GetHardDueDate.t Run t/db_dependent/Circulation/OfflineOperation.t Run t/db_dependent/RotatingCollections.t Run t/db_dependent/api/v1/libraries.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #15 from Marcel de Rooy --- Created attachment 138606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138606&action=edit Bug 29144: Adjust libraries form Test plan: [1] Go to Administration / libraries. [2] Check list view. [3] Check view on individual library with/without opac info. [4] Edit individual library with/without opac info. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #14 from Marcel de Rooy --- Created attachment 138605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138605&action=edit Bug 29144: Show html opac_info on opac-detail page Note: This patch disables the API call (which is not really needed), and still needs attention in a following patch. Test plan: Add opac_info for two libraries and a branchurl for one of the two. Select a biblio with an item having these two libraries as either home or holding branch. Toggle OpacLocationBranchToDisplay and check items table on opac detail. Click on the library name. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #13 from Marcel de Rooy --- Created attachment 138604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138604&action=edit Bug 29144: Remove opac_info from GetItemsInfo Test plan: Run t/db_dependent/Items.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #12 from Marcel de Rooy --- Created attachment 138603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138603&action=edit Bug 29144: Use ->opac_info in opac-library template The opac_info call uses find_best_match which does not result in the All libaries plus specific library response of AdditionalContents.get. Test plan: Revisit individual library page on OPAC. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #138528|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 138602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138602&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #138527|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 138601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138601&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #138474|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 138600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138600&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Attachment #138473|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 138599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138599&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31275 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #7 from Marcel de Rooy --- Created attachment 138528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138528&action=edit Bug 29144: Add $contents->find_best_match, $library->opac_info Test plan: Run t/db_dependent/Koha/AdditionalContents.t Run t/db_dependent/Koha/Library.t Note: You may need to set ListOwnershipUponPatronDeletion to delete to fix a pending issue in patron->delete with lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #6 from Marcel de Rooy --- Created attachment 138527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138527&action=edit Bug 29144: (follow-up) Terminology: rename to OpacLibraryInfo git grep -l OpacBranchInfo | xargs sed -i -e's/OpacBranchInfo/OpacLibraryInfo/g' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Summary|Make branches.opac_info |Move branches.opac_info to |suitable for multi language |AdditionalContents allowing |use |multi language -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #3 from Marcel de Rooy --- Created attachment 138473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138473&action=edit Bug 29144: First sort the HTML options Test plan: Check result while adding a new HTML customization entry. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Marcel de Rooy --- Still work in progress -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 --- Comment #4 from Marcel de Rooy --- Created attachment 138474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138474&action=edit Bug 29144: Add OpacBranchInfo as HTML option, show it on opac Test plan: Add a few OpacBranchInfo for libraries. Verify that opac-library shows the correct info per library. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
