[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #74 from Katrin Fischer  ---
(In reply to Victor Grousset/tuxayo from comment #73)
> > We build our own packages, maybe that could have something to do with it?
> 
> Maybe somehow it's not in the dependencies.
> Otherwise it would have been installed. VS the official package that indeed
> installs it, since when using ktd it is installed by default.
> 
> So something up when making the list of deps. You also build the perl deps I
> suppose?

Hi Victor, thanks for looking into this. I talked to our admin and the
weirdness was limited to one server, it worked on others, so it's all ok now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #73 from Victor Grousset/tuxayo  ---
> We build our own packages, maybe that could have something to do with it?

Maybe somehow it's not in the dependencies.
Otherwise it would have been installed. VS the official package that indeed
installs it, since when using ktd it is installed by default.

So something up when making the list of deps. You also build the perl deps I
suppose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #72 from Katrin Fischer  ---
(In reply to Victor Grousset/tuxayo from comment #71)
> when doing apt search libemail-address-perl, do you have results? And is it
> installed?

Already fixed now by installing it, so I assume it wasn't.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #71 from Victor Grousset/tuxayo  ---
when doing apt search libemail-address-perl, do you have results? And is it
installed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #70 from Katrin Fischer  ---
(In reply to Victor Grousset/tuxayo from comment #69)
> Address::Email isn't in the cpanfile nor the cpanfile of the subsequent Koha
> releases.
> grepping Address::Email yield nothing in the code of 20.11.x
> Do you mean Email::Address?
> 
> It's in the cpanfile so it should be in our repo.

Yes, it didn't start and gave compilation errors. Also Email::Address of course
:) We build our own packages, maybe that could have something to do with it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #69 from Victor Grousset/tuxayo  ---
Address::Email isn't in the cpanfile nor the cpanfile of the subsequent Koha
releases.
grepping Address::Email yield nothing in the code of 20.11.x
Do you mean Email::Address?

It's in the cpanfile so it should be in our repo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #68 from Victor Grousset/tuxayo  ---
So Koha doesn't start due to a missing dep?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2022-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #67 from Katrin Fischer  ---
We just updated to 20.11.19 and Address::Email is missing/hasn't been installed
it looks like. Is this a local glitch or could it be a real issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-12-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|21.11.00,21.05.05   |21.11.00,21.05.05,20.11.13
released in||

--- Comment #66 from Victor Grousset/tuxayo  ---
Let's be optimistic.
Backported: Pushed to 20.11.x branch for 20.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-12-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #65 from Victor Grousset/tuxayo  ---
About the backport for 20.11, the conflict was a bit though to solve but the
test plan works as expected. I also tested a hold notice. So I hope nothing is
broken.
Is there anything else I must test before pushing this for the next release?

For the record here is a branch with the backport:
https://gitlab.com/tuxayo/Koha/-/commits/20.11.x-with-29330-attempt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #64 from David Cook  ---
(In reply to Kyle M Hall from comment #56)
> Pushed to 21.05.x for 21.05.05

Should this be 21.05.06? I only notice it in the git tag v21.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-12-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #63 from Victor Grousset/tuxayo  ---
> So it turns out I don't care about this bug :P

3 weeks later, now I'm maintaining 20.11.x so back to here ^^"

I'll see what I can do. It's a blocker after all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #62 from Victor Grousset/tuxayo  ---
Indeed.

Wait, I though I really needed this one for 20.05 but it's not even affected
since it's about a feature that came in 20.11

So it turns out I don't care about this bug :P

See ya!
<= 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #61 from Fridolin Somers  ---
Ich not easy.
I prefer not risking breaking all email feature just before 20.11.12 release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #60 from Victor Grousset/tuxayo  ---
Yes, that's how it looks :)

And bug 28803 made it to oldstable anyway. Possibility 2 of comment 58 happened
^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28803

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #59 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #50)
> No actual dependency it seems. bug 28803 adds a catch and this patch adds
> code in the try.

So you're saying that the merge conflict is just due to the surrounding lines
being different so it can't auto-merge without manual intervention? That's not
so bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #58 from Victor Grousset/tuxayo  ---
I don't think there is a dependency from bug 28803 (and it's dep bug 28813)
**for the bug occurrence**.
20.11.x should be affected since bug 22343 is there

28803 gets in the way to seamlessly backport the fix.

To reword the results of my testing, here are the possibilities
1. backport this bug 29330 directly even if it conflicts due to the lack of
28803. It adds a catch without changing the code in the try and this patch
(29330) adds code in the try.

2. try to backport 28803 without it's dependency 28813 (it might not be
actually a dependency our case)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #57 from Fridolin Somers  ---
(In reply to Victor Grousset/tuxayo from comment #51)
> 
> For 20.11.x it might be trickier. Bug 28803 depends on bug 28813 which
> depends on 14723 which might not be an easy 20.11.x backport. So
> circumventing bug 28803 might be the way.

So we can skip for 20.11.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Kyle M Hall  changed:

   What|Removed |Added

 Version(s)|21.11.00|21.11.00,21.05.05
released in||

--- Comment #56 from Kyle M Hall  ---
Pushed to 21.05.x for 21.05.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #55 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #54)
> (clarified in chat, no change in the backport plan)

Well... I'd say that I still don't really understand and that I'll just wait to
see what Kyle comes up with.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #54 from Victor Grousset/tuxayo  ---
(clarified in chat, no change in the backport plan)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #53 from David Cook  ---
(In reply to Victor Grousset/tuxayo from comment #52)
> errata:
> 
> > and is not able to apply on 21.05.x
> 
> and is *now* able to be applied on 21.05.x

Could you clarify this one a bit more? I'd like to apply these patches to
21.05. What did you need to do that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #52 from Victor Grousset/tuxayo  ---
errata:

> and is not able to apply on 21.05.x

and is *now* able to be applied on 21.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #51 from Victor Grousset/tuxayo  ---
Nonetheless with bug 28803[1] applied, only minor conflicts remain. Other than
some attention the module use conflict, the patch can be applied.


[1] which is major and is not able to apply on 21.05.x so will likely be
backported so no need to circumvent it's absence.


For 20.11.x it might be trickier. Bug 28803 depends on bug 28813 which depends
on 14723 which might not be an easy 20.11.x backport. So circumventing bug
28803 might be the way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Depends on|28803   |

--- Comment #50 from Victor Grousset/tuxayo  ---
No actual dependency it seems. bug 28803 adds a catch and this patch adds code
in the try.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803
[Bug 28803] process_message_queue.pl dies if any messsages in the message queue
contain an invalid to_address
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Depends on||28803

--- Comment #49 from Victor Grousset/tuxayo  ---
conflict is due to bug 28803


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803
[Bug 28803] process_message_queue.pl dies if any messsages in the message queue
contain an invalid to_address
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #48 from Katrin Fischer  ---
It is needed... but I can't provide the reabase. :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #47 from Kyle M Hall  ---
If this is needed to for 21.05.x please rebase and notify me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29501

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #46 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||21.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

--- Comment #45 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #44)
> Hmm. Still having an issue?

False alarm. Back to green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #44 from Marcel de Rooy  ---
Hmm. Still having an issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #43 from Marcel de Rooy  ---
Good job, Tomas. Looks good to me. Tested with multiple attachments including
some weird UTF8 stuff.
Note that we do not have tests (yet) for adding attachments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #42 from Marcel de Rooy  ---
Created attachment 127573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127573=edit
Bug 29330: (QA follow-up) Change to message/rfc822

This content-type might be more appropriated to use as a temporary
label for the serialized email message with attachments.

WARNING: perl -cw tells you that the constant is redefined. This has
to do with an already existing module dependency loop of Letters.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #127444|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 127572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127572=edit
Bug 29330: (QA follow-up) Use passed MIME type

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 
Amended: tidied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #127430|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Created attachment 127571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127571=edit
Bug 29330: Restore handling of serialized MIME messages in message_queue

This patch changes how multipart MIME messages are handled on the
message_queue table.

The email, with the required attachments, is now generated using
Koha::Email, and serialized using Koha::Email->as_string.

This bug also adds Koha::Email->new_from_string which is used to read
that data from the DB, and produce a Koha::Email object, that can be
further augmented/modified using regular Koha::Email methods.

This implementation should be considered a middle ground, with
backportability in mind. higher-level methods should encapsulate setting
the default headers and addresses, to clean the area a bit further.

Preparation:
- You need a valid SMTP configuration in koha-conf.xml. If you use Gmail
  you can generate an 'app password' and set things like this:

 
smtp.gmail.com
587
5
STARTTLS
youraddr...@gmail.com
youpassword
1
 
- Set KohaAdminAddress to your address.

To test:
1. Pick a patron. Make sure it doesn't have any email address (Acevedo?)
2. Set an overdue notice trigger for its category
3. Check something out, with due date in the past to force an overdue
4. Run:
   $ kshell
  k$ misc/cronjobs/overdue_notices.pl -v
  k$ exit
   $ koha-mysql kohadev
   > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber;
=> SUCCESS: A notice has been created
5. Run:
   $ kshell
  k$ misc/cronjobs/process_message_queue.pl --verbose
=> SUCCESS: SMTP is ok => Email is sent
=> FAIL: Your inbox shows an email with weird content
6. Apply this patches
7. Run:
   $ koha-mysql kohadev
   > DELETE FROM message_queue;
8. Repeat 4 and 5
=> SUCCESS: You got an email with an attachment!
=> SUCCESS: The attachment contains an email that couldn't be delivered!
9. Try all the things that enqueue messages :-D
=> SUCCESS: No behavior change
10. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 
Edited the POD, restoring a few lines that describe the needed hash
keys of the attachments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #127429|0   |1
is obsolete||

--- Comment #39 from Marcel de Rooy  ---
Created attachment 127570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127570=edit
Bug 29330: Add Koha::Email->new_from_string

This patch introduces a new method to Koha::Email. This method allows us
to parse a MIME email to initialize the Koha::Email object. This is
particularly important when we are restoring emails from the DB. i.e.
from the *message_queue* table.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> SUCCESS: Tests pass! Koha::Email->new_from_string is the correct
counterpart for Koha::Email->as_string!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #38 from Marcel de Rooy  ---
w3.org
The Message/rfc822 (primary) subtype: A Content-Type of "message/rfc822"
indicates that the body contains an encapsulated message, with the syntax of an
RFC 822 message.
Better than using MIME as content-type..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Passed QA   |BLOCKED

--- Comment #37 from Marcel de Rooy  ---
Still having a look here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #36 from Katrin Fischer  ---
Actually these first conflicts are not so bad, the one in Letters.pm is the bad
one I am failing to resolve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #35 from Katrin Fischer  ---
I tried to apply on 21.11.11 for testing and there are lots of conflicts right
now - might need work for the maintenance branches:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29330: Add Koha::Email->new_from_string
Using index info to reconstruct a base tree...
M   Koha/Email.pm
M   t/Koha/Email.t
Falling back to patching base and 3-way merge...
Auto-merging t/Koha/Email.t
CONFLICT (content): Merge conflict in t/Koha/Email.t
Auto-merging Koha/Email.pm
CONFLICT (content): Merge conflict in Koha/Email.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29330: Add Koha::Email->new_from_string
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-29330-Add-KohaEmail-newfromstring-R_84LL.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #34 from David Cook  ---
Cool workaround. I had looked at Email::MIME->new(), but wasn't sure how we'd
make it work.

Haven't tried out the code but thanks for working on this, Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #33 from Martin Renvoize  ---
Thanks for the explanation and follow-up.. adding my QA stamp to the final
patch :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127437|0   |1
is obsolete||

--- Comment #32 from Martin Renvoize  ---
Created attachment 127444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127444=edit
Bug 29330: (QA follow-up) Use passed MIME type

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 127437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127437=edit
Bug 29330: (QA follow-up) Use passed MIME type

Signed-off-by: Tomas Cohen Arazi 

https://bugs.koha-community.org/show_bug.cgi?id=29303

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #30 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #29)
> The only bit that raised slight alarm bells.. but that's only because my
> email understanding isn't at 'expert god level' is the internal content type
> of the attachments being hardcoded to `application/octet-stream`.. in all my
> testing I couldn't find a problem with that.. but I don't understand it
> either so would love a comment from Tomas explaining?

Good catch, Martin. I'll post a follow-up patch for that.
application/octet-stream is the fallback in Email::Stuffer when it cannot make
a better guess on the content. I overlooked it because the email clients I
tested didn't care about that and displayed things correctly. But we should
explicitly pass text/plain.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #29 from Martin Renvoize  ---
Testing yields positive results in all cases I tried.. QA scripts is happy.

That's some somewhat fnky looking code here, but I understand it's in aide of
backports.. we can clean up during the next cycle I think.

The only bit that raised slight alarm bells.. but that's only because my email
understanding isn't at 'expert god level' is the internal content type of the
attachments being hardcoded to `application/octet-stream`.. in all my testing I
couldn't find a problem with that.. but I don't understand it either so would
love a comment from Tomas explaining?

Passing QA anyway as this does indeed fix the issues as described and doesn't
raise and real red flags.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127419|0   |1
is obsolete||

--- Comment #28 from Martin Renvoize  ---
Created attachment 127430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127430=edit
Bug 29330: Restore handling of serialized MIME messages in message_queue

This patch changes how multipart MIME messages are handled on the
message_queue table.

The email, with the required attachments, is now generated using
Koha::Email, and serialized using Koha::Email->as_string.

This bug also adds Koha::Email->new_from_string which is used to read
that data from the DB, and produce a Koha::Email object, that can be
further augmented/modified using regular Koha::Email methods.

This implementation should be considered a middle ground, with
backportability in mind. higher-level methods should encapsulate setting
the default headers and addresses, to clean the area a bit further.

Preparation:
- You need a valid SMTP configuration in koha-conf.xml. If you use Gmail
  you can generate an 'app password' and set things like this:

 
smtp.gmail.com
587
5
STARTTLS
youraddr...@gmail.com
youpassword
1
 
- Set KohaAdminAddress to your address.

To test:
1. Pick a patron. Make sure it doesn't have any email address (Acevedo?)
2. Set an overdue notice trigger for its category
3. Check something out, with due date in the past to force an overdue
4. Run:
   $ kshell
  k$ misc/cronjobs/overdue_notices.pl -v
  k$ exit
   $ koha-mysql kohadev
   > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber;
=> SUCCESS: A notice has been created
5. Run:
   $ kshell
  k$ misc/cronjobs/process_message_queue.pl --verbose
=> SUCCESS: SMTP is ok => Email is sent
=> FAIL: Your inbox shows an email with weird content
6. Apply this patches
7. Run:
   $ koha-mysql kohadev
   > DELETE FROM message_queue;
8. Repeat 4 and 5
=> SUCCESS: You got an email with an attachment!
=> SUCCESS: The attachment contains an email that couldn't be delivered!
9. Try all the things that enqueue messages :-D
=> SUCCESS: No behavior change
10. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #127418|0   |1
is obsolete||

--- Comment #27 from Martin Renvoize  ---
Created attachment 127429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127429=edit
Bug 29330: Add Koha::Email->new_from_string

This patch introduces a new method to Koha::Email. This method allows us
to parse a MIME email to initialize the Koha::Email object. This is
particularly important when we are restoring emails from the DB. i.e.
from the *message_queue* table.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> SUCCESS: Tests pass! Koha::Email->new_from_string is the correct
counterpart for Koha::Email->as_string!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #26 from Victor Grousset/tuxayo  ---
Thanks David, you were faster ^^

As for QA all I can help about is say is that the QA script is happy :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #127414|0   |1
is obsolete||

--- Comment #25 from Victor Grousset/tuxayo  ---
Created attachment 127419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127419=edit
Bug 29330: Restore handling of serialized MIME messages in message_queue

This patch changes how multipart MIME messages are handled on the
message_queue table.

The email, with the required attachments, is now generated using
Koha::Email, and serialized using Koha::Email->as_string.

This bug also adds Koha::Email->new_from_string which is used to read
that data from the DB, and produce a Koha::Email object, that can be
further augmented/modified using regular Koha::Email methods.

This implementation should be considered a middle ground, with
backportability in mind. higher-level methods should encapsulate setting
the default headers and addresses, to clean the area a bit further.

Preparation:
- You need a valid SMTP configuration in koha-conf.xml. If you use Gmail
  you can generate an 'app password' and set things like this:

 
smtp.gmail.com
587
5
STARTTLS
youraddr...@gmail.com
youpassword
1
 
- Set KohaAdminAddress to your address.

To test:
1. Pick a patron. Make sure it doesn't have any email address (Acevedo?)
2. Set an overdue notice trigger for its category
3. Check something out, with due date in the past to force an overdue
4. Run:
   $ kshell
  k$ misc/cronjobs/overdue_notices.pl -v
  k$ exit
   $ koha-mysql kohadev
   > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber;
=> SUCCESS: A notice has been created
5. Run:
   $ kshell
  k$ misc/cronjobs/process_message_queue.pl --verbose
=> SUCCESS: SMTP is ok => Email is sent
=> FAIL: Your inbox shows an email with weird content
6. Apply this patches
7. Run:
   $ koha-mysql kohadev
   > DELETE FROM message_queue;
8. Repeat 4 and 5
=> SUCCESS: You got an email with an attachment!
=> SUCCESS: The attachment contains an email that couldn't be delivered!
9. Try all the things that enqueue messages :-D
=> SUCCESS: No behavior change
10. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 
  «Try all the things that enqueue messages»: I only testes an overdue
  notice email.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #127413|0   |1
is obsolete||

--- Comment #24 from Victor Grousset/tuxayo  ---
Created attachment 127418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127418=edit
Bug 29330: Add Koha::Email->new_from_string

This patch introduces a new method to Koha::Email. This method allows us
to parse a MIME email to initialize the Koha::Email object. This is
particularly important when we are restoring emails from the DB. i.e.
from the *message_queue* table.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> SUCCESS: Tests pass! Koha::Email->new_from_string is the correct
counterpart for Koha::Email->as_string!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 
Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #23 from David Nind  ---
Testing notes (using koha-testing-docker):

- To set notice triggers (step 2): Tools > Overdue notice/status triggers

- Additional test for email (step 9)
  . [NON QUEUED] Sending cart and lists to email address from the OPAC
  . [NON QUEUED] Password recovery (enable OpacResetPassword)
  . Sent overdue message as an HTML message (added paragraph tags and bolded
some text)
  . Sent messages for items checked in and checked out

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

David Nind  changed:

   What|Removed |Added

 Attachment #127405|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 127414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127414=edit
Bug 29330: Restore handling of serialized MIME messages in message_queue

This patch changes how multipart MIME messages are handled on the
message_queue table.

The email, with the required attachments, is now generated using
Koha::Email, and serialized using Koha::Email->as_string.

This bug also adds Koha::Email->new_from_string which is used to read
that data from the DB, and produce a Koha::Email object, that can be
further augmented/modified using regular Koha::Email methods.

This implementation should be considered a middle ground, with
backportability in mind. higher-level methods should encapsulate setting
the default headers and addresses, to clean the area a bit further.

Preparation:
- You need a valid SMTP configuration in koha-conf.xml. If you use Gmail
  you can generate an 'app password' and set things like this:

 
smtp.gmail.com
587
5
STARTTLS
youraddr...@gmail.com
youpassword
1
 
- Set KohaAdminAddress to your address.

To test:
1. Pick a patron. Make sure it doesn't have any email address (Acevedo?)
2. Set an overdue notice trigger for its category
3. Check something out, with due date in the past to force an overdue
4. Run:
   $ kshell
  k$ misc/cronjobs/overdue_notices.pl -v
  k$ exit
   $ koha-mysql kohadev
   > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber;
=> SUCCESS: A notice has been created
5. Run:
   $ kshell
  k$ misc/cronjobs/process_message_queue.pl --verbose
=> SUCCESS: SMTP is ok => Email is sent
=> FAIL: Your inbox shows an email with weird content
6. Apply this patches
7. Run:
   $ koha-mysql kohadev
   > DELETE FROM message_queue;
8. Repeat 4 and 5
=> SUCCESS: You got an email with an attachment!
=> SUCCESS: The attachment contains an email that couldn't be delivered!
9. Try all the things that enqueue messages :-D
=> SUCCESS: No behavior change
10. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

David Nind  changed:

   What|Removed |Added

 Attachment #127404|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 127413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127413=edit
Bug 29330: Add Koha::Email->new_from_string

This patch introduces a new method to Koha::Email. This method allows us
to parse a MIME email to initialize the Koha::Email object. This is
particularly important when we are restoring emails from the DB. i.e.
from the *message_queue* table.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> SUCCESS: Tests pass! Koha::Email->new_from_string is the correct
counterpart for Koha::Email->as_string!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #20 from Tomás Cohen Arazi  ---
Ok, here's my attempt. I tried several things, and this is the simplest I could
come up with. Thinking of a backportable patch.

I chose 'MIME' as the content_type because Email::MIME doesn't seem to return
the same thing MIME::Lite returns. and, well.

On bug 29365 we could implement high level methods for setting 'the addresses'
and  'the default headers' and removing the FIXME I introduce.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 127405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127405=edit
Bug 29330: Restore handling of serialized MIME messages in message_queue

This patch changes how multipart MIME messages are handled on the
message_queue table.

The email, with the required attachments, is now generated using
Koha::Email, and serialized using Koha::Email->as_string.

This bug also adds Koha::Email->new_from_string which is used to read
that data from the DB, and produce a Koha::Email object, that can be
further augmented/modified using regular Koha::Email methods.

This implementation should be considered a middle ground, with
backportability in mind. higher-level methods should encapsulate setting
the default headers and addresses, to clean the area a bit further.

Preparation:
- You need a valid SMTP configuration in koha-conf.xml. If you use Gmail
  you can generate an 'app password' and set things like this:

 
smtp.gmail.com
587
5
STARTTLS
youraddr...@gmail.com
youpassword
1
 
- Set KohaAdminAddress to your address.

To test:
1. Pick a patron. Make sure it doesn't have any email address (Acevedo?)
2. Set an overdue notice trigger for its category
3. Check something out, with due date in the past to force an overdue
4. Run:
   $ kshell
  k$ misc/cronjobs/overdue_notices.pl -v
  k$ exit
   $ koha-mysql kohadev
   > SELECT * FROM message_queue WHERE borrowernumber=the_borrowernumber;
=> SUCCESS: A notice has been created
5. Run:
   $ kshell
  k$ misc/cronjobs/process_message_queue.pl --verbose
=> SUCCESS: SMTP is ok => Email is sent
=> FAIL: Your inbox shows an email with weird content
6. Apply this patches
7. Run:
   $ koha-mysql kohadev
   > DELETE FROM message_queue;
8. Repeat 4 and 5
=> SUCCESS: You got an email with an attachment!
=> SUCCESS: The attachment contains an email that couldn't be delivered!
9. Try all the things that enqueue messages :-D
=> SUCCESS: No behavior change
10. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 127404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127404=edit
Bug 29330: Add Koha::Email->new_from_string

This patch introduces a new method to Koha::Email. This method allows us
to parse a MIME email to initialize the Koha::Email object. This is
particularly important when we are restoring emails from the DB. i.e.
from the *message_queue* table.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/Email.t
=> SUCCESS: Tests pass! Koha::Email->new_from_string is the correct
counterpart for Koha::Email->as_string!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #17 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #16)
> (In reply to Katrin Fischer from comment #14)
> > Maybe a solution could then be to change the email to be send directly then
> > instead of via the message queue?
> 
> I always thought we were aiming to sent all the notices from the DB table.

I agree. Please note that this overdues case is really an edge case. We should
resolve sending attachments in 22.05?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #16 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #14)
> Maybe a solution could then be to change the email to be send directly then
> instead of via the message queue?

I always thought we were aiming to sent all the notices from the DB table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #15 from David Cook  ---
(In reply to Katrin Fischer from comment #14)
> Maybe a solution could then be to change the email to be send directly then
> instead of via the message queue?
> 
You're probably right about that being the best way, although it is nice to
have an entry in the message queue for reviewing/logging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #14 from Katrin Fischer  ---
Maybe a solution could then be to change the email to be send directly then
instead of via the message queue?

The overdue_notices.pl script creates an email with attached overdue messages
to be sent to the library when a user should receive an overdue notice, but has
no email address.

How I would test:

* You'll need a patron without email address with overdues.
* Notice triggers where one or more of the delays match the overdue item.
* Run the overdue_notices.pl with -t (use triggers)
* You don't need to set up fines.

I believe the code is all in the (very long) overdue_notices.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Christian Stelzenmüller  changed:

   What|Removed |Added

 CC||christian.stelzenmueller@bs
   ||z-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

--- Comment #13 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #7)
> Sorry, now I am confused. Can you describe what features are affected by the
> problem and thus broken?

Sending attachments works, the cart, the list, etc. It all was tested, and
works.
And Email::Stuffer can handle attachments correctly.

The problem is messages that go to the message queue, with attachments, and how
the email is rebuilt to be sent.

Can anyone provide 'steps to reproduce' the problem? thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #12 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #10)
> (In reply to Marcel de Rooy from comment #9)
> > Will give it a try now
> 
> Yes, it looks like David was right. This might not be a minimal fix. The
> add_attachments stuff in C4::Letters does not seem to work well with
> Email::Stuffer. Imo we should go back to Email::MIME in Koha::Email.
> 
> More comments on bug 29365

Koha::Email used to be just a wrapper for a hashref used to build something
suitable for passing to Mail::Sendmail. We didn't use Email::MIME. Multi-part
emails with attachments were built by concatenating manually crafted strings...

That said, there's room for improvement. Using Email::MIME is hard, and error
prone. That's why the author (of both libraries, and Email::Simple,
Email::Sender, etc) suggests using Email::Stuffer.

I don't think it is urgent to replace Email::Stuffer because its API has design
issues. In fact, if required we can add MIME content manually.

I hadn't payed attention to this bugs and will now. If the problem is how
emails are serialized on the db, maybe we can use Koha::Email->to_string
(inherited from Email::Stuffer). But as I said, I've just discovered this bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||29365


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29365
[Bug 29365] Koha::Email needs to be refactored
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #11 from Marcel de Rooy  ---
The good thing is that we hardly use add_attachments only for overdue messages
collected for patrons without email address or so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|m.de.r...@rijksmuseum.nl|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

--- Comment #10 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #9)
> Will give it a try now

Yes, it looks like David was right. This might not be a minimal fix. The
add_attachments stuff in C4::Letters does not seem to work well with
Email::Stuffer. Imo we should go back to Email::MIME in Koha::Email.

More comments on bug 29365

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|NEW |ASSIGNED

--- Comment #9 from Marcel de Rooy  ---
Will give it a try now

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #8 from Marcel de Rooy  ---
Looking at Koha::Email too on bug 28729.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

--- Comment #7 from Katrin Fischer  ---
Sorry, now I am confused. Can you describe what features are affected by the
problem and thus broken?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table

2021-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330

David Cook  changed:

   What|Removed |Added

Summary|Koha cannot send emails |Koha cannot send emails
   |with attachments|with attachments using
   ||Koha::Email and
   ||message_queue table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/