[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added CC||co...@lugmen.org.ar --- Comment #35 from Marcel de Rooy --- *** Bug 6175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #34 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.11 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #33 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.03 released in|| CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable --- Comment #32 from Kyle M Hall --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #31 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #30 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #22) > (In reply to Jonathan Druart from comment #21) > > > This one should be pushed along with bug 29390 in my opinion. > > It can go on its own. I agree, so pushing master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind changed: What|Removed |Added Text to go in the||This fixes the length of release notes||the field definitions in ||the database for several ||authorised_value and ||authorised_value_category ||columns as they are too ||short. It changes the value ||to varchar(32). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #29 from Jonathan Druart --- Created attachment 129189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129189=edit Bug 29336: Remove TODOs Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What|Removed |Added Attachment #128656|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 129188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129188=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What|Removed |Added Attachment #128655|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 129187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129187=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #26 from Jonathan Druart --- All good for me, however I would remove the comments you added in the kohastructure.sql. We usually don't adjust the comment in the atomic update, so people we still hve the TODO even if we fix the name of the column. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #25 from David Nind --- Testing notes (koha-testing-docker): - Access the database and use describe ; to show current definitions - See the database update for the table names - Run the tests - should pass - Apply the patch - Run databaseupdate - Access the database again and see that the definitions are updated - reset_all - Access the database again and see that the definitions are updated - Run the tests again - should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind changed: What|Removed |Added Attachment #127170|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 128656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128656=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind changed: What|Removed |Added Attachment #127169|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 128655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128655=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #22 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #21) > This one should be pushed along with bug 29390 in my opinion. It can go on its own. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #21 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #20) > (In reply to Jonathan Druart from comment #19) > > (In reply to Marcel de Rooy from comment #18) > > > Still nice to have in 21.11 ? > > > > I would prefer to not rush it and wait for 22.05 > > Could you please tell me what is the fundamental difference with the patches > on bug 29386, that got pushed today ? Bug 29386 fixes a critical bug that must be backported into stable branches ASAP. This one should be pushed along with bug 29390 in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #20 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > (In reply to Marcel de Rooy from comment #18) > > Still nice to have in 21.11 ? > > I would prefer to not rush it and wait for 22.05 Could you please tell me what is the fundamental difference with the patches on bug 29386, that got pushed today ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #18) > Still nice to have in 21.11 ? I would prefer to not rush it and wait for 22.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #18 from Marcel de Rooy --- Still nice to have in 21.11 ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Attachment #127172|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Attachment #127171|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Blocks|5334| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Blocks||29390 --- Comment #17 from Marcel de Rooy --- I am spending too much time right now on this. I have stumbled over several things, might be too long constraint names, etc. Now in the installer the order of the tables must be rearranged in kohastructure to get FKs in. Will move the FK stuff to another report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29390 [Bug 29390] Authorised values: Why not adding the FK on the way? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #16 from Marcel de Rooy --- Wait! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #15 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #10) > (In reply to Jonathan Druart from comment #9) > > Why not adding the FK on the way? > > Missed the missing ones :) Focused on length > Will do Bit more work than anticipated. But there we go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #14 from Marcel de Rooy --- Created attachment 127172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127172=edit Bug 29336: Add a few missing FK constraints to authorised values Test plan: Run dbrev or new install. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #13 from Marcel de Rooy --- Created attachment 127171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127171=edit Bug 29336: Allow to check on FK existence with field name Sometimes easier (or even safer) to check for FK on specific field name rather than constraint name (which may be created automatically). Test plan: Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Attachment #127053|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 127170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127170=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Attachment #127051|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 127169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127169=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Jonathan Druart changed: What|Removed |Added Blocks||5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #10 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #9) > Why not adding the FK on the way? Missed the missing ones :) Focused on length Will do -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #9 from Jonathan Druart --- Why not adding the FK on the way? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Attachment #127052|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 127053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127053=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #7 from Marcel de Rooy --- Oops submitting 2nd again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Marcel de Rooy --- Jonathan, wanna take this along with 21.11. Normal or major? At least an untidy inconsistency.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #5 from Marcel de Rooy --- Created attachment 127052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127052=edit Bug 29336: Database revision Resizes the six fields identified earlier: additional_fields.authorised_value_category 16=>32 auth_subfield_structure.authorised_value 10=>32 auth_tag_structure.authorised_value 10=>32 club_template_enrollment_fields.authorised_value_category 16=>32 club_template_fields.authorised_value_category 16=>32 marc_tag_structure.authorised_value 10=>32 Test plan: Run dbrev, check database. Bonus: Connect an AV category with a long name to a authority subfield. Check if you see its values in the authority editor. (This was the way I found the problem.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #4 from Marcel de Rooy --- Created attachment 127051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127051=edit Bug 29336: Identify the fields with wrong length (or name) first This report will fix the bad lengths first. And mark the 'bad' names with a TODO for follow-up. Bad name means: refers to value, should be category. Scanning kohastructure.sql. Note: Bug 29347 has been opened to fix the names. Test plan: Search for another AV category field with length<>32. Bonus: Reinstall and check database. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #3 from Marcel de Rooy --- Bug 29347 is for renaming columns. Cool enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Summary|Some authorised_value FKs |Some authorised_value FKs |are too short and badly |are too short |named | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short and badly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Blocks||29347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29347 [Bug 29347] Rename authorised_value fields that are actually categories -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short and badly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #2 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #1) > Hmm. The categories are a different .. category. Actually not. There is a confusing difference betweeen value and category here. In most cases we mean the category but named the field value. Too bad. This report will only fix the lengths now first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short and badly named
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Marcel de Rooy changed: What|Removed |Added Summary|Some authorised_value FK|Some authorised_value FKs |fields are too short|are too short and badly ||named -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
