[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #25 from wainuiwitikap...@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added Blocks||31064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31064 [Bug 31064] Local login is difficult to style using CSS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #24 from Fridolin Somers --- > Bug 29458: Fix selenium test Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #23 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > Change status to ? No need to, there is the additional_work_needed keyword. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #22 from Marcel de Rooy --- Change status to ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #21 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #19) > Created attachment 130016 [details] [review] > Bug 29458: Fix selenium test > > The authentication.t selenium tests (and a couple of others) were > failing with: > Error while executing command: element not interactable: Element class="btn btn-primary" type="submit"> could not be scrolled into view at > /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at > /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. > > We changed the other of the form, and t::lib::Selenium::submit_form was > not getting the correct (first) form. The one from the auth modal was > retrieved and submit button was clicked. Selenium raised an error as it > is not displayed. > The ->is_displayed selenium method does not work, as per the doc > """ > Note: This does *not* tell you an element's 'visibility' property; as it > still takes up space in the DOM and is therefore considered 'displayed'. > """ > https://metacpan.org/pod/Selenium::Remote::WebElement#is_displayed > > "The internet" is saying we should be able to use the following in our > xpath expression: not(ancestor::div[contains(@style,'display:none')] > but it actually only works if the display:none rule is defined on the > node (not from .css). Which does not work for us. > > The only solution I found is to check for the size of the element, which > is (0,0) if not effectively displayed. Thanks. Too bad that we need such workarounds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #20 from Jonathan Druart --- I am getting another selenium failure locally, with and without the patch. Not sure it's related to this, Jenkins has it passing. # at t/db_dependent/selenium/update_child_to_adult.t line 148. Cannot wait more for element '//input[@type="submit"]' to be visible at /kohadevbox/koha/t/lib/Selenium.pm line 189. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #19 from Jonathan Druart --- Created attachment 130016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130016=edit Bug 29458: Fix selenium test The authentication.t selenium tests (and a couple of others) were failing with: Error while executing command: element not interactable: Element could not be scrolled into view at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. We changed the other of the form, and t::lib::Selenium::submit_form was not getting the correct (first) form. The one from the auth modal was retrieved and submit button was clicked. Selenium raised an error as it is not displayed. The ->is_displayed selenium method does not work, as per the doc """ Note: This does *not* tell you an element's 'visibility' property; as it still takes up space in the DOM and is therefore considered 'displayed'. """ https://metacpan.org/pod/Selenium::Remote::WebElement#is_displayed "The internet" is saying we should be able to use the following in our xpath expression: not(ancestor::div[contains(@style,'display:none')] but it actually only works if the display:none rule is defined on the node (not from .css). Which does not work for us. The only solution I found is to check for the size of the element, which is (0,0) if not effectively displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #18 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #17) > (In reply to Jonathan Druart from comment #16) > > Selenium authentication tests are failing because of this change: > > Error while executing command: element not interactable: Element > class="btn btn-primary" type="submit"> could not be scrolled into view at > > /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. > > at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. > > Which test specifically ? I have spent some time on setting up Selenium, and all its prerequisites within a Docker container. But I dont really have time for getting that working now. This sounds like a simple change required, but I cant provide or test it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > Selenium authentication tests are failing because of this change: > Error while executing command: element not interactable: Element class="btn btn-primary" type="submit"> could not be scrolled into view at > /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. > at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. Which test specifically ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --- Comment #16 from Jonathan Druart --- Selenium authentication tests are failing because of this change: Error while executing command: element not interactable: Element could not be scrolled into view at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 411. at /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm line 356. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #15 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What|Removed |Added Attachment #129240|0 |1 is obsolete|| Attachment #129612|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 129617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129617=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers Bug 29458: (follow-up) Remove FIXME With some help of Owen Leonard: Regarding the , you can wrap the submit button in instead. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #9) > +[%# FIXME Add right class, > remove br %] > + > > Easy fixme, should be implemented here. Fixed now with help from Owen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added Attachment #129606|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 129612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129612=edit Bug 29458: (follow-up) Remove FIXME With some help of Owen Leonard: Regarding the , you can wrap the submit button in instead. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #11 from Marcel de Rooy --- Owen, could you have a look at the second patch? Would you suggest to add a class and additional css or so instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #10 from Marcel de Rooy --- Created attachment 129606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129606=edit Bug 29458: (follow-up) Remove FIXME Actually, just leaving the br tag is fine too. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- +[%# FIXME Add right class, remove br %] + Easy fixme, should be implemented here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #8 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #6) > Please rebase. It like it but doesn't apply. Easy fix :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added Attachment #127828|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 129240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129240=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||tomasco...@gmail.com QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | --- Comment #6 from Tomás Cohen Arazi --- Please rebase. It like it but doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #5 from Fridolin Somers --- I opened Bug 29730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #4 from Marcel de Rooy --- (In reply to Fridolin Somers from comment #3) > Looks way better :D > > In opac-auth, with should also fix : > You may register here. > instead of > Don't have an account? Register here. > > Maybe in another bug. Please open another bug. Can we get this one further please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #3 from Fridolin Somers --- Looks way better :D In opac-auth, with should also fix : You may register here. instead of Don't have an account? Register here. Maybe in another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added Attachment #127539|0 |1 is obsolete|| --- Comment #2 from Fridolin Somers --- Created attachment 127828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127828=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 --- Comment #1 from Marcel de Rooy --- Created attachment 127539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127539=edit Bug 29458: Reorder login elements Make masthead.inc modal and opac-auth follow the order of the login elements on the homepage. Test plan: Enable prefs for reset password and self registration. Fill additional contents for login instructions. Logout on OPAC. Click Login from your account on top bar. Click Login button on the home page (right side, in the middle). Verify that these two forms correspond with the home page login. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29458] Show login button consistently in relation to login instructions, reset and register links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29458 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
