[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #14 from Martin Renvoize  ---
Pretty sure with is fixed now.. bug 10876 perhaps..

Either way, I can't replicate the bug so I think we're safe to close :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66216|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 66284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66284=edit
Bug 2946: Added some missing logic

The norequests logic affects the opac-details-sidebar.inc logic
which is shared in ISBD and MARC views. It is correct in ISBD
and this brings it into MARC detailed view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

--- Comment #12 from M. Tompsett  ---
Created attachment 66216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66216=edit
Bug 2946: Added some missing logic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66211|0   |1
is obsolete||
  Attachment #66214|0   |1
is obsolete||

--- Comment #11 from M. Tompsett  ---
Created attachment 66215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66215=edit
Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in
OPAC

Hides the Holdings that are "Lost" and the entire Holdings table if all items
are lost, when the hidelostitems syspref is "Don't Show".
Should work in plain text view as well.
For the OPAC MARC view of a biblio details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66213|0   |1
is obsolete||

--- Comment #10 from M. Tompsett  ---
Created attachment 66214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66214=edit
Bug 2946: Added some missing logic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

  Attachment #66212|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 66213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66213=edit
Bug 2946: Added some missing logic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

  Attachment #25963|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 66211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66211=edit
Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in
OPAC

Hides the Holdings that are "Lost" and the entire Holdings table if all items
are lost, when the hidelostitems syspref is "Don't Show".
Should work in plain text view as well.
For the OPAC MARC view of a biblio details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

--- Comment #8 from M. Tompsett  ---
Created attachment 66212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66212=edit
Bug 2946: Added some missing logic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

--- Comment #6 from M. Tompsett  ---
(In reply to Marc Véron from comment #5)
> Still valid?

While working on Bug 14385, I think I saw code that was not copied between
various opac/opac-###detail.pl files. I think this may still be valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10589
 CC||ve...@veron.ch

--- Comment #5 from Marc Véron  ---
Still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
Though bug 10589 and 10895 are in need of a serious re-write, I wonder if they
would solve this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

cedric.v...@dracenie.com changed:

   What|Removed |Added

 CC||cedric.v...@dracenie.com

--- Comment #2 from cedric.v...@dracenie.com ---
The patch applies. Test plan, the points 1 to 5 are OK but 6 still does not
work. (messag: Sorry, plain view is temporarily unavailable.)
(Test sandbox)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
In my test I get no listing of holdings at all on opac-MARCdetail.pl after
applying the patch even though there are some items which should not be hidden. 

Also, is there a reason to leave in this commented-out line?

#warn subf:$i $sf_def-{kohafield} $sf_def-{lib} $subf[$i][0]; # see errlog
to learn the mappings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||matted-34...@mypacks.net
   Assignee|gmcha...@gmail.com  |matted-34...@mypacks.net

--- Comment #1 from wajasu matted-34...@mypacks.net ---
Created attachment 25963
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25963action=edit
Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in
OPAC

Coded this old bug against master.

Test Plan:
0) set hidelostitems syspref to Dont show
1) find/build a biblio with items.
2) from detail page select MARC view and scroll to bottom to see Holdings.
3) go edit the item as lost.
4) from detail page select MARC view and scroll to bottom to see Holdings.
   (lost item should be gone. And if no other items, no holdings table shown.
5) toggle hidelost items syspref and view again to see lost items
appear/disappear
6) you can click plain text view to see that as well

Hope you don't mind my changing bug to version: master, since its been so long,
and its still an issue in pre 3.14 days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

Version|rel_3_0 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/