[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs documenting |RESOLVED Documentation||Martin Renvoize contact|| Resolution|--- |FIXED --- Comment #14 from Martin Renvoize --- Architectural change, no workflow differences. No documentation changes required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||vic...@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Version(s)|22.05.00|22.05.00,21.11.06 released in|| Status|Pushed to master|Pushed to stable --- Comment #12 from Kyle M Hall --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 --- Comment #11 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30167 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #10 from Fridolin Somers --- Circulation.t is OK for me with and without this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Marcel de Rooy changed: What|Removed |Added Severity|trivial |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 --- Comment #9 from Marcel de Rooy --- Subtest: GetSoonestRenewDate tests passes, altough currently the whole Circulation.t fails (also without this patch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Marcel de Rooy changed: What|Removed |Added Attachment #133505|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 134348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134348=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | Assignee|joonas.kylm...@iki.fi |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Nind changed: What|Removed |Added Attachment #132129|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 133505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133505=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Nick Clemens changed: What|Removed |Added Attachment #128095|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 132129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132129=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Bug 29537 depends on bug 29476, which changed state. Bug 29476 Summary: Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 What|Removed |Added Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Bug 29537 depends on bug 29474, which changed state. Bug 29474 Summary: Automatic renewals cronjob is slow on systems with large numbers of reserves https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Status|Signed Off |Patch doesn't apply --- Comment #4 from Jonathan Druart --- No longer apply correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Jonathan Druart changed: What|Removed |Added Blocks||29623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 [Bug 29623] Cache circulation rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Nind changed: What|Removed |Added Attachment #127902|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 128095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128095=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |joonas.kylm...@iki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What|Removed |Added Attachment #127901|0 |1 is obsolete|| --- Comment #2 from Joonas Kylmälä --- Created attachment 127902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127902=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What|Removed |Added Depends on||29476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 [Bug 29476] Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 --- Comment #1 from Joonas Kylmälä --- Created attachment 127901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127901=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29537 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 Joonas Kylmälä changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
