[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-08-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #13 from Katrin Fischer  ---
Not sure, should we work on this together with bug 30250 or abandon this one in
favor of the other bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #12 from Marcel de Rooy  ---
(In reply to Aleisha Amohia from comment #10)
> I could add a follow-up to my patch on Bug 30250 to also consider the
> instance of importing a record, whether we should apply framework defaults
> or not.

Okay. Please do so. I will move this report to BLOCKED for the time being.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #11 from Nick Clemens  ---
(In reply to Aleisha Amohia from comment #10)
> Noting that I've written a patch for Bug 30250, also a follow-up of Bug
> 29146, which adds a system preference ApplyFrameworkDefaults to configure
> when to apply framework defaults - when cataloguing a new record, when
> editing a record as new (duplicating), or when changing the framework while
> editing an existing record. 
> 
> I could add a follow-up to my patch on Bug 30250 to also consider the
> instance of importing a record, whether we should apply framework defaults
> or not.
> 
> I don't think we should hardcode a decision like that as libraries will have
> different ways of cataloguing.

This sounds like the best option - allow users to configure, always difficult
when we change behavior that is "wrong"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #10 from Aleisha Amohia  ---
Noting that I've written a patch for Bug 30250, also a follow-up of Bug 29146,
which adds a system preference ApplyFrameworkDefaults to configure when to
apply framework defaults - when cataloguing a new record, when editing a record
as new (duplicating), or when changing the framework while editing an existing
record. 

I could add a follow-up to my patch on Bug 30250 to also consider the instance
of importing a record, whether we should apply framework defaults or not.

I don't think we should hardcode a decision like that as libraries will have
different ways of cataloguing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-03-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #9 from Jonathan Druart  ---
Seems correct to me but it would be great to have Nick's opinion on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #8 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #6)
> Signed-off-by: Katrin Fischer 

Great. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #128083|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 131150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131150=edit
Bug 29592: Counterpart for authorities

Similar adjustment. Check the breedingid again.

Test plan:
Same as former patch for authorities editor.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #128082|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 131149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131149=edit
Bug 29592: Do not apply defaultvalue to imported record

The condition breedingid excludes records from Z3950.

Test plan:
Import to new or existing record. Verify that defaults are not
applied.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2022-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Katrin Fischer  changed:

   What|Removed |Added

   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Martin Renvoize  changed:

   What|Removed |Added

 CC||lucy.vaux-harvey@ptfs-europ
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #5 from Martin Renvoize  ---
Sorry, been a busy time as usual.

I think you are right that it's a bit confusing/inconsistent at the moment but
as I'm not all that close to cataloguing personally I need to ask colleagues
for an opinion to really know what would be best.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #4 from Marcel de Rooy  ---
Well, any feedback is surely welcome. We could argue that this approach is the
most logical one: We want to see the external record, not our defaults for a
new record. And if needed, we could change external records via the XSLT step
on the Z3950 target.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

--- Comment #3 from Marcel de Rooy  ---
Martin, Nick: What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #2 from Marcel de Rooy  ---
Created attachment 128083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128083=edit
Bug 29592: Counterpart for authorities

Similar adjustment. Check the breedingid again.

Test plan:
Same as former patch for authorities editor.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

--- Comment #1 from Marcel de Rooy  ---
Created attachment 128082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128082=edit
Bug 29592: Do not apply defaultvalue to imported record

The condition breedingid excludes records from Z3950.

Test plan:
Import to new or existing record. Verify that defaults are not
applied.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues

2021-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||29146


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29146
[Bug 29146] Default values from the framework should only be applied at
biblio/item creation
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/