[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks||33791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33791 [Bug 33791] $hold->fill does not set itemnumber when checking out without confirming hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #31 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #30 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #29) > I'm with Tomas here, whilst it would be nice to move _FixPriority, I think > it's well tested and we should focus on modernising and moving the functions > that use it first.. and then move/modernise that last as it's own step. > > It's a big block of code and I feel that perhaps some of it can/should be > updated to be a trigger on the Koha::Hold->store method eventually.. but I > think splitting it like that at this point prior to the rest of our methods > moving is actually more of a risk. > > Lets march forward and keep the momentum going on this. I'm already looking at _FixPriorities. It looks like it does too much (cancelling a hold?) and can be simplified a lot. My perception on writing Koha::Hold->fill, is that we will eventually remove things from controllers and, for example, we could end-up passing the Koha::Item to this new method. I'm pondering (for bug 29891): - Koha::Biblio->fix_holds_priorities, that would call $self->holds->unfilled->fix_priorities - Koha::Holds->fix_priorities (that acts on the resultset) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #29 from Martin Renvoize --- I'm with Tomas here, whilst it would be nice to move _FixPriority, I think it's well tested and we should focus on modernising and moving the functions that use it first.. and then move/modernise that last as it's own step. It's a big block of code and I feel that perhaps some of it can/should be updated to be a trigger on the Koha::Hold->store method eventually.. but I think splitting it like that at this point prior to the rest of our methods moving is actually more of a risk. Lets march forward and keep the momentum going on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29891 [Bug 29891] Add Koha::Holds->fix_priorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869
--- Comment #28 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #27)
> > C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber });
>
>
> Calling a C4 method from Koha is bad. Calling a private method from outside
> the module is very bad. Calling a private C4 method from Koha is very very
> bad...
I copied what was done in ->cancel. Moving _FixPriority to Koha::* is a good
thing to do.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869
--- Comment #27 from Jonathan Druart ---
> C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber });
Calling a C4 method from Koha is bad. Calling a private method from outside the
module is very bad. Calling a private C4 method from Koha is very very bad...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #26 from Kyle M Hall --- Created attachment 129507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129507=edit Bug 29869: (QA follow-up) import t::lib::Mocks for Hold.t for mock_preference Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #25 from Kyle M Hall --- Created attachment 129506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129506=edit Bug 29869: Teach log viewer about FILL Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #24 from Kyle M Hall --- Created attachment 129505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129505=edit Bug 29869: Remove C4::Reserves::ModReserveFill Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #23 from Kyle M Hall --- Created attachment 129504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129504=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #22 from Kyle M Hall --- Created attachment 129503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129503=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added Attachment #129417|0 |1 is obsolete|| Attachment #129418|0 |1 is obsolete|| Attachment #129419|0 |1 is obsolete|| Attachment #129420|0 |1 is obsolete|| Attachment #129421|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 129502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129502=edit Bug 29869: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #20 from Tomás Cohen Arazi --- It applies cleanly on latest master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks|29525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #19 from Martin Renvoize --- Great to see unit tests, I like the method you've used, adding tests, replacing the internals of the original method, then finally removing the original method.. it meant I could run tests at each point before applying subsequent patches. All works well at every stage.. feeling confident Signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What|Removed |Added Attachment #129409|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 129421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129421=edit Bug 29869: Teach log viewer about FILL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What|Removed |Added Attachment #129408|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 129420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129420=edit Bug 29869: Remove C4::Reserves::ModReserveFill Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What|Removed |Added Attachment #129407|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 129419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129419=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What|Removed |Added Attachment #129406|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 129418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129418=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Martin Renvoize changed: What|Removed |Added Attachment #129405|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 129417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129417=edit Bug 29869: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #7) > All looks solid to me, and I like that you specify the log action more > clearly. > > Unfortunately, the unit tests patch wont apply for me.. sha1 issues. > > Otherwise I'm happy to SO Reordered the whole tree. Sorry for that, and thanks for looking at this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 [Bug 29868] Add Koha::Old::Hold->anonymize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 129409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129409=edit Bug 29869: Teach log viewer about FILL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 129408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129408=edit Bug 29869: Remove C4::Reserves::ModReserveFill -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 129407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129407=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 129406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129406=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 129405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129405=edit Bug 29869: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129398|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129397|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129396|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129395|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Attachment #129400|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #7 from Martin Renvoize --- All looks solid to me, and I like that you specify the log action more clearly. Unfortunately, the unit tests patch wont apply for me.. sha1 issues. Otherwise I'm happy to SO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 129400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129400=edit Bug 29869: Teach log viewer about FILL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added CC||and...@bywatersolutions.com ||, ||jonathan.druart+koha@gmail. ||com, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 129398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129398=edit Bug 29869: Remove C4::Reserves::ModReserveFill -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 129397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129397=edit Bug 29869: Make ModReserveFill a (temporary) wrapper for Koha::Hold->fill Before diving into removing ModReserveFill, I propose this: In order to perform real-life testing of the new Koha::Hold->fill method, this patch makes the ModReserveFill method, just call the new one. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/api/v1/holds.t \ t/db_dependent/Reserves* \ t/db_dependent/Circulation* \ t/db_dependent/SIP/* => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 129396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129396=edit Bug 29869: Add Koha::Hold->fill This patch introduces a new method for marking a hold as filled. The code is the result of tracking the following methods in C4::Reserves: - ModReserveFill - GetReserveFee - ChargeReserveFee To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 129395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129395=edit Bug 29869: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Blocks||29874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29869] Add Koha::Hold->fill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Summary|Add Koha::Hold->fulfill |Add Koha::Hold->fill CC||k...@bywatersolutions.com --- Comment #1 from Tomás Cohen Arazi --- ->fill, I meant ->fill :-D. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
