[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Bug 29874 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Jonathan Druart changed: What|Removed |Added Attachment #129422|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 129601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129601=edit Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- I agree... I can't find any uses of this method. I believe we handle all this inside the relevant Koha:: methods that trigger fulfilment now instead. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Martin Renvoize changed: What|Removed |Added Attachment #129399|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 129422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129422=edit Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 129399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129399=edit Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff CC||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29874] Remove unused method C4::SIP::ILS::Item::fill_reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29874 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29869 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
