[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-02-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Owen Leonard  changed:

   What|Removed |Added

 Blocks|17018   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018
[Bug 17018] Split AdvancedSearchTypes for staff and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

--- Comment #8 from Katrin Fischer  ---
It does work in 20.11: ccode|loc|itemtypes makes the tabs appear in this order
in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Katrin Fischer  ---
I don't think we should remove the ability to have the tabs appear in the order
the library likes. If we can't do this with the multi select, we should not use
it. Could we do something similar like we have for the languages? You can
check/uncheck and order them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #6 from Fridolin Somers  ---
This needs a bit more work.

We see in preference description (searching.pref) :
  Tabs appear in the order listed.

Looks like it is not valid :
Values defined in preference are 'itemtypes,ccode,loc'
I see in system preference page :
Collection
Item type
Shelving location

Is it alphabetical ?

When I select all and save value changes to 'ccode,itemtypes,loc';

Values can not be ordered anymore, we should remove this text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

--- Comment #5 from Fridolin Somers  ---
Created attachment 129964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129964=edit
Bug 29878: (follow-up) Change system preference type to multiple

AdvancedSearchTypes type must be changed from 'Choice' to 'multiple'.
'Choice' was in fact not the correct type.

Also fix options even if they are useless.
Other multiple preferences set them.

Also replaces split /\,/ with /,/
There is no need to escape.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

--- Comment #4 from Fridolin Somers  ---
Created attachment 129963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129963=edit
Bug 29878: (follow-up) Fix opac-topissues.pl

This page is using the preference AdvancedSearchTypes with wrong split
character

Test plan :
1) Enable preference OpacTopissue
2) In OPAC click on 'Most popular'
3) Check you see filters on ccode and/or itemtype when they are in
AdvancedSearchTypes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #129431|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  ---
Created attachment 129603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129603=edit
Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference

This patch updates system preferences so that the AdvancedSearchTypes
preference uses a multiple-select widget. This lets users select one or
more checkboxes in a dropdown rather than requiring that they enter
pipe-delimited text.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System Preferences and search for
  'AdvancedSearchTypes'
- The input should be styled as a multiple-select widget. Test that you
  can select one, more, or all of the options.
- Test that your selections are saved successfully and that the changes
  are reflected on the OPAC and staff interface advanced search pages.

Signed-off-by: Lucas Gass 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Owen Leonard  changed:

   What|Removed |Added

 Blocks||17018


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018
[Bug 17018] Split AdvancedSearchTypes for staff and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Lucas Gass  changed:

   What|Removed |Added

 Attachment #129429|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 129431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129431=edit
Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference

This patch updates system preferences so that the AdvancedSearchTypes
preference uses a multiple-select widget. This lets users select one or
more checkboxes in a dropdown rather than requiring that they enter
pipe-delimited text.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System Preferences and search for
  'AdvancedSearchTypes'
- The input should be styled as a multiple-select widget. Test that you
  can select one, more, or all of the options.
- Test that your selections are saved successfully and that the changes
  are reflected on the OPAC and staff interface advanced search pages.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

--- Comment #1 from Owen Leonard  ---
Created attachment 129429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129429=edit
Bug 29878: Use multiple select widget for AdvancedSearchTypes system preference

This patch updates system preferences so that the AdvancedSearchTypes
preference uses a multiple-select widget. This lets users select one or
more checkboxes in a dropdown rather than requiring that they enter
pipe-delimited text.

To test, apply the patch and run updatedatabase.

- Go to Administration -> System Preferences and search for
  'AdvancedSearchTypes'
- The input should be styled as a multiple-select widget. Test that you
  can select one, more, or all of the options.
- Test that your selections are saved successfully and that the changes
  are reflected on the OPAC and staff interface advanced search pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29878] Use multiple select widget for AdvancedSearchTypes system preference

2022-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29878

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/