[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Jonathan Druart changed: What|Removed |Added Attachment #129969|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 129989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129989=edit Bug 29976: (Bug 21729 followup) fix holds unit tests Bug 21729 added to holds table the column patron_expiration_date. Currently test suite is failing : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/516/testReport/ We must fix where TestBuilder is creating with source Reserve and data expirationdate : t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t Note that t/db_dependent/Reserves/CancelExpiredReserves.t does not fail without this patch but surely we prefere change it also. Test plan : prove t/db_dependent/Holds/WaitingReserves.t prove t/db_dependent/Reserves/CancelExpiredReserves.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 David Nind changed: What|Removed |Added Attachment #129962|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 129969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129969=edit Bug 29976: (Bug 21729 followup) fix holds unit tests Bug 21729 added to holds table the column patron_expiration_date. Currently test suite is failing : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/516/testReport/ We must fix where TestBuilder is creating with source Reserve and data expirationdate : t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t Note that t/db_dependent/Reserves/CancelExpiredReserves.t does not fail without this patch but surely we prefere change it also. Test plan : prove t/db_dependent/Holds/WaitingReserves.t prove t/db_dependent/Reserves/CancelExpiredReserves.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 --- Comment #1 from Fridolin Somers --- Created attachment 129962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129962=edit Bug 29976: (Bug 21729 followup) fix holds unit tests Bug 21729 added to holds table the column patron_expiration_date. Currently test suite is failing : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/516/testReport/ We must fix where TestBuilder is creating with source Reserve and data expirationdate : t/db_dependent/Holds/WaitingReserves.t t/db_dependent/Reserves/CancelExpiredReserves.t Note that t/db_dependent/Reserves/CancelExpiredReserves.t does not fail without this patch but surely we prefere change it also. Test plan : prove t/db_dependent/Holds/WaitingReserves.t prove t/db_dependent/Reserves/CancelExpiredReserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29975 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29976] (Bug 21729 followup) fix holds unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Depends on||21729 Patch complexity|--- |Trivial patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 [Bug 21729] When reverting a hold the expirationdate should be reset -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
