[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #19 from Martin Renvoize --- Final patch will fail the qa script on a trailing whitespace.. this is safe to ignore in this case as it's within the HERE document and the unit test would fail without the intentional whitespace here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158653|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 158656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158656=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158652|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 158655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158655=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158651|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 158654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158654=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158650|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 158653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158653=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158649|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 158652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158652=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158648|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 158651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158651=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Blocks||35285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 [Bug 35285] Centralise notice content wrapping for html output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #12 from Martin Renvoize --- Created attachment 158650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158650=edit Bug 30287: (follow-up) Unit test for html_content This patch adds a unit test for the new `html_content` method introduced to Koha::Notice::Template in the previous patch. Test 1) Run the new unit test ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158520|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 158649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158649=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158519|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 158648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158648=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34704 Depends on|34704 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #9 from Martin Renvoize --- The dependency is moving again now and was a lot of the reason behind me working in this one. I'm considering adding back my initial swap from the html_line_break filter to wrapping in as I think that more accurately shows how such notices will be sent.. though email clients tend to auto wrap plaintext so it's still not perfect and can look a little odd in display here.. maybe stick with it as is. I'll add unit tests for the new method in Koha::Notice::Message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #8 from Lucas Gass --- This looks good and I am tempted to sign-off but the dependency is currently 'Failed QA'. Maybe we should sort that one out and then get this one done on top of Bug 34704? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35267 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||lu...@bywatersolutions.com, ||oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #7 from Martin Renvoize --- Created attachment 158520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158520=edit Bug 30287: (follow-up) Add content wrap matching send time This patch adds a new method to the Koha::Notice::Message class to wrap content in the same way we currently do at email send time. We then update the notice preview to use this method so we're embedding NoticeCSS into that iframe. This means the generated preview should now exactly match how your notice will display in email clients including any CSS you may have placed within NoticeCSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Attachment #158517|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 158519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158519=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. We simply drop the 'html_line_break' filter for the case where the notice should already be html formatted. I was tempted to replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices.. but I decided that should be for another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #5 from Martin Renvoize --- Created attachment 158517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158517=edit Bug 30287: Conditionally render notice preview This patch adds conditional formatting based on whether the notice was generated from an HTML template or a plaintext one. I replace the html_line_break for plaintext formatted notices too as I believe this closer resembles how we actually output such generated notices. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Depends on||34704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Version|21.11 |master CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org --- Comment #4 from Daniel Gaghan --- PCCLD is trying to switch all it's email notices our to template toolkit and I keep running into this issue. +1 to fixing or changing this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #3 from Katrin Fischer --- Maybe the issue is that we need to treat HTML and text notices differently in the preview. For HTML notices we don't want to display the line breaks but only rely on the , but for text notices we do. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #2 from Christopher Brannon --- (In reply to Owen Leonard from comment #1) > In what way is the preview different than the actual email? The preview shows extra line breaks that the e-mail does not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30287] Notices using HTML renders differently in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30287 --- Comment #1 from Owen Leonard --- In what way is the preview different than the actual email? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/