[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #14 from Nick Clemens --- (In reply to Emmi Takkinen from comment #13) > Fixed adding multiple items. Still thinking if we really can use items home > library to determine barcode prefix. There are plugin hooks for barcodes now: https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/commit/0ee1ea69bf01b47e63c1406e4f2a0831ebec906b And we have a plugin for prefixing barcodes with library prefixes: https://github.com/bywatersolutions/koha-plugin-barcode-prefixer Just mentioning as that may work for this case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #13 from Emmi Takkinen --- Fixed adding multiple items. Still thinking if we really can use items home library to determine barcode prefix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Attachment #134206|0 |1 is obsolete|| --- Comment #12 from Emmi Takkinen --- Created attachment 139350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139350=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan for adding item: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Test plan for adding multiple aqcuisitions: 1. Set syspref "AcqCreateItem" as "placing order". 2. Create an order and add multiple items to it. 3. Save the order. 4. Navigate to that biblios detail page to which you added items. => ordered items barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #11 from Emmi Takkinen --- (In reply to Owen Leonard from comment #10) > I'm getting an error when I try to use the "Add multiple copies" option: > > DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st > execute failed: Data too long for column 'barcode' at row 1 at > /kohadevbox/koha/Koha/Object.pm line 170 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77 > > I'm not sure why this happened--it wasn't because I'd added a prefix which > would cause the barcode to be too long. However, it does highlight that it > is a possibility: If someone uses a prefix 10 characters long the barcode > will always exceed the size of items.barcode. > Last changes which fixed ability to add multiple aqcuisitions items, broke the ability to add multiple items. Will fix it asap. > It also occurs to me... Shouldn't the prefix be determined by the item's > home library, not by the user's logged-in library? In our system, for > instance, cataloging for all the branches is done at one location. This sure doesn't take that possibility into account. I'll take a look at this also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from Owen Leonard --- I'm getting an error when I try to use the "Add multiple copies" option: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'barcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 170 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 I'm not sure why this happened--it wasn't because I'd added a prefix which would cause the barcode to be too long. However, it does highlight that it is a possibility: If someone uses a prefix 10 characters long the barcode will always exceed the size of items.barcode. It also occurs to me... Shouldn't the prefix be determined by the item's home library, not by the user's logged-in library? In our system, for instance, cataloging for all the branches is done at one location. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Attachment #134202|0 |1 is obsolete|| --- Comment #9 from Emmi Takkinen --- Created attachment 134206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134206=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan for adding item: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Test plan for adding multiple aqcuisitions: 1. Set syspref "AcqCreateItem" as "placing order". 2. Create an order and add multiple items to it. 3. Save the order. 4. Navigate to that biblios detail page to which you added items. => ordered items barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #8 from Emmi Takkinen --- (In reply to Owen Leonard from comment #5) > I think the description of the BarcodePrefix preference should say that it > is used in connection with the autoBarcode preference, and include a link to > it (and vice versa). For example: > > "Define library specific barcode prefixes in YAML format. This defines the > behavior of the mm0001 option of > autoBarcode." > > And added to the autoBarcode description, "Define the behavior of the > mm0001 option using BarcodePrefix." > Added links to descriptions and also changed BarcodePrefix as CodeMirror editor. > Should the BarcodePrefix preference provide an example for the syntax which > is expected? Or perhaps a link to the wiki like OpacHiddenItems has? > Oh, I didn't notice this one. But I guess it would be more convenient to provide example on the sysprefs description rather than external wiki page. Something like "Syntax for barcodes is e.g. DEF2022040001". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Attachment #134009|0 |1 is obsolete|| --- Comment #7 from Emmi Takkinen --- Created attachment 134202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134202=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan for adding item: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Test plan for adding multiple aqcuisitions: 1. Set syspref "AcqCreateItem" as "placing order". 2. Create an order and add multiple items to it. 3. Save the order. 4. Navigate to that biblios detail page to which you added items. => ordered items barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #6 from Owen Leonard --- Also: The BarcodePrefix textarea should be a CodeMirror editor using "text/x-yaml" syntax. See OpacHiddenItems in opac.pref for example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard --- I think the description of the BarcodePrefix preference should say that it is used in connection with the autoBarcode preference, and include a link to it (and vice versa). For example: "Define library specific barcode prefixes in YAML format. This defines the behavior of the mm0001 option of autoBarcode." And added to the autoBarcode description, "Define the behavior of the mm0001 option using BarcodePrefix." Should the BarcodePrefix preference provide an example for the syntax which is expected? Or perhaps a link to the wiki like OpacHiddenItems has? Otherwise everything was working well when tested in cataloging. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #4 from Emmi Takkinen --- Previous patch didn't have custom methods in C4/Barcodes/premmincr.pm so adding an order with multiple items produced error 500. Added methods and test plan for this scenario. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Attachment #132954|0 |1 is obsolete|| --- Comment #3 from Emmi Takkinen --- Created attachment 134009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134009=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan for adding item: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Test plan for adding multiple aqcuisitions: 1. Set syspref "AcqCreateItem" as "placing order". 2. Create an order and add multiple items to it. 3. Save the order. 4. Navigate to that biblios detail page to which you added items. => ordered items barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Attachment #132221|0 |1 is obsolete|| --- Comment #2 from Emmi Takkinen --- Created attachment 132954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132954=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 --- Comment #1 from Emmi Takkinen --- Created attachment 132221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132221=edit Bug 30328: Add ability to generate barcode with branch specific prefix We should add more flexibility to generating barcodes by letting libraries define branch specific prefix for their barcodes. This patch adds new option "premmincr" in systempreference "autoBarcode" and new systempreference "BarcodePrefix" to define branch specific prefix Test plan: 1. Apply patch and update database 2. Set syspref "autoBarcode" as 3. Add some values to syspref "Barcodeprefix" e.g.: Default: DEF CPL: CPL FFL: FFL 4. Now change your library to CPL (if needed) and add an item 5. Click barcode input field => barcode should be CPL1 6. Add another item and click barcode field => barcode should be CPL2 7. Change your library to FFL and add an item => barcode should now be FFL1 8. Change your library to e.g. FPL (or another as long as it doesn't have prefix value in "Barcodeprefix"), add an item and click barcode field => barcode should now be DEF1 9. Try to add multiple items => barcodes incremental value should increase in order (no skipping values, no errors) Also prove t/db_dependent/Barcodes_ValueBuilder.t and t/Barcodes_premmincr.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=7676 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30328] Add ability to generate barcode with branch specific prefix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30328 Emmi Takkinen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
