[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #12 from wainuiwitikap...@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|22.05.00,21.11.06,21.05.15 |22.05.00,21.11.06,21.05.15, released in||20.11.19 --- Comment #11 from Victor Grousset/tuxayo --- Backported: Pushed to 20.11.x branch for 20.11.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Victor Grousset/tuxayo changed: What|Removed |Added CC||sbr...@bywatersolutions.com --- Comment #10 from Victor Grousset/tuxayo --- *** Bug 29610 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Andrew Fuerste-Henry changed: What|Removed |Added Version(s)|22.05.00,21.11.06 |22.05.00,21.11.06,21.05.15 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 21.05.x for 21.05.15 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.05.00|22.05.00,21.11.06 released in|| CC||k...@bywatersolutions.com --- Comment #8 from Kyle M Hall --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- Good catch, PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Martin Renvoize changed: What|Removed |Added Attachment #133199|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 133388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133388=edit Bug 30346: Correctly transfer values when editing rules To test: --Create a circulation rule with a value in "Overdue fines cap (amount), or edit an existing rule to add it -Save the new (or edited) rule. -Edit the same rule again to change any other field. Note that "Overdue fines cap (amount)" is now blank -Save your edited rule - "Overdue fines cap (amount)" will save as blank. Apply patch --Create a circ rule with a value in Overdue fines cap (amount) and check "Cap fine at replacement price" for that same rule. -Save the rule -Try ediding the rule and make sure both of those values now save correctly. -Add several more rules and try playing with both "Cap fine at replacement price" and "Overdue fines cap (amount)". Make sure everything saves right. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #133198|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 133199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133199=edit Bug 30346: Correctly transfer values when editing rules To test: --Create a circulation rule with a value in "Overdue fines cap (amount), or edit an existing rule to add it -Save the new (or edited) rule. -Edit the same rule again to change any other field. Note that "Overdue fines cap (amount)" is now blank -Save your edited rule - "Overdue fines cap (amount)" will save as blank. Apply patch --Create a circ rule with a value in Overdue fines cap (amount) and check "Cap fine at replacement price" for that same rule. -Save the rule -Try ediding the rule and make sure both of those values now save correctly. -Add several more rules and try playing with both "Cap fine at replacement price" and "Overdue fines cap (amount)". Make sure everything saves right. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Lucas Gass changed: What|Removed |Added Version|21.05 |master Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 --- Comment #3 from Lucas Gass --- Created attachment 133198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133198=edit Bug 30346: Correctly transfer values when editing rules To test: --Create a circulation rule with a value in "Overdue fines cap (amount), or edit an existing rule to add it -Save the new (or edited) rule. -Edit the same rule again to change any other field. Note that "Overdue fines cap (amount)" is now blank -Save your edited rule - "Overdue fines cap (amount)" will save as blank. Apply patch --Create a circ rule with a value in Overdue fines cap (amount) and check "Cap fine at replacement price" for that same rule. -Save the rule -Try ediding the rule and make sure both of those values now save correctly. -Add several more rules and try playing with both "Cap fine at replacement price" and "Overdue fines cap (amount)". Make sure everything saves right. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- This is because we are erroneously trying get the value from the 'Cap fine at replacement price' column which is a checked or not checked value. When we go through each of the columns we copy the current values over. There is a line like: else if ( i == 15 ) And that is wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 Andrew Fuerste-Henry changed: What|Removed |Added Summary|Editing circ rule with |Editing circ rule with |Overdue fines cap (amount) |Overdue fines cap (amount) |results in data loss|results in data loss and ||extra fines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
