[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2023-01-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484
Bug 30484 depends on bug 28909, which changed state.

Bug 28909 Summary: Allow interlibrary loans illview method to use backend 
template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This interlibrary loans
  release notes||module enhancement allows
   ||backend developers to
   ||trigger notices to patrons
   ||upon certain backend
   ||actions.
   ||
   ||**Sponsored by**
   ||*PTFS Europe*

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

   Assignee|bugzi...@warmlight.co.uk|koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Needs documenting
 CC||lu...@bywatersolutions.com

--- Comment #29 from Lucas Gass  ---
Enhancement will not be backported to 22.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #28 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #27 from Katrin Fischer  ---
Created attachment 138862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138862=edit
Bug 28909: (QA follow-up) Fix typo 'Kind Regards'

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #134628|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 138861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138861=edit
Bug 30484: Add unit tests

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=28909

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #134627|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 138860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138860=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=28909

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #134626|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 138859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138859=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=28909

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #23 from Katrin Fischer  ---
(In reply to Andrew Isherwood from comment #8)
> Revised test plan:
> 
> This test plan tests the provided functionality by using a mocked update
> supplied by the FreeForm backend. The command line script is run which will
> look for requests that match the supplied criteria, obtain a mocked update
> from them, and process the update. The processor simply prints the message
> supplied in the update to the screen.
> 
> - Ensure you have Interlibrary Loans turned on and have the FreeForm backend
> installed. It is important you are using the "bug_30484_mock_request_update"
> branch of the FreeForm backend as this enables the backend to provide mock
> updates that this functionality uses.
> - Ensure that the patron that will be creating the request has the
> "Interlibrary loan updated" notice enabled for at least "Email"
> - Create a FreeForm ILL request
> - On the "Manage ILL request" page for the newly created request, click the
> "Confirm request" button, thereby setting the request status to "Requested"
> - Run the script, in the "misc" directory, run:
> 
>   perl process_ill_updates.pl --statuses REQ --backend FreeForm
> 
> - TEST: You should see the following:
>   - The message "This is a mock update from the FreeForm backend"
>   - The following run report:
> 
> Run details:
> Request ID: xxx
>   Processing by: FreeForm
>   Number of processors run: 1
>   Processor details:
> Processor name: Print to STDERR
> Success messages: PRINTED
> Error messages:
> 
> - If the above messages were printed, the test plan can be considered
> successful.

1) Typo in updatedatabase: Kind Regards > Kind regards
I've added a follow-up patch fixing this globally.

2) +=head3 append_to_note.
I see it only appears in Illrequest.pm and has a test, but not sure how it
relates to the functionality of this patch set?

3) Worked through the test plan and it works as described. The changes for
messaging preferences appear to be complete, but we should start thinking about
a way to make the list of message options configurable as not all libraries
will offer all notices (totally a separate bug of course).

Now we need another QA for the dependent bug 28909 to unlock!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Katrin Fischer  changed:

   What|Removed |Added

Summary|Interlibrary Loans should   |Interlibrary loans should
   |have the ability to send|have the ability to send
   |notices based on request|notices based on request
   |supplier updates|supplier updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Katrin Fischer  changed:

   What|Removed |Added

Version|unspecified |master
 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134574|0   |1
is obsolete||

--- Comment #22 from Andrew Isherwood  ---
Created attachment 134628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134628=edit
Bug 30484: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134573|0   |1
is obsolete||

--- Comment #21 from Andrew Isherwood  ---
Created attachment 134627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134627=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134572|0   |1
is obsolete||

--- Comment #20 from Andrew Isherwood  ---
Created attachment 134626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134626=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134571|0   |1
is obsolete||

--- Comment #19 from Andrew Isherwood  ---
Created attachment 134574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134574=edit
Bug 30484: Add unit tests

Signed-off-by: Stephen Graham 

Sponsored-by: University of Hertfordshire

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134570|0   |1
is obsolete||

--- Comment #18 from Andrew Isherwood  ---
Created attachment 134573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134573=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

Signed-off-by: Stephen Graham 

Sponsored-by: University of Hertfordshire

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134569|0   |1
is obsolete||

--- Comment #17 from Andrew Isherwood  ---
Created attachment 134572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134572=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

Signed-off-by: Stephen Graham 

Sponsored-by: University of Hertfordshire

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134488|0   |1
is obsolete||

--- Comment #16 from Andrew Isherwood  ---
Created attachment 134571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134571=edit
Bug 30484: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134487|0   |1
is obsolete||

--- Comment #15 from Andrew Isherwood  ---
Created attachment 134570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134570=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #134486|0   |1
is obsolete||

--- Comment #14 from Andrew Isherwood  ---
Created attachment 134569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134569=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #13 from Andrew Isherwood  ---
Now setting back to Needs signoff, forward ported to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #133401|0   |1
is obsolete||

--- Comment #12 from Andrew Isherwood  ---
Created attachment 134488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134488=edit
Bug 30484: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #133400|0   |1
is obsolete||

--- Comment #11 from Andrew Isherwood  ---
Created attachment 134487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134487=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #133399|0   |1
is obsolete||

--- Comment #10 from Andrew Isherwood  ---
Created attachment 134486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134486=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #9 from Andrew Isherwood  ---
Set this back to assigned as I'd forgotten it needs forward porting onto master
before it can be QA'ed, it was developed against 21.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #8 from Andrew Isherwood  ---
Revised test plan:


This test plan tests the provided functionality by using a mocked update
supplied by the FreeForm backend. The command line script is run which will
look for requests that match the supplied criteria, obtain a mocked update from
them, and process the update. The processor simply prints the message supplied
in the update to the screen.

- Ensure you have Interlibrary Loans turned on and have the FreeForm backend
installed. It is important you are using the "bug_30484_mock_request_update"
branch of the FreeForm backend as this enables the backend to provide mock
updates that this functionality uses.
- Ensure that the patron that will be creating the request has the
"Interlibrary loan updated" notice enabled for at least "Email"
- Create a FreeForm ILL request
- On the "Manage ILL request" page for the newly created request, click the
"Confirm request" button, thereby setting the request status to "Requested"
- Run the script, in the "misc" directory, run:

  perl process_ill_updates.pl --statuses REQ --backend FreeForm

- TEST: You should see the following:
  - The message "This is a mock update from the FreeForm backend"
  - The following run report:

Run details:
Request ID: xxx
  Processing by: FreeForm
  Number of processors run: 1
  Processor details:
Processor name: Print to STDERR
Success messages: PRINTED
Error messages:

- If the above messages were printed, the test plan can be considered
successful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #7 from Andrew Isherwood  ---
TEST PLAN:

This test plan tests the provided functionality by using a mocked update
supplied by the FreeForm backend. The command line script is run which will
look for requests that match the supplied criteria, obtain a mocked update from
them, and process the update. The processor simply prints the message supplied
in the update to the screen.

- Ensure you have Interlibrary Loans turned on and have the FreeForm backend
installed. It is important you are using the "bug_30484_mock_request_update"
branch of the FreeForm backend as this enables the backend to provide mock
updates that this functionality uses.
- Create a FreeForm ILL request
- On the "Manage ILL request" page for the newly created request, click the
"Confirm request" button, thereby setting the request status to "Requested"
- Run the script, in the "misc" directory, run:

  perl process_ill_updates.pl --statuses REQ --backend FreeForm

- TEST: You should see the following:
  - The message "This is a mock update from the FreeForm backend"
  - The following run report:

Run details:
Request ID: xxx
  Processing by: FreeForm
  Number of processors run: 1
  Processor details:
Processor name: Print to STDERR
Success messages: PRINTED
Error messages:

- If the above messages were printed, the test plan can be considered
successful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #133396|0   |1
is obsolete||

--- Comment #6 from Andrew Isherwood  ---
Created attachment 133401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133401=edit
Bug 30484: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #133395|0   |1
is obsolete||

--- Comment #5 from Andrew Isherwood  ---
Created attachment 133400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133400=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Attachment #133394|0   |1
is obsolete||

--- Comment #4 from Andrew Isherwood  ---
Created attachment 133399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133399=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #3 from Andrew Isherwood  ---
Created attachment 133396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133396=edit
Bug 30484: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #2 from Andrew Isherwood  ---
Created attachment 133395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133395=edit
Bug 30484: Implement support for ILL request updates

This commit adds support for the concept of ILL request update notices.

- Adds a new Koha::Illrequest::SupplierUpdate class that is used to
encapsulate an update to a request, this update may come from a
supplier via a backend or from core ILL via, perhaps, a user action
- Adds a new Koha::Illrequest::SupplierUpdateProcessor base class that
can be subclassed in order to create a processor that can be passed an
update and act accordingly.
- Updates to Illrequest.pm to support the above classes and allow core
Koha to offer update processors
- A shell script to initiate a periodic process to check for updates
meeting given criteria and run the appropriate processors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

--- Comment #1 from Andrew Isherwood  ---
Created attachment 133394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133394=edit
Bug 30484: Add ILL update notice

Adds a new ILL_REQUEST_UPDATE notice which is to be used for the
formation of notices informing users of updates to ILL requests.

Commit includes database updates and template changes for messaging
preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Depends on||28909


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28909
[Bug 28909] Allow Interlibrary Loans illview method to use backend template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30484] Interlibrary Loans should have the ability to send notices based on request supplier updates

2022-04-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30484

Andrew Isherwood  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ
   |ity.org |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/