[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED --- Comment #35 from Caroline Cyr La Rose --- I'm unsure what needs to be documented here. Setting it to resolved, but feel free to reopen it with specifications -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Blocks||31782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31782 [Bug 31782] Patron lists - patron autocomplete search does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||lu...@bywatersolutions.com --- Comment #34 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #33 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Marcel de Rooy changed: What|Removed |Added Blocks||25498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 [Bug 25498] Allow to change owner of public or shared list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #32 from Martin Renvoize --- (In reply to Jonathan Druart from comment #31) > Conflict with bug 21978 fixed. Thanks Joubu.. it was on my list to fix that conflict.. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #31 from Jonathan Druart --- Conflict with bug 21978 fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136134|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 136579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136579=edit Bug 30578: Fix multi-terms search Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136133|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 136578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136578=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136132|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 136577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136577=edit Bug 30578: Fix on-select for 2 occurrences Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136131|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 136576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136576=edit Bug 30578: Restore highlighting of patrons from the logged-in library Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #136130|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 136575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136575=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Blocks||30980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30980 [Bug 30980] Make patron selection more consistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize --- Great work, similarly I didn't mean we had to do a select2 migration now.. more just pointing out where my brain was headed.. I can create a bug to record the idea for the future. So, on with QA.. it's all working really nicely and is a nice consistency improvement. Owens uncovered and had fixed all the issues I spotted (and some more). QA scripts are happy.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Attachment #136089|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 136134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136134=edit Bug 30578: Fix multi-terms search Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Attachment #136088|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 136133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136133=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Attachment #136087|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 136132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136132=edit Bug 30578: Fix on-select for 2 occurrences Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Attachment #136086|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 136131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136131=edit Bug 30578: Restore highlighting of patrons from the logged-in library Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added Attachment #136085|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 136130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136130=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #19 from Owen Leonard --- This is great work, Jonathan, thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #18 from Owen Leonard --- Created attachment 136089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136089=edit Bug 30578: Fix multi-terms search Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #17 from Owen Leonard --- Created attachment 136088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136088=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #16 from Owen Leonard --- Created attachment 136087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136087=edit Bug 30578: Fix on-select for 2 occurrences Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #15 from Owen Leonard --- Created attachment 136086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136086=edit Bug 30578: Restore highlighting of patrons from the logged-in library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Attachment #135920|0 |1 is obsolete|| Attachment #136041|0 |1 is obsolete|| Attachment #136042|0 |1 is obsolete|| Attachment #136043|0 |1 is obsolete|| Attachment #136044|0 |1 is obsolete|| --- Comment #14 from Owen Leonard --- Created attachment 136085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136085=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Blocks||30965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30965 [Bug 30965] Add patron autocomplete search to curbside pickups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25498 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #13 from Jonathan Druart --- All fixed, thanks a lot, Owen! This patch is simply doing what the bug title is describing, nothing else. I found it when I was opening a new one. We could still move to select2 later, it will be easier with this move anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #12 from Jonathan Druart --- Created attachment 136044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136044=edit Bug 30578: Fix multi-terms search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #11 from Jonathan Druart --- Created attachment 136043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136043=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #10 from Jonathan Druart --- Created attachment 136042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136042=edit Bug 30578: Fix on-select for 2 occurrences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #9 from Jonathan Druart --- Created attachment 136041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136041=edit Bug 30578: Restore highlighting of patrons from the logged-in library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #8 from Owen Leonard --- In case there's any confusion based on my previous comment, I'm not saying that this patch should be switched to use Select2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- > I basically wondered if Select2 > was the better option for at least some of the occurrences where we were > using this customer ysearch service. As I said to Martin in IRC, if Select2 can do everything we need I'm in favor of switching. That would mean we wouldn't have to add another JS library when we're ready to get rid of jQueryUI altogether. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #6 from Owen Leonard --- I found a couple of issues: - The colored highlighting of patrons from the user's logged-in branch isn't working anymore - The circulation and patron header searches don't do anything when you click one of the autocomplete results - The search doesn't work with more than one term. With the old ysearch I could type "leonard owen" or "owen leonard" and get the correct result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #5 from Martin Renvoize --- Interesting; I will have to take a deeper look at what you've done here. When I first submitted this bug I was working on the bookings submission and I opted to use Select2 for patron selection. I basically wondered if Select2 was the better option for at least some of the occurrences where we were using this customer ysearch service. I felt there was a clear mix of two things.. actual autocomplete in a search box and what was really just a select in a form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #4 from Jonathan Druart --- Sorry, I forgot to commit a new file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Attachment #135856|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 135920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135920=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I'm seeing "Uncaught ReferenceError: patron_autocomplete is not defined" in the console. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #1 from Jonathan Druart --- Created attachment 135856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135856=edit Bug 30578: Remove circ/ysearch.pl in favor of the /patrons REST API route This patch removes the circ/ysearch.pl script used by the jQuery autocomplete widget. We can now use the /api/v1/patrons endpoint to retrieve the patrons and generate the patron result list. Prior to this patch the different occurrences were defining the style and the list of patron's attributes to display for each option (name, date of birth, age, address, etc.). Now they are all displaying the same information. To acchieve this we had to: * Make js-date-format.inc and js-patron-get-age.inc available from js_includes.inc and so available from everywhere, which is certainly a good move. We could discuss why this code is in include file instead of JS files however. * Remove the .ajaxSetup call in tags-review.js to reduce its scope: an underscore parameter was added to the REST API query (?) A better solution would have been to extend the existing widget (https://learn.jquery.com/jquery-ui/widget-factory/extending-widgets/) but I didn't manage to do it, and I feel like there is a bug in jQuery autocomplete. The "source" was not taken into account. We could think about replacing the jQuery autocomplete with something else, but that's outside the scope of this bug. Test plan: Search for patrons and confirm the autocomplete works and that the "select" action works as before (either a redirect or select the patrons) on the different views: * Place a hold * Search for tags (form on the left) * In the header, "Check out" and "Search patrons" * Add instructors to course reserves * View logs (the "librarian" input) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30063 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
