[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Jonathan Druart changed: What|Removed |Added Blocks||35142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35142 [Bug 35142] Koha::Util::oclc_number should be removed in favor of Koha::Biblio::Metadata::Extractor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Documentation||Caroline Cyr La Rose contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/678 Resolution|--- |FIXED Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Katrin Fischer changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|Needs documenting --- Comment #25 from Katrin Fischer --- Please don't forget about Needs Documenting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|RESOLVED Resolution|--- |FIXED --- Comment #24 from Lucas Gass --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #22 from Kyle M Hall --- Created attachment 138050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138050=edit Bug 30678: (follow-up) Change call in opac scripts Test plan: See first patch. Add orgcode OCoLC. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #20 from Kyle M Hall --- Created attachment 138048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138048=edit Bug 30678: Adjust pref description Test plan: Look up pref OPACSearchForTitleIn. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
Kyle M Hall changed:
What|Removed |Added
Attachment #138046|0 |1
is obsolete||
--- Comment #19 from Kyle M Hall ---
Created attachment 138047
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138047=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #21 from Kyle M Hall --- Created attachment 138049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138049=edit Bug 30678: (follow-up) Add oclc_number routine and friends As requested by QA, we should match the orgcode. Adding a few small routines in a Util module. Test plan: Run t/Koha/Util/MARC.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
Kyle M Hall changed:
What|Removed |Added
Attachment #136222|0 |1
is obsolete||
Attachment #136223|0 |1
is obsolete||
Attachment #136224|0 |1
is obsolete||
Attachment #136225|0 |1
is obsolete||
--- Comment #18 from Kyle M Hall ---
Created attachment 138046
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138046=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Nind
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Attachment #134847|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 136225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136225=edit Bug 30678: (follow-up) Change call in opac scripts Test plan: See first patch. Add orgcode OCoLC. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Attachment #134846|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 136224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136224=edit Bug 30678: (follow-up) Add oclc_number routine and friends As requested by QA, we should match the orgcode. Adding a few small routines in a Util module. Test plan: Run t/Koha/Util/MARC.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Attachment #134845|0 |1 is obsolete|| --- Comment #15 from Marcel de Rooy --- Created attachment 136223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136223=edit Bug 30678: Adjust pref description Test plan: Look up pref OPACSearchForTitleIn. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
Marcel de Rooy changed:
What|Removed |Added
Attachment #134844|0 |1
is obsolete||
--- Comment #14 from Marcel de Rooy ---
Created attachment 136222
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136222=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #13 from Marcel de Rooy --- Patch does not apply, Kyle ?? Applying: Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn Applying: Bug 30678: Adjust pref description Applying: Bug 30678: (follow-up) Add oclc_number routine and friends Applying: Bug 30678: (follow-up) Change call in opac scripts Using index info to reconstruct a base tree... M opac/opac-ISBDdetail.pl M opac/opac-MARCdetail.pl M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging opac/opac-MARCdetail.pl Auto-merging opac/opac-ISBDdetail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #12 from Marcel de Rooy --- (In reply to David Nind from comment #10) > Signed-off-by: David Nind Thx David ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
David Nind changed:
What|Removed |Added
Text to go in the||This enhancement to the
release notes||OPAC detail page allows you
||to search WorldCat using
||the OCLC number. (Example:
||add an entry to 035$a (such
||as (OCoLC)62385712) and use
||{OCLC_NO} in the
||OPACSearchForTitleIn system
||preference.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #11 from David Nind --- Tetsing notes (koha-testing-docker): 1. Make tag 035 and subfields visible in the MARC editor for the BKS framework. 2. Add entry to 035$a = (OCoLC)62385712 3. Follow the rest of the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 David Nind changed: What|Removed |Added Attachment #134815|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 134847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134847=edit Bug 30678: (follow-up) Change call in opac scripts Test plan: See first patch. Add orgcode OCoLC. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 David Nind changed: What|Removed |Added Attachment #134814|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 134846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134846=edit Bug 30678: (follow-up) Add oclc_number routine and friends As requested by QA, we should match the orgcode. Adding a few small routines in a Util module. Test plan: Run t/Koha/Util/MARC.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 David Nind changed: What|Removed |Added Attachment #134614|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 134845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134845=edit Bug 30678: Adjust pref description Test plan: Look up pref OPACSearchForTitleIn. Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
David Nind changed:
What|Removed |Added
Attachment #134613|0 |1
is obsolete||
--- Comment #7 from David Nind ---
Created attachment 134844
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134844=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
Signed-off-by: David Nind
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #6 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #3) > I don't think the name is a good fit, because 035$a is repeatable and not > reserved for WorldCat numbers. It all depends on the prefix. Good point. > I think if you want to keep the name, you should use the prefixes (I think > there are multiple) to select the actual OCLC number. The regex now covers all important ones: OCoLC with/without suffixes. > But I'd like it even better, if we could make the prefix configurable, maybe > as an attribute or with a pipe in the placeholder? This would also help to > deal with cases of multiple 035$a and make it useful for even more use cases. This requires more work. Part of it is reworking parametrized_url. Postponing this here to bug 30679. > It's also not clear which would be picked if there are multiple (first?) Currently the first one. But here also, 30679 could make improvements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #5 from Marcel de Rooy --- Created attachment 134815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134815=edit Bug 30678: (follow-up) Change call in opac scripts Test plan: See first patch. Add orgcode OCoLC. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #4 from Marcel de Rooy --- Created attachment 134814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134814=edit Bug 30678: (follow-up) Add oclc_number routine and friends As requested by QA, we should match the orgcode. Adding a few small routines in a Util module. Test plan: Run t/Koha/Util/MARC.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- I don't think the name is a good fit, because 035$a is repeatable and not reserved for WorldCat numbers. It all depends on the prefix. I think if you want to keep the name, you should use the prefixes (I think there are multiple) to select the actual OCLC number. But I'd like it even better, if we could make the prefix configurable, maybe as an attribute or with a pipe in the placeholder? This would also help to deal with cases of multiple 035$a and make it useful for even more use cases. To give an example from one of our union catalog records: 035 _a(DE-627)1618146513 035 _a(DE-576)303474114 035 _a(DE-599)BSZ303474114 035 _a(OCoLC)611542131 2 are union catalog internal identifiers, one is German national library and one is WorldCat. It's also not clear which would be picked if there are multiple (first?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 --- Comment #2 from Marcel de Rooy --- Created attachment 134614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134614=edit Bug 30678: Adjust pref description Test plan: Look up pref OPACSearchForTitleIn. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678
--- Comment #1 from Marcel de Rooy ---
Created attachment 134613
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134613=edit
Bug 30678: Add OCLC_NO as option to OPACSearchForTitleIn
We need to pass OCLC_NO as key to C4::Output::parametrized_url.
We get it from MARC21 035$a and strip the organizational code.
Test plan:
Add e.g. 62385712 in 035$a in a record.
Add e.g. following link to pref OPACSearchForTitleIn:
https://worldcat.org/search?q={OCLC_NO}; target="_blank">WorldCat
(via OCLC number)
Open that record on detail page. Click More searches. Follow that link.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30679 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30678] Add OCLC_NO as option to OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30678 Marcel de Rooy changed: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
