[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Bug 30751 depends on bug 19966, which changed state. Bug 19966 Summary: Add ability to pass objects directly to slips and notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added Depends on||19966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966 [Bug 19966] Add ability to pass objects directly to slips and notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 --- Comment #5 from Martin Renvoize --- So we really need bug 19966 for this to ever work I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 --- Comment #4 from Martin Renvoize --- Hmm, I think I see what you're saying.. but I don't think the suggested change will work either. Notices always fetch the data from the database for themselves, so splitting out the change and store calls won't help as the notice itself will still refer back to the database on generation. Hmm... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #3 from Nick Clemens ---
Right now, the error is not set in the issue object if not confirm:
$auto_renew->auto_renew_error($error)->store if $confirm;
I suspect we need:
$auto_renew->auto_renew_error($error)
$auto_renew->store if $confirm;
Additionally:
173 if ($confirm){
174 my $date_due = AddRenewal( $auto_renew->borrowernumber,
$auto_renew->itemnumber, $auto_renew->branchcode, undef, undef, undef, 0 );
175 $auto_renew->auto_renew_error(undef)->store;
176 }
Otherwise the messages I get don't have the correct info/status
There may be other instances like this to check as well
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Lucas Gass changed: What|Removed |Added Attachment #134980|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 134984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134984=edit Bug 30751: Add notice printing to automatic_renewals.pl This patch adds notice preview to the automatic_renewals.pl script. Test plan 1) Setup automtic renewals and add some checkouts with autorenewal enabled 2) Run the automatic_renewals.pl script with verbose mode. (without confirm if your testing and don't want to actually send notice or perform the renewals) 3) Confirm that you no get notices printed at the end of the output Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30755 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30278 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added CC||lucy.vaux-harvey@ptfs-europ ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 --- Comment #1 from Martin Renvoize --- Created attachment 134980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134980=edit Bug 30751: Add notice printing to automatic_renewals.pl This patch adds notice preview to the automatic_renewals.pl script. Test plan 1) Setup automtic renewals and add some checkouts with autorenewal enabled 2) Run the automatic_renewals.pl script with verbose mode. (without confirm if your testing and don't want to actually send notice or perform the renewals) 3) Confirm that you no get notices printed at the end of the output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30751] Print autorenewal notice to console when running in verbose.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30751 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
