[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch

2022-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Katrin Fischer  ---

1) I am not sure if we don't give off the wrong impression here. The link for
"my library" and "all libraries" is the same, because the patron modification
page doesn't filter. But I think having 2 links would give off the impression
that they behave differently. Would it be possible to create a link that
filters? Or maybe we keep the link on the Patrons requesting... and not on the
numbers.

2) We don't take  IndependentBranchesPatronModifications into account. I
believe if that is 'on' we should only show the library count and could hide
the all libraries one.

3) When there are no modification requests for the current library, it reads:
Patrons requesting modifications: Centerville: / All libraries: 1

For suggestions we show 0 here, which is a little nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

Daniel Jones  changed:

   What|Removed |Added

 CC||daniel.jones@cheshireshared
   ||services.gov.uk
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Daniel Jones  
---
Works as described, great idea for a feature.

I noticed this creates two links that both lead to the same location. At first
glance it looks like the first link will only take you to patrons of that
library who require approval.

Maybe if it was all one link it would be clearer that the destination is the
same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch

2022-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Attachment #135823|0   |1
is obsolete||

--- Comment #2 from sandbo...@biblibre.com  ---
Created attachment 137644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137644=edit
Bug 30849: show pending modifications by branch

To test:
1. Add some borrower modifications from the OPAC from patrons that belong to
some different libraries.
2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons
requesting modifications:' but no way of knowing if they are patrons from your
logged in branch or not
3. Apply patch, restart_all
4. Try step 2 again and now you should see something like 'Patrons requesting
modifications: Centerville: 1 / All libraries: 2';
5. Trying and and fulfilling some modifcations and make sure the numbers on
mainpage.pl are always correct.

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch

2022-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch

2022-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

--- Comment #1 from Lucas Gass  ---
Created attachment 135823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135823=edit
Bug 30849: show pending modifications by branch

To test:
1. Add some borrower modifications from the OPAC from patrons that belong to
some different libraries.
2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons
requesting modifications:' but no way of knowing if they are patrons from your
logged in branch or not
3. Apply patch, restart_all
4. Try step 2 again and now you should see something like 'Patrons requesting
modifications: Centerville: 1 / All libraries: 2';
5. Trying and and fulfilling some modifcations and make sure the numbers on
mainpage.pl are always correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch

2022-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/