[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #11 from Arthur Suzuki --- depends on recalls, enhancement not available in 21.11, won't backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Bug 30876 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What|Removed |Added Status|RESOLVED|Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_22_05_candidate,| |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.01 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 David Nind changed: What|Removed |Added Blocks||29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 David Nind changed: What|Removed |Added Blocks||30877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30877 [Bug 30877] use List::MoreUtils::uniq from recalls_to_pull.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz QA Contact|testo...@bugs.koha-communit |alei...@catalyst.net.nz |y.org | Status|Signed Off |Passed QA --- Comment #8 from Aleisha Amohia --- Code looks good, patch works, tests happy, passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Jonathan Druart changed: What|Removed |Added Blocks||30885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 [Bug 30885] Recall - detail page explosion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 135547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135547=edit Bug 30876: (follow-up) Use the $biblio object even further Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135536|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 135546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135546=edit Bug 30876: Use Koha::Biblio Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_05_candidate Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 --- Comment #5 from Jonathan Druart --- Created attachment 135536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135536=edit Bug 30876: Use Koha::Biblio Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Jonathan Druart changed: What|Removed |Added Attachment #135534|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 135535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135535=edit Bug 30876: Fix wrong call to ->search in list context The code is clearly incorrect as ->search no longer returns a list when called in list context. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 --- Comment #3 from Jonathan Druart --- After patch: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'biblio_id' in 'where clause' at /kohadevbox/koha/Koha/Objects.pm line 394 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #2 from Jonathan Druart --- The error is: The method Koha::Items->can_be_waiting_recall is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 135534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135534=edit Bug 30876: Fix wrong call to ->search in list context The code is clearly incorrect as ->search no longer returns a list when called in list context. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29844 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29844 [Bug 29844] Remove uses of wantarray in Koha::Objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29844 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876 Tomás Cohen Arazi changed: What|Removed |Added Depends on||19532 Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
