[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC||lu...@bywatersolutions.com Status|Pushed to master|RESOLVED --- Comment #10 from Lucas Gass --- Enhancement will not be in 22.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 139497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139497=edit Bug 30941: (QA follow-up) Only export what is needed Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 139488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139488=edit Bug 30941: (QA follow-up) Import methods explicitly By explicitly importing the Koha::I18N methods, I get rid of this error: kohadev-koha@kohadevbox:/kohadevbox/koha$ qa -c 2 --run-tests testing 2 commit(s) (applied to 9b2bf04 '09 Bug 30507: Value builder for field') Processing files before patches |>| 12 / 12 (100.00%) An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::I18N': current merge results [ Koha::I18N, ] merging failed on 'Exporter' at /kohadevbox/qa-test-tools/koha-qa.pl line 112. This happens because the Koha::I18N library is exporting all its methods explicitly and, by design, the __ methods used in value builders cannot determine which of the imported methods to use i.e. if Koha::I118N::__ or Koha::CodeList::Unimarc::MediumOfPerformance:__ Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #6 from Kyle M Hall --- Created attachment 139484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139484=edit Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall changed: What|Removed |Added Attachment #139478|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 139483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139483=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall changed: What|Removed |Added Attachment #136000|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 139478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139478=edit Bug 30941: (QA follow-up) Add exec flag to scripts Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds value release notes||builders for UNIMARC 146$b, ||$c, $d, $e, and $f. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes (using koha-testing-docker): 1. I didn't check the "Category of instrument or voice" fully against https://www.iflastandards.info/unimarc/terms/mop 2. Everything else seemed to work as expected. This may require someone who is ore familiar with UNIMARC to sign off as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind changed: What|Removed |Added Attachment #135937|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 136000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136000=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30941] Add value builders for UNIMARC 146 ($b, $c, $d, $e and $f)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30941 --- Comment #1 from Julian Maurice --- Created attachment 135937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135937=edit Bug 30941: Add cataloguing plugins for 146$bcdef (UNIMARC) Test plan: 1. Configure the default MARC framework to use those value builders: - unimarc_field_146b for 146$b - unimarc_field_146c for 146$c - unimarc_field_146d for 146$d - unimarc_field_146e for 146$e - unimarc_field_146f for 146$f 2. Verify that they all work correctly according to https://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_146.pdf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
