[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #12 from Arthur Suzuki --- I don't reproduce the bug in 21.11.x. Not backporting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.01 released in|| CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 --- Comment #9 from Martin Renvoize --- OK, I see.. the controller already has president of just skipping bad case and hopes for the best clientside. As you were.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- I'm not sure about this patch actually.. the controller change feels somehow wrong, silently skipping. I'd expect to either see an error thrown back or for us to default to the items homebranch or holdingbranch (though holdingbranch may be 'unknown' as the item may be on loan) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Katrin Fischer changed: What|Removed |Added Attachment #136325|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 136326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136326=edit Bug 30960: Fix JS error message when no pick-up location is selected when placing a hold It's possible to place item-level hold without selecting a pick-up location, which causes problems: if the item is then returned, Koha tells about a hold, but gives error 500. At patron's hold tab you see the number of holds, but cannot see the actual holds there. However, if you go to the title in question, then modify the hold so that it has a pick-up location, then the hold will work normally again. This patch fixes already existing but not working JS error message and ensures that hold cannot be made while pickup location is undefined. To reproduce: 1. Go to admin page, to the libraries configurations, and disable pickup location for one of them. 2. Pick any biblio that has items that have that same library as a default pickup location. 3. When placing the item-level hold, notice that the pickup location dropdown box is empty by default. Keep it empty, place the hold. 4. Go to the patron's page of the patron who you placed that hold for, check that it doesn't show the new hold. 5. Apply patch. 6. Repeat steps 2 and 3, it shouldn't let you make the item-level hold until you select a specific pickup location. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Katrin Fischer changed: What|Removed |Added Attachment #136304|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 136325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136325=edit Bug 30960: Don't allow user to place the hold without a pick-up place It's possible to place item-level hold without selecting a pick-up location, which causes problems: if the item is then returned, Koha tells about a hold, but gives error 500. At customer's hold tab you see the number of holds, but cannot see the actual holds there. However, if you go to the title in question, then modify the hold so that it has a pick-up place, then the hold will work normally again. This patch fixes already existing but not working js error message and ensures that hold cannot be made while pickup location is undefined. To reproduce: 1. Go to admin page, to the libraries configurations, and disable pickup location for one of them. 2. Pick any biblio that has items that have that same library as a default pickup location. 3. When placing the item-level hold, notice that the pickup location dropdown box is empty by default. Keep it empty, place the hold. 4. Go to the patron's page of the patron who you placed that hold for, check that it doesn't show the new hold. 5. Apply patch. 6. Repeat steps 2 and 3, it shouldn't let you make the item-level hold until you select a specific pickup location. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 David Nind changed: What|Removed |Added Attachment #136257|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 136304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136304=edit Bug 30960: Don't allow user to place the hold without a pick-up place It's possible to place item-level hold without selecting a pick-up location, which causes problems: if the item is then returned, Koha tells about a hold, but gives error 500. At customer's hold tab you see the number of holds, but cannot see the actual holds there. However, if you go to the title in question, then modify the hold so that it has a pick-up place, then the hold will work normally again. This patch fixes already existing but not working js error message and ensures that hold cannot be made while pickup location is undefined. To reproduce: 1. Go to admin page, to the libraries configurations, and disable pickup location for one of them. 2. Pick any biblio that has items that have that same library as a default pickup location. 3. When placing the item-level hold, notice that the pickup location dropdown box is empty by default. Keep it empty, place the hold. 4. Go to the patron's page of the patron who you placed that hold for, check that it doesn't show the new hold. 5. Apply patch. 6. Repeat steps 2 and 3, it shouldn't let you make the item-level hold until you select a specific pickup location. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30960] Koha lets you place item-level holds without a pick-up place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30960 Katrin Fischer changed: What|Removed |Added Summary|Koha lets to place |Koha lets you place |item-level holds without a |item-level holds without a |pick-up place |pick-up place -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
