[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #12 from Kyle M Hall --- (In reply to Kyle M Hall from comment #11) > I have no idea what's going on, but in production this is breaking SIP! > No errors in the logs. > Is anyone else experiencing this? Ignore this^ I had set max lower than min. That was my bad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #11 from Kyle M Hall --- I have no idea what's going on, but in production this is breaking SIP! No errors in the logs. Is anyone else experiencing this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Trivial improvement, works.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Martin Renvoize changed: What|Removed |Added Attachment #139020|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 139687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139687=edit Bug 31033: Explicitly define max child processes for SIP server By default, the SIP server appears to only use 1 child process for responding to SIP connections. This change makes this explicit in the configuration, which should make it so that people who need more than 1 simultaneous SIP connection can know to just increase the value for the "max_servers" parameter in the SIPconfig.xml file. Test plan: 1. Add "max_servers='1'" to your SIP configuration file 2. koha-sip --restart kohadev 3. Open 3 terminals 4. Run "telnet localhost 6001" on 2 terminals 5. On the 3rd terminal, run the following: ss -l -n -t ps -efww | grep "sip" 6. Note that there are 2 processes called kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml One of these processes is the parent of the other 7. The Recv-Q in the "ss" output should show 1 (This means that 1 of your telnet connections is in the server's TCP backlog) 8. Celebrate as the configuration works as expected Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Kyle M Hall changed: What|Removed |Added Attachment #136470|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 139020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139020=edit Bug 31033: Explicitly define max child processes for SIP server By default, the SIP server appears to only use 1 child process for responding to SIP connections. This change makes this explicit in the configuration, which should make it so that people who need more than 1 simultaneous SIP connection can know to just increase the value for the "max_servers" parameter in the SIPconfig.xml file. Test plan: 1. Add "max_servers='1'" to your SIP configuration file 2. koha-sip --restart kohadev 3. Open 3 terminals 4. Run "telnet localhost 6001" on 2 terminals 5. On the 3rd terminal, run the following: ss -l -n -t ps -efww | grep "sip" 6. Note that there are 2 processes called kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml One of these processes is the parent of the other 7. The Recv-Q in the "ss" output should show 1 (This means that 1 of your telnet connections is in the server's TCP backlog) 8. Celebrate as the configuration works as expected Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #6 from David Cook --- (In reply to Mark Alexander from comment #5) > Thanks. Setting max_servers to '2' works for my use case with two > simultaneous connections. Great. Glad I was able to help. I enjoy networking issues heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #5 from Mark Alexander --- Thanks. Setting max_servers to '2' works for my use case with two simultaneous connections. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 David Cook changed: What|Removed |Added Version|21.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #4 from David Cook --- Created attachment 136470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136470=edit Bug 31033: Explicitly define max child processes for SIP server By default, the SIP server appears to only use 1 child process for responding to SIP connections. This change makes this explicit in the configuration, which should make it so that people who need more than 1 simultaneous SIP connection can know to just increase the value for the "max_servers" parameter in the SIPconfig.xml file. Test plan: 1. Add "max_servers='1'" to your SIP configuration file 2. koha-sip --restart kohadev 3. Open 3 terminals 4. Run "telnet localhost 6001" on 2 terminals 5. On the 3rd terminal, run the following: ss -l -n -t ps -efww | grep "sip" 6. Note that there are 2 processes called kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml One of these processes is the parent of the other 7. The Recv-Q in the "ss" output should show 1 (This means that 1 of your telnet connections is in the server's TCP backlog) 8. Celebrate as the configuration works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #3 from David Cook --- It looks like Net::Server::Prefork subclasses Net::Server::PreForkSimple which subclasses Net::Server and I'm not sure that the "max_server" configuration item actually gets passed along correctly... So I'm going to add a default of "1" for Koha since that seems to be what's used in practice... In your case, I'd say just add "max_servers='2'" or whatever you need to support your situation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 --- Comment #2 from David Cook --- Mark, your problem is solvable by changing your SIPconfig.xml file, but I think this bug is worth keeping open for now, as maybe we should change the defaults for the Koha SIP server, or at least add some comments to make it clear how it works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31033] SIP2 does not correctly handle multiple simultaneous connections
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31033 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- That's quite interesting. Using koha-testing-docker, I ran "telnet localhost 6001" from two different terminals. In a third terminal, I ran the following "ss -l -n -t" and I can see that the SIP process listening on 127.0.0.1:6001 has 1 connection in its TCP "listen" backlog. While the telnet client says it's connected, that just mean it's connected to the server's network stack. Only one connection has actually been accepted by the application. (This would probably be clear from your prod syslog as well.) Looking at the "server-params" in the SIPconfig.xml file, it looks like min_servers = 1 and min_spare_servers = 0. In theory, 0 should be fine because that should just means 0 spare servers... When I change min_spare_servers to = 1, the forking seems to work correctly. If there are no current connections, then there is only 1 child process. If there are current connections, then it keeps 1 extra connection around. I'd say it's a bug/quirk in Net::Server::PreFork which powers the SIP server. Since it looks like the SIP server has accidentally been using a max of 1 child process, we should probably set some limits on maximums since the default max server is 50. The default max spare servers is 10... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
