[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||31479


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479
[Bug 31479] Provide an option to skip the test for atomic updates
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #16 from Aleisha Amohia  ---
Never mind it has been explained to me that the test is correct and those of us
doing custom packages will need to change how we handle atomic updates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #15 from Aleisha Amohia  ---
I've opened Bug 31466 to handle this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||31466


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31466
[Bug 31466] t/00-check-atomic-updates.t always fails if atomic update exists
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

--- Comment #14 from Aleisha Amohia  ---
Was this tested with an actual atomic update in the directory?

I had an atomic update in there named bug_X_-_add_syspref.pl and it caused the
test to fail 

$ prove t/00-check-atomic-updates.t
t/00-check-atomic-updates.t .. 1/? 
#   Failed test 'check for unhandled atomic updates:
bug_30880_-_add_option_OPACResultsUnavailableGroupingBy_syspref.pl'
#   at t/00-check-atomic-updates.t line 34.
#  
'bug_30880_-_add_option_OPACResultsUnavailableGroupingBy_syspref.pl'
#   matches '(?^u:.*pl$)'
# Looks like you failed 1 test of 7.
t/00-check-atomic-updates.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 

Test Summary Report
---
t/00-check-atomic-updates.t (Wstat: 256 Tests: 7 Failed: 1)
  Failed test:  5
  Non-zero exit status: 1
Files=1, Tests=7,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.06 cusr  0.00
csys =  0.08 CPU)
Result: FAIL

Can anyone advise?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 Version(s)|22.11.00, 22.05.03-1,   |22.11.00, 22.05.03-1,
released in|21.11.11|21.11.11, 21.05.18

--- Comment #13 from Victor Grousset/tuxayo  ---
Backported: Pushed to 21.05.x branch for 21.05.18

Nothing to document, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|22.11.00|22.11.00, 22.05.03-1,
released in||21.11.11
 CC||arthur.suz...@biblibre.com

--- Comment #12 from Arthur Suzuki  ---
pushed to 21.11.x for 21.11.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30899

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James  changed:

   What|Removed |Added

   Severity|major   |blocker
Version|master  |22.05
   Priority|P5 - low|P1 - high

--- Comment #11 from Mason James  ---
bumping to blocker for 22.05.03 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #10 from Mason James  ---
(In reply to Tomás Cohen Arazi from comment #9)
> Pushed to master for 22.11.
> 
> Nice work everyone, thanks!

thanks, can we push thru to o-o-stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

--- Comment #9 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #137206|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  ---
Created attachment 137213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137213=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.t | wc -l
 2

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #7 from David Nind  ---
This is what I get after running step 1:

prove ./t | grep 00-check-atomic-updates.pl | wc -l
Use of uninitialized value $_ in pattern match (m//) at
/usr/share/perl5/PPIx/Regexp/Structure/Quantifier.pm line 117.
skipping ingest of QUOTES_413514.CEQ : filename exists at t/EdiTransport.t line
53.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $cn_item in sprintf at
/kohadevbox/koha/C4/ClassSplitRoutine/LCC.pm line 48.

#   Failed test 'Logger did not init correctly without permission'
#   at t/Logger.t line 52.
# Looks like you failed 1 test of 10.

#   Failed test 'Test01 -- Simple tests for Koha::Logger'
#   at t/Logger.t line 74.
# Looks like you failed 1 test of 1.
0

This is what I get after running step 3:

prove ./t | grep 00-check-atomic-updates.pl | wc -l
Use of uninitialized value $_ in pattern match (m//) at
/usr/share/perl5/PPIx/Regexp/Structure/Quantifier.pm line 117.
skipping ingest of QUOTES_413514.CEQ : filename exists at t/EdiTransport.t line
53.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 1.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Koha.pm line
315.
Use of uninitialized value in string eq at /kohadevbox/koha/C4/Koha.pm line
315.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 442.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $DisplayLibraryFacets in string eq at
/kohadevbox/koha/C4/Koha.pm line 455.
Use of uninitialized value $cn_item in sprintf at
/kohadevbox/koha/C4/ClassSplitRoutine/LCC.pm line 48.

#   Failed test 'Logger did not init correctly without permission'
#   at t/Logger.t line 52.
# Looks like you failed 1 test of 10.

#   Failed test 'Test01 -- Simple tests for Koha::Logger'
#   at t/Logger.t line 74.
# Looks like you failed 1 test of 1.
0

Signing off as file is renamed and tests pass for prove
t/00-check-atomic-updates.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

David Nind  changed:

   What|Removed |Added

 Attachment #137204|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 137206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137206=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.t | wc -l
 2

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James  changed:

   What|Removed |Added

 Attachment #137203|0   |1
is obsolete||

--- Comment #5 from Mason James  ---
Created attachment 137204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137204=edit
Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t

to test...

1/ run prove, test is not run :(
 prove ./t | grep 00-check-atomic-updates.pl | wc -l
 0

2/ apply patch

3/ run prove, test is run :)
 prove ./t | grep 00-check-atomic-updates.t | wc -l
 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t

2022-07-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108

Mason James  changed:

   What|Removed |Added

Summary|rename  |rename
   |./t/00-check-atomic-updates |./t/00-check-atomic-updates
   |.pl extention to *.t|.pl extension to *.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/