[Koha-bugs] [Bug 31289] Hide article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Caroline Cyr La Rose changed: What|Removed |Added Resolution|--- |FIXED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/679 Documentation||Caroline Cyr La Rose contact|| Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Summary|Hide Article requests |Hide article requests |column in circulation rules |column in circulation rules |when ArticleRequests|when ArticleRequests |syspref is disabled |syspref is disabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Version(s)|22.11.00,21.11, 22.05.06|22.11.00,22.05.06,21.11.12 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #12 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.06 |22.11.00,21.11, 22.05.06 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||vic...@tuxayo.net --- Comment #11 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Maybe something to document. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|22.11.00|22.11.00, 22.05.06 released in|| CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #8 from Katrin Fischer --- Article request is only one column - so I think we should not start the discussion here. Having separate for all suspension/fine, holds, recalls etc. would certainly make sense, but this is a small enhancement that fits the current pattern well. The other is reopening the discussion on a new editor for circulation rules, which is needed, but out of scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |In Discussion CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #6) > This makes things more consistent and simplifies for those not using Article > requests, so I am going to pass it. > > There might be some discussion to be had if it makes sense to be able to > configure a feature without having it exposed to users immediately. But > that's complicated and should probably be a general decision (maybe > something like having 3 options for the prefs? (Enable config|Enable > feature|Disable) With the new table (circulation_rules) and the granularity it provides, I think we should move article requests-specific rules to their own section, and probably collapse them by default if the feature is disabled, but editable. For the same reasons you mentioned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #6 from Katrin Fischer --- This makes things more consistent and simplifies for those not using Article requests, so I am going to pass it. There might be some discussion to be had if it makes sense to be able to configure a feature without having it exposed to users immediately. But that's complicated and should probably be a general decision (maybe something like having 3 options for the prefs? (Enable config|Enable feature|Disable) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Attachment #138544|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 138688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138688&action=edit Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled This patch hides the Article requests column in the large circulation rules table when the ArticleRequests system preference is disabled. To test: 0) Apply patch 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There isn't any mention of article requests in the table 3) Scroll down to see the other tables in the page --> There are no other article requests tables 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) Scroll right in the first table --> There should be an article requests yes/no column 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #4 from Katrin Fischer --- Please don't forget to set Assignee! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Owen Leonard changed: What|Removed |Added Attachment #138541|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 138544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138544&action=edit Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled This patch hides the Article requests column in the large circulation rules table when the ArticleRequests system preference is disabled. To test: 0) Apply patch 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There isn't any mention of article requests in the table 3) Scroll down to see the other tables in the page --> There are no other article requests tables 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) Scroll right in the first table --> There should be an article requests yes/no column 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #2 from Caroline Cyr La Rose --- I did some copy-pasting from the UseRecalls mentions in smart-rules.tt... I hope it's ok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 138541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138541&action=edit Bug 31289: Hide Article requests column in circulation rules when ArticleRequests syspref is disabled This patch hides the Article requests column in the large circulation rules table when the ArticleRequests system preference is disabled. To test: 0) Apply patch 1) With ArticleRequests disabled, go to Administration > Circulation and fines rules 2) Scroll right in the first table --> There isn't any mention of article requests in the table 3) Scroll down to see the other tables in the page --> There are no other article requests tables 4) Enable ArticleRequests in Administration > System preferences 5) Go back to the Circulation and fines rules and refresh the page 6) Scroll right in the first table --> There should be an article requests yes/no column 7) Scroll down to see the other tables in the page --> There are other article requests tables, Default open article requests limit and Default article request fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Caroline Cyr La Rose changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
