[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Caroline Cyr La Rose changed: What|Removed |Added Blocks||33705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33705 [Bug 33705] Quote of the day: table has configure button even if it's not configurable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #19 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #18 from Joonas Kylmälä --- Created attachment 140320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140320=edit Bug 31435: (QA follow-up) Don't pass explicitly default parameter values For kohaTable these are the default values. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #17 from Joonas Kylmälä --- Created attachment 140319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140319=edit Bug 31435: (follow-up) Make kohaTable calls consistent Our calls to instantiate a kohaTable from JS were inconsistent in how they pass table_settings where no table_settings exist. This patch replaces empty arrays and empty hashrefs with a consistent 'null' being passed to ake it clear we don't have any settings to pass yet. Signed-off-by: Katrin Fischer Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Joonas Kylmälä changed: What|Removed |Added Attachment #140265|0 |1 is obsolete|| Attachment #140266|0 |1 is obsolete|| --- Comment #16 from Joonas Kylmälä --- Created attachment 140318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140318=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. Signed-off-by: Katrin Fischer Suggested test plan: * Without patch: * Go to Administration > SMTP servers * Verify the configure button shows, but doesn't work * Apply patch * Reload the SMTP servers page * The configure button will no longer show Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Katrin Fischer changed: What|Removed |Added Attachment #140261|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 140266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140266=edit Bug 31435: (follow-up) Make kohaTable calls consistent Our calls to instantiate a kohaTable from JS were inconsistent in how they pass table_settings where no table_settings exist. This patch replaces empty arrays and empty hashrefs with a consistent 'null' being passed to ake it clear we don't have any settings to pass yet. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Katrin Fischer changed: What|Removed |Added Attachment #140260|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 140265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140265=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. Signed-off-by: Katrin Fischer Suggested test plan: * Without patch: * Go to Administration > SMTP servers * Verify the configure button shows, but doesn't work * Apply patch * Reload the SMTP servers page * The configure button will no longer show -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #13 from Katrin Fischer --- *cough* test plan *cough* ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Attachment #140210|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 140261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140261=edit Bug 31435: (follow-up) Make kohaTable calls consistent Our calls to instantiate a kohaTable from JS were inconsistent in how they pass table_settings where no table_settings exist. This patch replaces empty arrays and empty hashrefs with a consistent 'null' being passed to ake it clear we don't have any settings to pass yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Attachment #140209|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 140260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140260=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Attachment #140211|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #10 from Martin Renvoize --- In retrospect, I agree with you Joonas.. I wrote the patch as a way to record that I'd gone through all the templates that call KohaTable.. but sending nothing is perfectly OK.. it's sending and empty hash or empty array that's an issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||joonas.kylm...@iki.fi --- Comment #9 from Joonas Kylmälä --- In the second patch the file koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt has undef instead of null. Not sure I agree with the last patch, it is unnecessary information exposed to the programmer, since there is a default, no settings, then I don't see why it would have to be marked explictly, we don't supply the other KohaTable add_filters parameter either. I'd suggest removing the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #8 from Martin Renvoize --- OK.. so whilst trying to come up with a test plan I spotted a few inconsistencies in how we're instantiating our kohaTables and KohaTables. Instead of not passing anything, or passing an explicit 'null', we were passing empty arrays and empty hashrefs in some places.. my follow-ups correct that for consistency. In short, the tables affected by the two follow-up patches will all have displayed the 'Configure' link even when there's nothing to configure... that's the test plan ;P -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #7 from Martin Renvoize --- Created attachment 140211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140211=edit Bug 31435: (follow-up) Make KohaTable calls consistent Our calls to instantiate a KohaTable from were inconsistent in how they pass table_settings where no table_settings exist. This patch replaces empty arrays and empty hashrefs with a consistent 'null' being passed to ake it clear we don't have any settings to pass yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #6 from Martin Renvoize --- Created attachment 140210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140210=edit Bug 31435: (follow-up) Make kohaTable calls consistent Our calls to instantiate a kohaTable from JS were inconsistent in how they pass table_settings where no table_settings exist. This patch replaces empty arrays and empty hashrefs with a consistent 'null' being passed to ake it clear we don't have any settings to pass yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Attachment #139570|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 140209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140209=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass --- Is there a test plan? Maybe a list of tables we should check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Attachment #139567|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 139570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139570=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #2 from Martin Renvoize --- Created attachment 139567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139567=edit Bug 31435: Tie 'Configure' to table_settings This patch adds a check for table_settings to prevent the display of 'Configure this table' when table settings are not passed to the datatable wrapper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 --- Comment #1 from Martin Renvoize --- Spotted by Owen when testing bug 31028 * I get an error in the browser console when I click "Configure" on the datatable on the catalog concerns page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31435] "Configure this table" appears for non-configurable tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31435 Martin Renvoize changed: What|Removed |Added Depends on|31428 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31428 [Bug 31428] Shorten new button text "Configure this table" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
