[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |INVALID --- Comment #7 from Alex Buckley --- Just noting we have decided not to proceed with this fix. As Katrin pointed out in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456#c5 some content providers look to require text attribution in the Koha OPAC in order for their images to be used, so it is best for these attributions to be retained. If libraries do not use those content providers and want to hide where their cover images are coming from they can already do that using custom JavaScript in the OpacUserJS syspref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #6 from Alex Buckley --- (In reply to Katrin Fischer from comment #5) > I've quickly looked around a bit: > > Open Library Covers API (optional?) > https://openlibrary.org/dev/docs/api/covers > > 3) A courtesy link back to Open Library is appreciated, whether it be on > each individual book's page (where you can link back to the book's page on > Open Library, for example, using the same ISBN > https://openlibrary.org/isbn/9780385533225), or on your About page or in > your footer. > > > Amazon Cover API > https://developers.google.com/books/branding ? > > Google must be given attribution, using the appropriate text or brand > elements, whenever you display Google results, previews, or other content > made available through the API. > You must maintain prominent links to Google Books pages and features. Hi Katrin, Thank you for noting this. I think you're right it could be difficult to upstream this change - because of the mandatory attribution requirements of Google. Although, this change is really only giving libraries the option to revert to pre Koha 21.11 behaviour - not displaying text attribution of where an image is from. If libraries want they can hide the text using JavaScript. We think the optimal fix might be to add an ID to the parent div, if one doesn't already exist (i.e. https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L66 and https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt#L105 ) to make it easier to hide the hint with JavaScript if necessary. What do you think of that as a solution? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #5 from Katrin Fischer --- I've quickly looked around a bit: Open Library Covers API (optional?) https://openlibrary.org/dev/docs/api/covers 3) A courtesy link back to Open Library is appreciated, whether it be on each individual book's page (where you can link back to the book's page on Open Library, for example, using the same ISBN https://openlibrary.org/isbn/9780385533225), or on your About page or in your footer. Amazon Cover API https://developers.google.com/books/branding ? Google must be given attribution, using the appropriate text or brand elements, whenever you display Google results, previews, or other content made available through the API. You must maintain prominent links to Google Books pages and features. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #4 from Katrin Fischer --- Yes, I mean that text/link below the picture. I know of at least one German provider where a link behind the image was not enough and there was supposed to be text as well (again, this might have changed). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #3 from Alex Buckley --- (In reply to Katrin Fischer from comment #1) > Some cover services might have the link as a condition to using the service. > I wonder if we should investigate this first. Hi Katrin, Could you please let me know when you refer to the 'link' do you mean the description hint displayed under each image - highlighted yellow in the attached screenshot? Hiding that description hint, rather than the link to the image is the purpose of this bug report. Basically, I'm just trying to check if we're talking about the same thing :) Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #2 from Alex Buckley --- Created attachment 139812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139812=edit Description hint under image in lightbox gallery on intranet item detail page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 --- Comment #1 from Katrin Fischer --- Some cover services might have the link as a condition to using the service. I wonder if we should investigate this first. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31456] Optionally hide lightbox_descriptions from intranet lightbox gallery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31456 Alex Buckley changed: What|Removed |Added Status|NEW |ASSIGNED See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31446 Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Text to go in the||Optionally enable libraries release notes||to hide image descriptions ||from the lightbox galleries ||on intranet item detail ||pages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
