[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Bug 31468 depends on bug 29744, which changed state. Bug 29744 Summary: Harmonize psgi/plack detection methods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize --- All working and thanks for cleaning up 29744 more for us. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468
Martin Renvoize changed:
What|Removed |Added
Attachment #140693|0 |1
is obsolete||
--- Comment #12 from Martin Renvoize ---
Created attachment 140697
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140697=edit
Bug 31468: Change interface in Koha::Logger
Test plan:
Add a line in mainpage.pl:
require Koha::Logger; Koha::Logger->get->warn("intranet L51");
Restart. Hit intranet mainpage. Verify that line is in plack=intranet.
Signed-off-by: Marcel de Rooy
Retested with L49 now ;)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29744 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Depends on||29744 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744 [Bug 29744] Harmonize psgi/plack detection methods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468
Marcel de Rooy changed:
What|Removed |Added
Attachment #139822|0 |1
is obsolete||
--- Comment #11 from Marcel de Rooy ---
Created attachment 140693
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140693=edit
Bug 31468: Change interface in Koha::Logger
Test plan:
Add a line in mainpage.pl:
require Koha::Logger; Koha::Logger->get->warn("intranet L51");
Restart. Hit intranet mainpage. Verify that line is in plack=intranet.
Signed-off-by: Marcel de Rooy
Retested with L49 now ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Attachment #139821|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Comment on attachment 139821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139821 Bug 31468: Changes to C4::Context::is_psgi_or_plack This has been moved and adjusted on bug 29744 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29744 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #9 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #7) > My gut says we should finally test and push bug 29744 before this.. > harmonizing the plack detection and then use it here too Sure, I will have a look at the other one. Although it is pretty straightforward to harmonize if we would go the other way around. Still something to discuss here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #8 from David Cook --- (In reply to Martin Renvoize from comment #5) > I have recollections of trying to improve the Context method before and > getting caught by all sorts of weird side effects.. do you happen to > remember the details David? Not really but I think bug 29744 probably took care of it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Martin Renvoize changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #7 from Martin Renvoize --- My gut says we should finally test and push bug 29744 before this.. harmonizing the plack detection and then use it here too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #6 from Martin Renvoize --- Lots of discussion around our various implimentations of 'Is this a plack/psgi session' in bug 29420 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29420 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 --- Comment #5 from Martin Renvoize --- I have recollections of trying to improve the Context method before and getting caught by all sorts of weird side effects.. do you happen to remember the details David? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com --- Comment #4 from Marcel de Rooy --- Could you have a look, Martin ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Blocks||22678 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22678 [Bug 22678] Set 'Koha::Logger' as the default mojo logger for the REST API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #3 from Marcel de Rooy --- This is trivial and architectural. Going to SO rightaway. Need this for 22678 too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468
--- Comment #2 from Marcel de Rooy ---
Created attachment 139822
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139822=edit
Bug 31468: Change interface in Koha::Logger
Test plan:
Add a line in mainpage.pl:
require Koha::Logger; Koha::Logger->get->warn("intranet L51");
Restart. Hit intranet mainpage. Verify that line is in plack=intranet.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468
--- Comment #1 from Marcel de Rooy ---
Created attachment 139821
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139821=edit
Bug 31468: Changes to C4::Context::is_psgi_or_plack
When running API, we need to look for $ENV{PLACK_ENV}, but the
underscore is not included in the Context sub.
Test plan:
Run t/Context.t
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
