[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Katrin Fischer changed: What|Removed |Added Version(s)|22.11.00,21.11, 22.05.06, |22.11.00,22.05.06,21.11.12, released in|21.05.19|21.05.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #7 from Arthur Suzuki --- Thanks! Pushed to 21.11 for 21.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Arthur Suzuki changed: What|Removed |Added Version(s)|22.11.00, 22.05.06, |22.11.00,21.11, 22.05.06, released in|21.05.19|21.05.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #6 from Victor Grousset/tuxayo --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Lucas Gass changed: What|Removed |Added Version(s)|22.11.00, 21.05.19 |22.11.00, 22.05.06, released in||21.05.19 Status|Pushed to master|Pushed to stable --- Comment #5 from Lucas Gass --- Backported to 22.05.x for 22.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 21.05.19 released in|| --- Comment #4 from Victor Grousset/tuxayo --- Disregarding the backport cascade workflow. Not a problem with this patch. Now test can pass again! Backported: Pushed to 21.05.x branch for 21.05.19 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #3 from Victor Grousset/tuxayo --- Thanks a lot :D Backport needed down to 21.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #2 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_21_05_candidate, ||rel_21_11_candidate, ||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 139849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139849=edit Bug 31473: Fix fragile test about bad OpacHiddenItems conf There's been a behavior change in recent MariaDB that made some cases deal with truncated data in DOUBLE context instead of DECIMAL. Probably this: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-27380 This made the affected test fail consistently on those versions. This trick for checking OpacHiddenItems is correct (as introduced on bug 28125 doesn't really make use of the warning, just prints it in about.pl) so one option was to just check for a warning. I decided to keep the test, but add the optional DECIMAL|DOUBLE check on the qr. This way other eventual changes will make it fail and serve as a warning in case something more relevant changes. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | CC||arthur.suz...@biblibre.com, ||lu...@bywatersolutions.com, ||vic...@tuxayo.net Depends on||28125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28125 [Bug 28125] All OPAC holds blocked when OPACHiddenItems contains incorrect values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
