[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED --- Comment #6 from Lucas Gass --- Doesn't apply clean to 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Martin Renvoize changed: What|Removed |Added Severity|enhancement |minor CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #5 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.05 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer changed: What|Removed |Added Attachment #148976|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 149354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149354=edit Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 ByWater Sandboxes changed: What|Removed |Added Attachment #148972|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 148976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148976=edit Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 --- Comment #1 from Philip Orr --- Created attachment 148972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148972=edit Bug 31722: Fixed EDIFACT message to only display if EDIFACT is turned on This patch makes a small change to the display of the note "No EDIFACT configuration for..." on the basket group page to only display if the system preference EDIFACT is set to "Enable". To Test: 1. apply patch 2. navigate to a vendor over Acquisitions -> Vendor e.g. My Vendor 3. create a basket group (doesn't have to have any baskets, an empty one will do) 4. close the basket group 5. set system preference "EDIFACT" to "Enable" 6. navigate to Administration -> EDI Accounts and make sure the vendor doesn't have an EDI account configured 7. navigate to your vendor's closed basket groups over Acquisitions -> Vendor -> Basket groups (left panel) -> Tab "Closed" 8. you should see a message "No EDIFACT configuration for (name of vendor)" in the Action column 9. set system preference "EDIFACT" to "Disable" 10. go back to your vendor's closed basket groups 11. you shouldn't see the message "No EDIFACT configuration for (name of vendor)" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Philip Orr changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31722] Don't show EDIFACT note on basket group page if EDIFACT is turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31722 Philip Orr changed: What|Removed |Added CC||philip@lmscloud.de Assignee|koha-b...@lists.koha-commun |philip@lmscloud.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/