subject:"\[Koha\-bugs\] \[Bug 31791\] Add the ability to lock records to prevent modification through the Koha staff interface\(s\)"

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

--- Comment #74 from Arthur Suzuki  ---
Added my signoff, this is very good work and we have a use case for this.
Would be nice to have some interface to change the record source from staff
interface but there is an attached bug for that (bz36372)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164705|0   |1
is obsolete||

--- Comment #73 from Arthur Suzuki  ---
Created attachment 165053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165053=edit
Bug 31791: (follow-up) Tidy AddBiblio

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164704|0   |1
is obsolete||

--- Comment #72 from Arthur Suzuki  ---
Created attachment 165052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165052=edit
Bug 31791: Display record source on the detail view

Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164703|0   |1
is obsolete||

--- Comment #71 from Arthur Suzuki  ---
Created attachment 165051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165051=edit
Bug 31791: Add Koha::Biblio::Metadata->record_source

This patch adds a method for retrieving the related *Koha::RecordSource* from a
*Koha::Biblio::Metadata* object.

The method is covered by tests:

1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164702|0   |1
is obsolete||

--- Comment #70 from Arthur Suzuki  ---
Created attachment 165050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165050=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164701|0   |1
is obsolete||

--- Comment #69 from Arthur Suzuki  ---
Created attachment 165049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165049=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164700|0   |1
is obsolete||

--- Comment #68 from Arthur Suzuki  ---
Created attachment 165048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165048=edit
Bug 31791: Limit editing locked records

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164699|0   |1
is obsolete||

--- Comment #67 from Arthur Suzuki  ---
Created attachment 165047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165047=edit
Bug 31791: Add edit_locked_records and set_record_sources subpermissions

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164698|0   |1
is obsolete||

--- Comment #66 from Arthur Suzuki  ---
Created attachment 165046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165046=edit
Bug 31791: Add record locking based on source

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164697|0   |1
is obsolete||

--- Comment #65 from Arthur Suzuki  ---
Created attachment 165045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165045=edit
Bug 31791: DB changes

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #164696|0   |1
is obsolete||

--- Comment #64 from Arthur Suzuki  ---
Created attachment 165044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165044=edit
Bug 31791: Add Koha::Biblio->can_be_edited

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 
Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #63 from Martin Renvoize  ---
Upgrading my SO to a QA.. I've thoroughly tested again, QA scripts are happy
and tests coverage is good.

I can see lots of refinements for the future I'll add as bugs now.

Great work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #164197|0   |1
is obsolete||

--- Comment #62 from Lucas Gass  ---
Created attachment 164705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164705=edit
Bug 31791: (follow-up) Tidy AddBiblio

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #164196|0   |1
is obsolete||

--- Comment #61 from Lucas Gass  ---
Created attachment 164704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164704=edit
Bug 31791: Display record source on the detail view

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #164195|0   |1
is obsolete||

--- Comment #60 from Lucas Gass  ---
Created attachment 164703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164703=edit
Bug 31791: Add Koha::Biblio::Metadata->record_source

This patch adds a method for retrieving the related *Koha::RecordSource* from a
*Koha::Biblio::Metadata* object.

The method is covered by tests:

1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #164194|0   |1
is obsolete||

--- Comment #59 from Lucas Gass  ---
Created attachment 164702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164702=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #164193|0   |1
is obsolete||

--- Comment #58 from Lucas Gass  ---
Created attachment 164701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164701=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163535|0   |1
is obsolete||

--- Comment #57 from Lucas Gass  ---
Created attachment 164700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164700=edit
Bug 31791: Limit editing locked records

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163534|0   |1
is obsolete||

--- Comment #56 from Lucas Gass  ---
Created attachment 164699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164699=edit
Bug 31791: Add edit_locked_records and set_record_sources subpermissions

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163533|0   |1
is obsolete||

--- Comment #55 from Lucas Gass  ---
Created attachment 164698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164698=edit
Bug 31791: Add record locking based on source

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163532|0   |1
is obsolete||

--- Comment #54 from Lucas Gass  ---
Created attachment 164697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164697=edit
Bug 31791: DB changes

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163531|0   |1
is obsolete||

--- Comment #53 from Lucas Gass  ---
Created attachment 164696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164696=edit
Bug 31791: Add Koha::Biblio->can_be_edited

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31109

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-08 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23705

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||34943

--- Comment #52 from Tomás Cohen Arazi  ---
Rebased on top of bug 34943, currently in master.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34943
[Bug 34943] Add a pre-save plugin hook for biblios
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #51 from Tomás Cohen Arazi  ---
Created attachment 164197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164197=edit
Bug 31791: (follow-up) Tidy AddBiblio

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #50 from Tomás Cohen Arazi  ---
Created attachment 164196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164196=edit
Bug 31791: Display record source on the detail view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #49 from Tomás Cohen Arazi  ---
Created attachment 164195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164195=edit
Bug 31791: Add Koha::Biblio::Metadata->record_source

This patch adds a method for retrieving the related *Koha::RecordSource* from a
*Koha::Biblio::Metadata* object.

The method is covered by tests:

1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #48 from Tomás Cohen Arazi  ---
Created attachment 164194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164194=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-04-01 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #163536|0   |1
is obsolete||
 Attachment #163537|0   |1
is obsolete||
 Attachment #163538|0   |1
is obsolete||
 Attachment #163539|0   |1
is obsolete||
 Attachment #163545|0   |1
is obsolete||

--- Comment #47 from Tomás Cohen Arazi  ---
Created attachment 164193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164193=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #46 from Tomás Cohen Arazi  ---
Created attachment 163545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163545=edit
Bug 31791: (follow-up) Tidy AddBiblio

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #45 from Tomás Cohen Arazi  ---
I wanted to note that theres a 'tidy' warning regarding the C4::Biblio changes.
They would only go away by tidying the entire sub, as the problem is my patch
is adding lines to a fully untidy block.

I'll submit a follow-up for tidying it all, but I wouldn't push it myself. Up
to the RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #44 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #33)
> All working great.. I added a small follow-up to remove the CanBeEdited
> helper as we can just use the object methods directly in the templates.

Oh, an oversight of mine. I had written this code before that decision was
made!

(In reply to Martin Renvoize from comment #34)
> PS. We can squash my follow-up btw

Done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||36372


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372
[Bug 36372] Allow privileged users to set the 'record source' on cataloguing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 163539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163539=edit
Bug 31791: Display record source on the detail view

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #42 from Tomás Cohen Arazi  ---
Created attachment 163538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163538=edit
Bug 31791: Add Koha::Biblio::Metadata->record_source

This patch adds a method for retrieving the related *Koha::RecordSource* from a
*Koha::Biblio::Metadata* object.

The method is covered by tests:

1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 163537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163537=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 163536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163536=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 163535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163535=edit
Bug 31791: Limit editing locked records

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #38 from Tomás Cohen Arazi  ---
Created attachment 163534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163534=edit
Bug 31791: Add edit_locked_records and set_record_sources subpermissions

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #37 from Tomás Cohen Arazi  ---
Created attachment 163533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163533=edit
Bug 31791: Add record locking based on source

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 163532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163532=edit
Bug 31791: DB changes

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-20 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #163426|0   |1
is obsolete||
 Attachment #163427|0   |1
is obsolete||
 Attachment #163428|0   |1
is obsolete||
 Attachment #163429|0   |1
is obsolete||
 Attachment #163430|0   |1
is obsolete||
 Attachment #163431|0   |1
is obsolete||
 Attachment #163432|0   |1
is obsolete||
 Attachment #163433|0   |1
is obsolete||
 Attachment #163434|0   |1
is obsolete||

--- Comment #35 from Tomás Cohen Arazi  ---
Created attachment 163531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163531=edit
Bug 31791: Add Koha::Biblio->can_be_edited

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #34 from Martin Renvoize  ---
PS. We can squash my follow-up btw.. it'll throw git manipulation errors in the
QA scripts as it stands.. though I tend to like the extra info of a commit
myself.. but that's personal preference.. I know others prefer less commits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #33 from Martin Renvoize  ---
All working great.. I added a small follow-up to remove the CanBeEdited helper
as we can just use the object methods directly in the templates.

Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #32 from Martin Renvoize  ---
Created attachment 163434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163434=edit
Bug 31791: Remove CanBeEdited template helper

We've opted to rely on the objects directly in templates whenever we can
now. As such, I opt to remove this new template helper and use the
object method directly instead.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163416|0   |1
is obsolete||

--- Comment #31 from Martin Renvoize  ---
Created attachment 163433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163433=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163415|0   |1
is obsolete||

--- Comment #30 from Martin Renvoize  ---
Created attachment 163432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163432=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163414|0   |1
is obsolete||

--- Comment #29 from Martin Renvoize  ---
Created attachment 163431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163431=edit
Bug 31791: Limit editing locked records

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163413|0   |1
is obsolete||

--- Comment #28 from Martin Renvoize  ---
Created attachment 163430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163430=edit
Bug 31791: Add edit_locked_records and set_record_sources subpermissions

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163411|0   |1
is obsolete||

--- Comment #27 from Martin Renvoize  ---
Created attachment 163429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163429=edit
Bug 31791: Add record locking based on source

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163410|0   |1
is obsolete||

--- Comment #26 from Martin Renvoize  ---
Created attachment 163428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163428=edit
Bug 31791: Add TT plugin method Biblio.CanBeEdited

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163408|0   |1
is obsolete||

--- Comment #25 from Martin Renvoize  ---
Created attachment 163427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163427=edit
Bug 31791: DB changes

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #163405|0   |1
is obsolete||

--- Comment #24 from Martin Renvoize  ---
Created attachment 163426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163426=edit
Bug 31791: Add Koha::Biblio->can_be_edited

Sponsored-by: ByWater Solutions
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 163416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163416=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 163415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163415=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 163414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163414=edit
Bug 31791: Limit editing locked records

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 163413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163413=edit
Bug 31791: Add edit_locked_records and set_record_sources subpermissions

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 163411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163411=edit
Bug 31791: Add record locking based on source

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 163410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163410=edit
Bug 31791: Add TT plugin method Biblio.CanBeEdited

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #17 from Tomás Cohen Arazi  ---
Created attachment 163408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163408=edit
Bug 31791: DB changes

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #163372|0   |1
is obsolete||
 Attachment #163373|0   |1
is obsolete||
 Attachment #163374|0   |1
is obsolete||
 Attachment #163375|0   |1
is obsolete||
 Attachment #163376|0   |1
is obsolete||
 Attachment #163377|0   |1
is obsolete||
 Attachment #163378|0   |1
is obsolete||

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 163405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163405=edit
Bug 31791: Add Koha::Biblio->can_be_edited

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-19 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #163371|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #15 from Tomás Cohen Arazi  ---
The submitted patches implement the requested feature, paired with the 'record
sources' feature.

Test plan:
1. Have bug 35919 applied
2. Apply this patchset
3. Create 2 'Record sources' in the Administration section

* Record source A having edition disabled
* Record source B having edition enabled

Take notes on the record source ID for each.

4. Create a valid staff member (known user and pass)
5. Have the user set the following permissions:
- catalogue (staff access)
- editcatalogue => all subpermissions bug `edit_locked_records`
6. Login with the user on a private/incognito browser
7. Pick a record and browse to it on the private browser
=> SUCCESS: You can edit it
8. Make the record source for the chosen record be A:
   $ koha-mysql kohadev
   > UPDATE biblio_metadata SET record_source_id= WHERE
biblionumber=;
9. Refresh the private window
=> SUCCESS: You are redirected to an error page
10. Search for the chosen record
11. Try to edit it
=> SUCCESS: The 'Edit record' link is greyed and cannot be used
=> SUCCESS: The greyed text has a tooltip explaining what's going on
12. Either change the record source to B, or just edit the record source A to
allow editing
13. Refresh the record detail page
=> SUCCESS: The 'Edit record' link is no longer greyed, and the record can be
edited
=> SUCCESS: Record edition is limited by source configuration
14. Verify superlibrarians can always edit such records

Note: the only way to set the record source for now is the API, which is
extensively tested on the provided tests (t/db_dependent/api/v1/biblios.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 163378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163378=edit
Bug 31791: Add x-record-source-id header to POST /biblios

This patch adds support for setting the record source on the API. It
does so by adding support for a new header `x-record-source-id`.

Setting the record source is restricted to patrons with the
`set_record_sources` permission.

A 403 error is returned on an attempt to set it without the correct
permissions.

The feature is documented on the spec.

To test:
1. Apply this patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! Tests cover the right use cases!
3. Play with Postman (or similar)
4. Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 163377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163377=edit
Bug 31791: Add 'source_record_id' param to {Add,Mod}Biblio(Marc)

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 163376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163376=edit
Bug 31791: Limit editing locked records

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 163375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163375=edit
Bug 31791: Add edit_locked_records and set_record_sources subpermissions

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 163374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163374=edit
Bug 31791: Add record locking based on source

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 163373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163373=edit
Bug 31791: Add TT plugin method Biblio.CanBeEdited

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 163372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163372=edit
Bug 31791: DB changes

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 163371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163371=edit
Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing

This patch adds a convenient method that tells if the record is
editable, according to it's record source.

To test:
1. Apply this patch
2. Run:
   $ ktd
  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
=> SUCCESS: Tests pass! Use cases covered!
3. Sign off :-D

Signed-off-by: Matt Blenkinsop 

Bug 31791: Rename can_be_edited -> source_allows_editing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-03-18 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on|32607   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607
[Bug 32607] Add record sources CRUD
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-02-15 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-01-31 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|agustinmoy...@theke.io  |tomasco...@gmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||35919


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919
[Bug 35919] Add record sources CRUD
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2024-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791
Bug 31791 depends on bug 32607, which changed state.

Bug 32607 Summary: Add record sources CRUD
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s)

2023-06-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add the ability to lock |Add the ability to lock
   |records to prevent  |records to prevent
   |modification through the|modification through the
   |Koha staff interface(s).|Koha staff interface(s)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2023-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #6 from Kyle M Hall  ---
This should probably be based on ( or at least informed by ) bug 20256 which
does a fair amount of refactoring.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2023-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||20256


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
[Bug 20256] Add ability to limit editing of items to home library or library
group
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2023-01-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2023-01-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #5 from David Cook  ---
+1

I would like to see this functionality. There's a number of times we import
data from other systems into Koha, and the place to correct that data is
upstream, so it would flow into Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2023-01-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Agustín Moyano  changed:

   What|Removed |Added

 Depends on||32607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32607
[Bug 32607] Add import sources crud
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-11-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #3)
> Are you thinking of some kind of automatism to set the locked maybe on
> import too?

On the API front, this will be a flag to be passed, with (probably) some
default for each source i.e. there will be an 'Import sources' crud page, to
set this things.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-11-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|tomasco...@gmail.com|agustinmoy...@theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #3 from Katrin Fischer  ---
Ah! That makes a lot of sense and could be useful in our use case as well. 

Are you thinking of some kind of automatism to set the locked maybe on import
too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-10-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #2 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #1)
> Hi Nick, could you share some details about the use cases for this one?
> As we usually don't give superlibrarian permissions to users, could this be
> tied to a new permission maybe?

We also talked about a new permission, that should not be a problem.

The idea here is really the ability to lock records from certain sources - in
this case the library will be cataloging in an external system and pushing
records in to Koha. They do not wish for these records to be edited within
Koha, so want to protect them - with a limited set of users being able to edit
them if the need arises.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

--- Comment #1 from Katrin Fischer  ---
Hi Nick, could you share some details about the use cases for this one?
As we usually don't give superlibrarian permissions to users, could this be
tied to a new permission maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s).

2022-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791

Nick Clemens  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

95 matches

Mail list logo