[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Bug 31935 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What|Removed |Added Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #11 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Jacob O'Mara changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.02 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added Text to go in the||This fixes the alignment of release notes||the serials subscription ||form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #9 from Jonathan Druart --- Created attachment 145026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145026=edit Bug 31935: (follow-up) Make form look better Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Jonathan Druart changed: What|Removed |Added Attachment #144521|0 |1 is obsolete|| Attachment #144522|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 145025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145025=edit Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added Attachment #144510|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 144522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144522=edit Bug 31935: ( follow-up ) Make form look better Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added Attachment #142581|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 144521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144521=edit Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #5 from Lucas Gass --- David, I addressed your comments in a follow-up. I removed the parenthesis around vendor and record. I thought they looked weird and don't really add anything. Cait, sorry I didn't get back to this one prior to the release. Hoping we can get it in for 22.11.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #4 from Lucas Gass --- Created attachment 144510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144510=edit Bug 31935: ( follow-up ) Make form look better -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Katrin Fischer changed: What|Removed |Added Keywords||rel_22_11_candidate --- Comment #3 from Katrin Fischer --- I'd love to see this fixed before release as it's THE form in the serials module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Created attachment 142591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142591=edit Screenshot - new subscription form A couple of things I noted (see the screenshot): 1. For When receiving this serial: when "Create an item record" is selected, the Collection and Item type fields are misaligned. 2. For vendor: no space after the closing bracket and before the search icon, also there is a space between the end of the form field and the bracket which looks odd. 3. For Record: no space after the closing bracket and before "Required", also there is a space between the end of the form field and the bracket which looks odd. 4. "Search for record" and "Create record" placement: looks "off" where they are at the moment - maybe should be aligned under the input field/help text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 --- Comment #1 from Lucas Gass --- Created attachment 142581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142581=edit Bug 31935: Fix misaligned form when adding serial subscription This patch attempts to fix the misaligned form on subscription-add.tt by removing some of the wrapping tags and adding labels where appropriate. To test: 1. Add a serial subscription and notice the misaligned form on step 1. 2. Apply patch 3. Look again and confirm that the form looks better. 4. Read through everything and make sure the form still makes sense. 5. Make sure the form still works properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31935] Serials subscription form is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31935 Lucas Gass changed: What|Removed |Added Patch complexity|--- |String patch CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
