[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Nick Clemens changed: What|Removed |Added Blocks||33788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33788 [Bug 33788] moredetail.pl shows all (many?) previous borrowers instead of 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #14 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 --- Comment #13 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Jacob O'Mara changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.02 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 --- Comment #12 from Martin Renvoize --- Nice work everyone! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 --- Comment #11 from Jonathan Druart --- Restored date and author. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Jonathan Druart changed: What|Removed |Added Attachment #145255|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 145258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145258=edit Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Marcel de Rooy changed: What|Removed |Added Attachment #145156|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 145255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145255=edit Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Signed-off-by: Lucas Gass Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- Michael: Normally a rebase does not imply an author change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Lucas Gass changed: What|Removed |Added Attachment #145107|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 145156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145156=edit Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Michael Hafen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Michael Hafen changed: What|Removed |Added Attachment #144107|0 |1 is obsolete|| CC||michael.ha...@washk12.org --- Comment #6 from Michael Hafen --- Created attachment 145107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145107=edit Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed [Rebase 2023-01-06] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Andrew Fuerste-Henry --- Patch doesn't apply: Applying: Bug 32272: Restore last and previous borrowers on moredetail Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32272: Restore last and previous borrowers on moredetail [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32272-Restore-last-and-previous-borrowers-on-m-ilGOtR.patch Apply? [(y)es, (n)o, (i)nteractive] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org --- Comment #4 from Andrew Fuerste-Henry --- (In reply to Jonathan Druart from comment #1) > What's your opinion on this? > > I don't mind reintroducing the "feature", but there is something > inconsistent: We are displaying "Last returned by" if StoreLastBorrower is > set, but then display the last 3 patrons who borrowed the items whatever is > the value of StoreLastBorrower. Yeah, those are two parallel but distinct systems with some confusing labels. Both are meaningful and needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_11_candidate --- Comment #3 from Jonathan Druart --- Marking as 22.11 candidate but could be for .01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 --- Comment #2 from Jonathan Druart --- Created attachment 144107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144107=edit Bug 32272: Restore last and previous borrowers on moredetail GetItemsInfo added a card0, card1 and card2 info with the cardnumbers of the last 3 borrowers. But 31315 forgot to adjust the code when it has been moved to using Koha::Items Test plan: Check an item in and out to several patrons Go to the moredetail page (items) and confirm that the "last borrowers" info is displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||katrin.fisc...@bsz-bw.de --- Comment #1 from Jonathan Druart --- What's your opinion on this? I don't mind reintroducing the "feature", but there is something inconsistent: We are displaying "Last returned by" if StoreLastBorrower is set, but then display the last 3 patrons who borrowed the items whatever is the value of StoreLastBorrower. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Katrin Fischer changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272 Nick Clemens changed: What|Removed |Added Depends on||31315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 [Bug 31315] Remove GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
