[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com Version(s)|23.05.00,22.11.05,22.05.13 |23.05.00,22.11.05,22.05.13, released in||21.11.21 --- Comment #18 from Arthur Suzuki --- applied to 21.11 for 21.11.21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #17 from Aleisha Amohia --- This bug is present in 21.11.x, can it please be backported? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable CC||lu...@bywatersolutions.com Version(s)|23.05.00,22.11.05 |23.05.00,22.11.05,22.05.13 released in|| --- Comment #16 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.13. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Bug 32301 depends on bug 22605, which changed state. Bug 22605 Summary: Adding the option to modify/edit searches on the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #15 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.05 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #14 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #13 from Katrin Fischer --- Thx Nick, this now also works with the "Edit search" as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer changed: What|Removed |Added Attachment #148973|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 149405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149405=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Michaela Sieber changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 ByWater Sandboxes changed: What|Removed |Added Attachment #148326|0 |1 is obsolete|| --- Comment #11 from ByWater Sandboxes --- Created attachment 148973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148973=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Jonathan Druart changed: What|Removed |Added Attachment #147984|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Jonathan Druart changed: What|Removed |Added Assignee|wainuiwitikapark@catalyst.n |n...@bywatersolutions.com |et.nz | Status|Signed Off |Needs Signoff CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #10 from Nick Clemens --- I think Katrin is correct, I provided an alternate patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 --- Comment #9 from Nick Clemens --- Created attachment 148326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148326=edit Bug 32301: [alternate] Fix default search sorting in advanced search when not editing a search Bug 22605 changed the sorting to expect the passed parameter from the previous search, this broke default when the search page was loaded fresh. We should simply fallback from the edited search to the default if it is not set To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search 11) Perform a search, change the sorting, then edit the search 12) Confirm the correct sorting from the search is preserved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Depends on||22605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 ByWater Sandboxes changed: What|Removed |Added Attachment #144327|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 147984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147984=edit Bug 32301: defaultSortField changes the default Sort By in Staff Client Advanced Search Use the system preference "defaultSortField" to choose the default Sort By in the Staff Client Advances Search To test: 1) Go to staff client 2) Go to Advanced Search 3) Notice the default Sort By value is "Relevance" 4) Go to system preferences 5) Go to "defaultSortField" 6) Change the value of the system preference 7) Go back to Advanced Search and refresh the page 8) Notice that there are no changes, the default Sort By is still "Relevance" 9) Apply patch 10) Notice that changing the system preference now changes the default Sort By in Advanced Search Sponsored-by: National Institute of Atmospheric and Water Research Signed-off-by: David Nind Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com Status|Needs Signoff |Signed Off --- Comment #7 from Laura Escamilla --- (In reply to wainuiwitikapark from comment #3) > Created attachment 144310 [details] [review] > Bug 32301: defaultSortField changes the default Sort By in Staff Client > Advanced Search > > Use the system preference "defaultSortField" to choose the default Sort > By in the Staff Client Advances Search > > To test: > 1) Go to staff client > 2) Go to Advanced Search > 3) Notice the default Sort By value is "Relevance" > 4) Go to system preferences > 5) Go to "defaultSortField" > 6) Change the value of the system preference > 7) Go back to Advanced Search and refresh the page > 8) Notice that there are no changes, the default Sort By is still > "Relevance" > 9) Apply patch > 10) Notice that changing the system preference now changes the default > Sort By in Advanced Search > > Sponsored-by: National Institute of Atmospheric and Water Research Works as described. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Failed QA |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #6 from Aleisha Amohia --- Hi Katrin I've just re-tested this and believe it does work as described, can you please test again? Thanks Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi Wainui, I believe this fix is not completely right yet: 1) Do an advanced search, change the sort order from default to something else 2) In the result list click on "edit this search" on top of the results list 3) notice that the sort is kept 4) Apply patch, restart all the things 5) Repeat steps above - sort will be changed back to the default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32301] Show correct defaultSortField in staff interface advanced search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32301 Katrin Fischer changed: What|Removed |Added Summary|Show correct|Show correct |defaultSortField in staff |defaultSortField in staff |client advanced search |interface advanced search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
