[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #94 from Matt Blenkinsop --- *** Bug 34762 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Fridolin Somers changed: What|Removed |Added Blocks||36012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 [Bug 36012] ERM/Agreements_spec.ts is failing if run too slow (?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #93 from Fridolin Somers --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #92 from Katrin Fischer --- Thanks Matt, follow-up pushed - now we need to wait and see :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #91 from Matt Blenkinsop --- Created attachment 161724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161724=edit Bug 32474: (follow-up): Tell the tests to wait for the intercepted request responses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #90 from Matt Blenkinsop --- Passes locally for me too but I think telling cypress to wait for the intercepted requests for pages two and three may help. I'll add a follow-up patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #89 from Katrin Fischer --- Tests were green when I ran them locally. so maybe something has changed, can you please check on this fail? https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/(root)/Should%20load%20the%20next%20page%20on%20scroll/Infinite_scroll_Should_load_the_next_page_on_scroll/ koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | koha_1 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #88 from Fridolin Somers --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #87 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Katrin Fischer changed: What|Removed |Added Version(s)||24.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #86 from Jonathan Druart --- Created attachment 159407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159407=edit Bug 32474: Store the selected option label It prevents the label to be removed when the selected option is not longer in the item list. Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #85 from Jonathan Druart --- Created attachment 159406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159406=edit Bug 32474: Add cypress tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #84 from Jonathan Druart --- Created attachment 159405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159405=edit Bug 32474: Pass label and identifier Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #83 from Jonathan Druart --- Created attachment 159404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159404=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #82 from Jonathan Druart --- Created attachment 159403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159403=edit Bug 32474: Adjust tests - X-Total-Count Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #81 from Jonathan Druart --- Created attachment 159402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159402=edit Bug 32474: Fix required Signed-off-by: Matt Blenkinsop Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #80 from Jonathan Druart --- Created attachment 159401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159401=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #79 from Jonathan Druart --- Created attachment 159400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159400=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #78 from Jonathan Druart --- Created attachment 159399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159399=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #77 from Jonathan Druart --- Created attachment 159398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159398=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Attachment #156475|0 |1 is obsolete|| Attachment #156476|0 |1 is obsolete|| Attachment #156477|0 |1 is obsolete|| Attachment #156478|0 |1 is obsolete|| Attachment #156479|0 |1 is obsolete|| Attachment #159327|0 |1 is obsolete|| Attachment #159328|0 |1 is obsolete|| Attachment #159329|0 |1 is obsolete|| Attachment #159330|0 |1 is obsolete|| Attachment #159389|0 |1 is obsolete|| Attachment #159395|0 |1 is obsolete|| --- Comment #76 from Jonathan Druart --- Created attachment 159397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159397=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #159386|0 |1 is obsolete|| --- Comment #75 from Matt Blenkinsop --- Created attachment 159395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159395=edit Bug 32474: Store the selected option label It prevents the label to be removed when the selected option is not longer in the item list. Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #159343|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #74 from Matt Blenkinsop --- Created attachment 159389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159389=edit Bug 32474: Add cypress tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #73 from Jonathan Druart --- This last patch is an alternative patch of "Bug 32474: Fix persistence of selections when pagination re-triggers" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #72 from Jonathan Druart --- Created attachment 159386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159386=edit Bug 32474: Store the selected option label It prevents the label to be removed when the selected option is not longer in the item list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #159340|0 |1 is obsolete|| --- Comment #71 from Matt Blenkinsop --- Created attachment 159343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159343=edit Bug 32474: Fix persistence of selections when pagination re-triggers Currently when the select is closed and then re-opens, the pagination is re-triggered which removes the data that the lable is being pulled from for the select. This patch addresses this by keeping the currently selected piece of data and adding it into the re-paginated array of data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #70 from Jonathan Druart --- Still having kind of the same problem. Select "License 3", save Edit Click in then click out => "3" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #69 from Matt Blenkinsop --- Created attachment 159340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159340=edit Bug 32474: Fix persistence of selections when pagination re-triggers Currently when the select is closed and then re-opens, the pagination is re-triggered which removes the data that the lable is being pulled from for the select. This patch addresses this by keeping the currently selected piece of data and adding it into the re-paginated array of data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #68 from Jonathan Druart ---
Found a bug.
I have 500 licenses:
use t::lib::TestBuilder;
my $b = t::lib::TestBuilder->new;
for ( 1 .. 500 ) {
say $_;
$b->build_object({ class => 'Koha::ERM::Licenses', value => {name =>
"License $_"}});
}
Add a new agreement form: /cgi-bin/koha/erm/agreements/add
In the license dropdown, search "license 1"
Select "License 117"
Selected text shows "License 117"
click again the dropdown
=> greyed "117" (the id)
click outside the dropdown
=> Selected text show "117"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #156505|0 |1 is obsolete|| --- Comment #67 from Matt Blenkinsop --- Created attachment 159330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159330=edit Bug 32474: Pass label and identifier Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #156504|0 |1 is obsolete|| --- Comment #66 from Matt Blenkinsop --- Created attachment 159329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159329=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #156482|0 |1 is obsolete|| --- Comment #65 from Matt Blenkinsop --- Created attachment 159328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159328=edit Bug 32474: Adjust tests - X-Total-Count Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #156481|0 |1 is obsolete|| --- Comment #64 from Matt Blenkinsop --- Created attachment 159327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159327=edit Bug 32474: Fix required Signed-off-by: Matt Blenkinsop -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #63 from Matt Blenkinsop --- Signing off Joubu's patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #62 from Jonathan Druart --- This is not very nice, but the tests now pass and it's flexible enough for now IMO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Attachment #156483|0 |1 is obsolete|| --- Comment #61 from Jonathan Druart --- Created attachment 156505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156505=edit Bug 32474: Pass label and identifier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #60 from Jonathan Druart --- Created attachment 156504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156504=edit Bug 32474: Adjust tests We need to use the same data, for instance we had "license name" and "first license name" for the license with license_id=1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #59 from Matt Blenkinsop --- Passing the data to the component from the parent causes issues because we can't guarantee that there is a match for the "label" property in that data object. For example, in the case of agreement licenses, if we pass the agreement license to the select component it doesn't have a "name" property which is used as the label. The "name" property exists in the license which appears to be embedded in that object. We'd need to iterate through all the properties to determine if any of them were embedded objects which might contain the "name" property and we could have a scenario where there are agreements and licenses embedded in the same object and both have the "name" property. This could be very inconsistent and difficult to maintain. To do it we would have to explicitly pass the actual name of the license itself as a prop e.g. :dataToEditLabel="agreement_license.license.name" This is the cleanest method in terms of code but involves passing another parameter each time The only other real option I can think of atm is to fetch it from the API when the component is rendered and add it to the options for the select. This means another API request but this is probably more reliable than passing the data from the parent and will be far easier to maintain when Vue gets used in other parts of Koha. Let me know your thoughts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com Status|ASSIGNED|NEW --- Comment #58 from Jonathan Druart --- To summary the last changes: * The "required" was no longer working - It was not possible to save the form * Cypress tests were failing because we didn't mock correctly the response (X-Total-Count header was missing) * "Pass label and identifier" patch can be dropped if you disagree with it, but I think it's the correct way to fix the last remaining cypress failure (which is about the display of the license's name when we edit an agreement) * Something is wrong with "v-model" vs "modelValue", see previous comment. Handing it back to Matt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #57 from Jonathan Druart --- There is also something else: we are passing "v-model" but InfiniteScrollSelect is expecting "modelValue". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474
--- Comment #56 from Jonathan Druart ---
Created attachment 156483
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156483=edit
Bug 32474: Pass label and identifier
This is a try to fix the last remaining Cypress failure.
The problem is that the label of the existing license does not display,
only its id.
To recreate:
Create a license
Create an agreement and select the license
Edit the agreement
=> The display shows "License: {id}", not its name
This patch is removing the code from created() because I thought it was
the problem originally, and it didn't seem correct to let
InfiniteScrollSelect deal with the "id" and "label" for the different
dataType. But the problem is somewhere else: we have not fetched any
licenses yet from the AgreementLicenses. However we do have the selected
license that we could pass to InfiniteScrollSelect, but that's yet
another param to pass. It feels like there is something better to do
here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #55 from Jonathan Druart --- Created attachment 156482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156482=edit Bug 32474: Adjust tests - X-Total-Count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #54 from Jonathan Druart --- Created attachment 156481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156481=edit Bug 32474: Fix required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED Assignee|matt.blenkinsop@ptfs-europe |jonathan.druart+koha@gmail. |.com|com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #53 from Martin Renvoize --- Oop.. forgot to run the Cypress tests in my eaferness.. running those before switching state. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #52 from Martin Renvoize --- This is working great, so nice to see that bump gone too. Code looks solid, tests are passing and happy.. QA scripts happy, No regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added QA Contact|pedro.amo...@ptfs-europe.co |martin.renvoize@ptfs-europe |m |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added Attachment #156474|0 |1 is obsolete|| --- Comment #51 from Martin Renvoize --- Created attachment 156479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156479=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added Attachment #156473|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize --- Created attachment 156478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156478=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added Attachment #156472|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize --- Created attachment 156477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156477=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added Attachment #156471|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize --- Created attachment 156476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156476=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added Attachment #156470|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize --- Created attachment 156475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156475=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #46 from Martin Renvoize --- It's great to see this has moved.. are you comfortable for me to QA Jonathan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |pedro.amo...@ptfs-europe.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #45 from Jonathan Druart --- Created attachment 156474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156474=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #44 from Jonathan Druart --- Created attachment 156473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156473=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #43 from Jonathan Druart --- Created attachment 156472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156472=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #42 from Jonathan Druart --- Created attachment 156471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156471=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Attachment #153110|0 |1 is obsolete|| Attachment #153111|0 |1 is obsolete|| Attachment #153112|0 |1 is obsolete|| Attachment #153113|0 |1 is obsolete|| Attachment #156410|0 |1 is obsolete|| --- Comment #41 from Jonathan Druart --- Created attachment 156470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156470=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #40 from Jonathan Druart --- Matt, thanks, this is working great now! I remember I played with that scrollTop trick, I must have missed the right place to put it! I think this can go as it now and we will implement it for the other dropdown lists on separate bug reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #39 from Matt Blenkinsop --- I think this fixes the scroll bump - have a play with it and let me know what you think If this behaviour is an improvement then I'll look at rebasing and re-formatting the patches because there has been quite a few versions of this bug now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #38 from Matt Blenkinsop --- Created attachment 156410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156410=edit Bug 32474: Fix scroll bump when new data loads This patch addresses an annoying scroll bump when new data loads. Previously the scrollbar would jump all the way to the top of the selct before resetting, this has now been stopped -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #154094|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #37 from Jonathan Druart --- (In reply to Matt Blenkinsop from comment #36) > Let me know your thoughts, I think this might need to be raised with them Yes, please reach me if you have some time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34762 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #36 from Matt Blenkinsop --- Let me know your thoughts, I think this might need to be raised with them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #35 from Matt Blenkinsop --- I added the example from the docs next to the same select in Agreement licenses. I've added 200 items (not AJAX based) and the behaviour still isn't perfect. There's still a bump on the scrollbar, especially on the first few iterations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #34 from Matt Blenkinsop --- Created attachment 154094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154094=edit Bug 32474: TEST ONLY - DO NOT PUSH This commit adds the example for inifinite scrolling for the vue-select as per the docs to check scroll behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #33 from Jonathan Druart --- I rebased the patch and created bug 32474 to move the getAll changes to a separate bug report. I didn't manage to fix the scrollbar bump, it's quite annoying IMO. I am not sure this is good enough to be pushed. Maybe we should try the example in the guide https://vue-select.org/guide/infinite-scroll.html and see if the problem exists there. If yes, ask them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #32 from Jonathan Druart --- Created attachment 153113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153113=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #31 from Jonathan Druart --- Created attachment 153112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153112=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #30 from Jonathan Druart --- Created attachment 153111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153111=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Attachment #150031|0 |1 is obsolete|| Attachment #150282|0 |1 is obsolete|| Attachment #150283|0 |1 is obsolete|| Attachment #150287|0 |1 is obsolete|| Attachment #150309|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 153110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153110=edit Bug 32474: Infinite scroll v-selects This patch is an example ajax based v-select. The v-select will load the first 20 items and then continue to load paginated sections of 20 items as the user scrolls down. The v-select also offers ajax based searches (unpaginated) and will return to 20 item pagination if the search is cleared. Currently the pagination just works with an Intersection Observer based on scrolling - the main issue with this is that the size of the v-select window changes every time new data is added to the list and this causes the scrollbar to jump before resetting at the correct size. This can be a bit annoying, especially when scrolling quickly. The only way round this will either be to paginate using buttons i.e. (previous/next page) or to limit the data to 20 items at all times and re-paginate when scrolling back up - interested to hear thoughts/suggestions on this or whether anyone has a magic CSS fix that solves it ;) The new v-select is only in one location so far as a test - Agreement Licenses Test plan: 1) You will need to add multiple licenses in order to see the pagination, attached is a script that will create 100 dummy licenses at a time if you wish to use that 2) Once licenses are created, apply patch and run yarn build 3) Navigate to Agreements and click the New Agreement button 4) Scroll down to the Add new license option and click the button 5) The License select is the InfiniteScrollSelect and should display the licenses you have added 6) Open the dropdown and 20 items will be listed 7) Scroll down and as you scroll, more items will be loaded (this can be seen in the Network tab in developer tools) 8) Enter a search query and the results should reflect the search query 9) Delete the search query and the dropdown should return to the first 20 paginated items and pagination will work again when scrolling 10) Try submitting the form with paginate/searched options and the form should still work as intended -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |BLOCKED Depends on||34219 --- Comment #28 from Jonathan Druart --- Working on this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34219 [Bug 34219] getAll not allowing additional parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Bug 32474 depends on bug 33623, which changed state. Bug 33623 Summary: getAll not encoding URL params https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33623 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #27 from Matt Blenkinsop --- It didn't make any difference unfortunately, the key functionality is the same as the v-select so the same issues arose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #150308|0 |1 is obsolete|| --- Comment #25 from Matt Blenkinsop --- Created attachment 150309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150309=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Matt Blenkinsop changed: What|Removed |Added Attachment #150305|0 |1 is obsolete|| --- Comment #24 from Matt Blenkinsop --- Created attachment 150308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150308=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and fixes the "required" attribute Test plan as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #23 from Jonathan Druart --- (In reply to Matt Blenkinsop from comment #22) > (In reply to Jonathan Druart from comment #19) > > Additional notes: > > * It would be interesting to have a delay between the requests > > I've added a setTimeout for 2 seconds between the requests IIRC we are using 250ms in other places. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #22 from Matt Blenkinsop --- (In reply to Jonathan Druart from comment #19) > Additional notes: > * It would be interesting to have a delay between the requests I've added a setTimeout for 2 seconds between the requests > * We are retrieving the 20 first license when clicking the "Add new license" > button and when opening the dropdown list. Seems like there is an extra one, > is it hiding something? This is now fixed, originally I need to pre-fill the data in the component to make the pagination work but I've solved that issue and it now loads the data only when its opened > * About the scrollbar hitting top when scrolling down, did you have a look > at 'more'? https://select2.org/data-sources/ajax#pagination There isn't a similar functionality for v-select, I'm trying a different method using v-autocomplete as a second option. I'll try and finish that before I go on holiday and see if it offers any improvement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #21 from Matt Blenkinsop --- Created attachment 150305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150305=edit Bug 32474: Fix duplicate API call This patch fixes a duplicate API call and improves functionality Test plan as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 Jonathan Druart changed: What|Removed |Added Attachment #150284|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 150287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150287=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #19 from Jonathan Druart --- Additional notes: * It would be interesting to have a delay between the requests * We are retrieving the 20 first license when clicking the "Add new license" button and when opening the dropdown list. Seems like there is an extra one, is it hiding something? * About the scrollbar hitting top when scrolling down, did you have a look at 'more'? https://select2.org/data-sources/ajax#pagination -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #18 from Jonathan Druart --- Created attachment 150284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150284=edit Bug 32474: Properly call getAll To encode q parameter correctly, based on bug 33623 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #17 from Jonathan Druart --- Created attachment 150283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150283=edit Bug 32474: Allow getAll to pass params We may want to extend that to other getAll functions as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32474] Implement infinite scroll in vue-select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32474 --- Comment #16 from Jonathan Druart --- Created attachment 150282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150282=edit Bug 32474: Do not fetch all the licenses Otherwise we are loosing all the point of the pagination! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
