[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |FIXED --- Comment #17 from Lucas Gass --- Merge conflicts with 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #16 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.04 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 147144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147144=edit Bug 32503: Use first cancellation for date ordering Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 147143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147143=edit Bug 32503: (follow-up) Move data-order attributes It looks like the data-order attributes were at the wrong level to me, i.e. not part of the 'td' but instead part of the cell content. This patch moves those data-order attributes where possible and drops the data-type definitions on the headers. However, for the cancellation case, this isn't as clear cut as we may well display more than one cancellation request date in the same cell. For this case I've left Katrins data-type="@data-order" trick. Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 147142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147142=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #145053|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #145052|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What|Removed |Added Attachment #145051|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What|Removed |Added Attachment #144982|0 |1 is obsolete|| --- Comment #11 from Lucas Gass --- Created attachment 145053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145053=edit Bug 32503: Use first cancellation for date ordering Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What|Removed |Added Attachment #144981|0 |1 is obsolete|| --- Comment #10 from Lucas Gass --- Created attachment 145052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145052=edit Bug 32503: (follow-up) Move data-order attributes It looks like the data-order attributes were at the wrong level to me, i.e. not part of the 'td' but instead part of the cell content. This patch moves those data-order attributes where possible and drops the data-type definitions on the headers. However, for the cancellation case, this isn't as clear cut as we may well display more than one cancellation request date in the same cell. For this case I've left Katrins data-type="@data-order" trick. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What|Removed |Added Attachment #144980|0 |1 is obsolete|| --- Comment #9 from Lucas Gass --- Created attachment 145051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145051=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #8 from Martin Renvoize --- Created attachment 144982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144982=edit Bug 32503: Use first cancellation for date ordering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What|Removed |Added Attachment #144886|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 144981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144981=edit Bug 32503: (follow-up) Move data-order attributes It looks like the data-order attributes were at the wrong level to me, i.e. not part of the 'td' but instead part of the cell content. This patch moves those data-order attributes where possible and drops the data-type definitions on the headers. However, for the cancellation case, this isn't as clear cut as we may well display more than one cancellation request date in the same cell. For this case I've left Katrins data-type="@data-order" trick. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What|Removed |Added Attachment #144885|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 144980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144980=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #5 from Martin Renvoize --- My Google foo is weak today.. where did you find the suggestion to use `data-type="@data-sort"` Katrin? I think I spotted the issue with most of the sorting and have removed the data-type definition stuff.. but the cancellation date is more challenging. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #4 from Martin Renvoize --- Created attachment 144886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144886=edit Bug 32503: (follow-up) Move data-order attributes It looks like the data-order attributes were at the wrong level to me, i.e. not part of the 'td' but instead part of the cell content. This patch moves those data-order attributes where possible and drops the data-type definitions on the headers. However, for the cancellation case, this isn't as clear cut as we may well display more than one cancellation request date in the same cell. For this case I've left Katrins data-type="@data-order" trick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Martin Renvoize changed: What|Removed |Added Attachment #144884|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 144885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144885=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Katrin Fischer changed: What|Removed |Added Assignee|katrin.fisc...@bsz-bw.de|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org Status|ASSIGNED|NEW --- Comment #2 from Katrin Fischer --- Usually this works: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference But this was already implemented here: [% reserveloo.waitingdate | $KohaDates %] [% reserveloo.reservedate | $KohaDates %] [% reserveloo.expirationdate | $KohaDates %] And the source shows, it looks like we want it to: 28/12/2022 28/12/2022 03/03/2023 But... the sorting doesn't work. So I googled and came up with this: which seems to do the trick. But as we use data-order a lot and this might affect other pages where this worked before, it definitely needs more investigation/someone more knowledgeable about datatables to have a look here. Tested 3 holds with the following dates: 02/02/2017 03/03/2017 08/02/2017 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 --- Comment #1 from Katrin Fischer --- Created attachment 144884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144884=edit Bug 32503: Fix date sorting for holds awaiting pickup tables This patch is a little experimental, but seems to do the trick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Katrin Fischer changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32503] Holds awaiting pickup doesn't sort dates correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32503 Katrin Fischer changed: What|Removed |Added Summary|waitingreserves: UK format |Holds awaiting pickup |dates not sorting correctly |doesn't sort dates ||correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
