[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2024-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Failed QA   |RESOLVED

--- Comment #16 from Aleisha Amohia  ---
(In reply to Magnus Enger from comment #15)
> 
> If I try to make a fourth loan, I get a different message from SIP2: 
> 
> 11YY2022071116350220250711   
> 163502AOCPL|AA2352980862|AB301334|ASkoha|BON|BIN|   
> 
> 120NUN20240126131908AOCPL|AA2352980862|AB301334|AJA
> companion to Heidegger's Introduction to metaphysics /|AH|AFPatron has
> fines|BLY|
> 
> And the loan is not added to the patron's account. 
> 
> Looks to me like IssuingInProcess works the way it should. Could it have
> been fixed by some other patch? 
> 

I think you're actually right that this is working the way we want. I
misunderstood the preference and thought a patron could KEEP issuing if they
started their SIP session without block-worthy debt, but it makes sense that it
would allow one issue to take them over the limit, then stop.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2024-01-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mag...@libriotech.no

--- Comment #15 from Magnus Enger  ---
I get the same result as David, before applying the patches: 

9300CNkoha|COkoha|CPCPL|
941
11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB31|ACkoha|BON|BIN|
121NNY20240126130933AOCPL|AA2352980862|AB31|AJPerl template
toolkit /|AH|BV2.00|BHUSD|BT06|

The first issue was OK, and 2$ "Rental fee" was added to the patrons's
accounting. 

11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB300498|ACkoha|BON|BIN|
121NNY20240126130948AOCPL|AA2352980862|AB300498|AJCGI
programming with Perl /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06|

The second issue worked OK too, the loan and the "Rental fee" was added, but
the SIP2 response says "Outstanding Fines block issue", which seems weird? The
patron is not over noissuescharge yet, and the issue was not blocked. 

11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB312392|ACkoha|BON|BIN|
121NNY20240126131027AOCPL|AA2352980862|AB312392|AJLady Susan ;
The Watsons ; Sanditon /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06|

Same SIP2 message: "Outstanding Fines block issue", but the loan was made to
the patron and the rental fee was added, bringing the patron above the
noissuescharge limit. 

If I try to make a fourth loan, I get a different message from SIP2: 

11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB301334|ASkoha|BON|BIN|   
120NUN20240126131908AOCPL|AA2352980862|AB301334|AJA companion
to Heidegger's Introduction to metaphysics /|AH|AFPatron has fines|BLY|

And the loan is not added to the patron's account. 

Looks to me like IssuingInProcess works the way it should. Could it have been
fixed by some other patch? 

But the AF-messages of "Outstanding Fines block issue" when the patron is below
the noissuescharge limit do seem weird.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #14 from David Nind  ---
I've tested again, but I can't replicate the issue before the patch is applied
- the behavour before and after the patch is applied seems the same to me. 

Not sure what I've done wrong here


Testing notes (using KTD):

1. For step 3, this is how I set things up to test:

   - Edited SIPconfig.xml so that the koha institution is "CPL" instead of
"kohalibrary"
   - Restarted the SIP server: koha-sip --restart -v kohadev
   - Installed telnet in KTD: apt-get install telnet
   - Telnet to 6001: telnet 127.0.0.1 6001
   - Send this command: 9300CNkoha|COkoha|CPCPL|
   - Commands to checkout items:*!
  11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB31|ACkoha|BON|BIN|
  11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB300498|ACkoha|BON|BIN|
  11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB312392|ACkoha|BON|BIN|
   - To exit: press enter

* Initial patron used was Bobbie: 2352980862 
  After the patches were applied, the patron used was Henry: 2352935676
  The patron number is entered after |AA

! Need to change the items to checkout (after |AB), or check them back in so
that they are available


Output and results before the patch was applied
~~~

kohadev-koha@kohadevbox:koha(bz32602)$ telnet 127.0.0.1 6001
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
9300CNkoha|COkoha|CPCPL|
941
11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB31|ACkoha|BON|BIN|
121NNY20231023234841AOCPL|AA2352980862|AB31|AJPerl template
toolkit /|AH|BV2.00|BHUSD|BT06|
11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB300498|ACkoha|BON|BIN
121NNY20231023234859AOCPL|AA2352980862|AB300498|AJCGI
programming with Perl /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06|
11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB312392|ACkoha|BON|BIN|
121NNY20231023234924AOCPL|AA2352980862|AB312392|AJLady Susan ;
The Watsons ; Sanditon /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06|

The three items were issued to Bobbie, with no issuing blocked.

The tests pass: prove t/db_dependent/SIP/Transaction.t


Output and results after the patch was applied
~~~

kohadev-koha@kohadevbox:koha(bz32602)$ telnet 127.0.0.1 6001
Trying 127.0.0.1...
Connected to 127.0.0.1.
Escape character is '^]'.
9300CNkoha|COkoha|CPCPL|
941
11YY2022071116350220250711   
163502AOCPL|AA2352935676|AB31|ACkoha|BON|BIN|
121NNY20231024000235AOCPL|AA2352935676|AB31|AJPerl template
toolkit /|AH|BV2.00|BHUSD|BT06|
11YY2022071116350220250711   
163502AOCPL|AA2352935676|AB300498|ACkoha|BON|BIN|
121NNY20231024000302AOCPL|AA2352935676|AB300498|AJCGI
programming with Perl /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06|
11YY2022071116350220250711   
163502AOCPL|AA2352935676|AB312392|ACkoha|BON|BIN|
121NNY20231024000328AOCPL|AA2352935676|AB312392|AJLady Susan ;
The Watsons ; Sanditon /|AH|AFOutstanding Fines block issue|BV2.00|BHUSD|BT06|

The three items were issued to Henry, with no issuing blocked.

The tests pass: prove t/db_dependent/SIP/Transaction.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Severity|enhancement |normal
  Text to go in the||This fix ensures that the
  release notes||IssuingInProcess system
   ||preference is considered
   ||when circulating via SIP.
   ||If the system preference is
   ||enabled, checkouts via SIP
   ||should be allowed if the
   ||patron's fines are not
   ||exceeding the
   ||noissuescharge system
   ||preference at the start of
   ||the transaction, and the
   ||AllFinesNeedOverride system
   ||preference is disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #156809|0   |1
is obsolete||

--- Comment #13 from Aleisha Amohia  ---
Created attachment 157297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157297=edit
Bug 32602: Unit tests

Test plan:
1. sudo koha-shell 
2. prove -v t/db_dependent/SIP/Transaction.t
3. Confirm all tests pass

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #156808|0   |1
is obsolete||

--- Comment #12 from Aleisha Amohia  ---
Created attachment 157296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157296=edit
Bug 32602: SIP server doesn't respect IssuingInProcess system preference

The system preference 'IssuingInProcess' when set to "Don't prevent" means
patrons will still be allowed to issue items if their rental charge took the
patron over the noissuescharge system preference.

However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess'
equals "Don't prevent") when they try to issue items that take them over the
noissuecharge amount.

Test plan:
1. Configure the BK item type to have a rental charge of $2
2. Configure system preferences:
- noissuescharge = $5
- IssuingInProcess = Don't prevent
3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd
item you
cannot issue the third item

4. Apply patches
5. Restart your SIP2 server
6. From a SIP2 device issue 3 BK items to a different patron and notice you can
issue all
three items

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|alexbuck...@catalyst.net.nz |alei...@catalyst.net.nz
 CC||alei...@catalyst.net.nz
 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #149153|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 156809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156809=edit
Bug 32602: Unit tests

Test plan:
1. sudo koha-shell 
2. prove -v t/db_dependent/SIP/Transaction.t
3. Confirm all tests pass

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #149152|0   |1
is obsolete||

--- Comment #10 from Aleisha Amohia  ---
Created attachment 156808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156808=edit
Bug 32602: SIP server doesn't respect IssuingInProcess system preference

The system preference 'IssuingInProcess' when set to "Don't prevent" means
patrons will still be allowed to issue items if their rental charge took the
patron over the noissuescharge system preference.

However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess'
equals "Don't prevent") when they try to issue items that take them over the
noissuecharge amount.

Test plan:
1. Configure the BK item type to have a rental charge of $2
2. Configure system preferences:
- noissuescharge = $5
- IssuingInProcess = Don't prevent
3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd
item you
cannot issue the third item

4. Apply patches
5. Restart your SIP2 server
6. From a SIP2 device issue 3 BK items to a different patron and notice you can
issue all
three items

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #9 from David Nind  ---
Just checking whether the status for this bug should still be assigned or
changed to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #8 from Alex Buckley  ---
Created attachment 149153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149153=edit
Bug 32602: Unit tests

Test plan:
1. sudo koha-shell 
2. prove -v t/db_dependent/SIP/Transaction.t
3. Confirm all tests pass

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #7 from Alex Buckley  ---
Created attachment 149152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149152=edit
Bug 32602: SIP server doesn't respect IssuingInProcess system preference

The system preference 'IssuingInProcess' when set to "Don't prevent" means
patrons will still be allowed to issue items if their rental charge took the
patron over the noissuescharge system preference.

However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess'
equals "Don't prevent") when they try to issue items that take them over the
noissuecharge amount.

Test plan:
1. Configure the BK item type to have a rental charge of $2
2. Configure system preferences:
- noissuescharge = $5
- IssuingInProcess = Don't prevent
3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd
item you
cannot issue the third item

4. Apply patches
5. Restart your SIP2 server
6. From a SIP2 device issue 3 BK items to a different patron and notice you can
issue all
three items

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Alex Buckley  changed:

   What|Removed |Added

 Attachment #145249|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Alex Buckley  changed:

   What|Removed |Added

 Attachment #145170|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #6 from David Nind  ---
(In reply to David Nind from comment #3)
> The tests failed for me after apply the patch, restarting everything
> (including the SIP server), and after running through the test plan:

However, the tests pass if I just apply the patch, restart everything
(including the SIP server) - without setting the system preferences and
configuration in steps 1 and 2:

prove t/db_dependent/SIP/Transaction.t
t/db_dependent/SIP/Transaction.t .. ok 
All tests successful.
Files=1, Tests=16,  7 wallclock secs ( 0.04 usr  0.01 sys +  5.07 cusr  0.79
csys =  5.91 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #5 from Alex Buckley  ---
Thanks for testing David. I will take this back and have a go at fixing it up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #4 from David Nind  ---
Testing notes (using KTD):

1. For step 3, this is how I set things up to test:

   - Edited SIPconfig.xml so that the koha institution is "CPL" instead of
"kohalibrary"
   - Restarted the SIP server: koha-sip --restart -v kohadev
   - Installed telnet in KTD: apt-get install telnet
   - Telnet to 6001: telnet 6001
   - Send this command: 9300CNkoha|COkoha|CPCPL|
   - Commands to checkout items:*!
  11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB31|ACkoha|BON|BIN|
  11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB300498|ACkoha|BON|BIN|
  11YY2022071116350220250711   
163502AOCPL|AA2352980862|AB312392|ACkoha|BON|BIN|
   - To exit: press enter

* Initial patron used was Henry: 2352935676
  After the patches were applied, the patron used was Bobbie: 2352980862
  The patron number is entered after |AA

! Need to change the items to checkout (after |AB), or check them back in so
that they are available

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
The tests failed for me after apply the patch, restarting everything (including
the SIP server), and after running through the test plan:

prove t/db_dependent/SIP/Transaction.t
t/db_dependent/SIP/Transaction.t .. 9/16 
#   Failed test 'Got correct fines screen message'
#   at t/db_dependent/SIP/Transaction.t line 496.
#  got: ''
# expected: 'Patron has fines'
# Looks like you failed 1 test of 5.
t/db_dependent/SIP/Transaction.t .. 10/16 
#   Failed test 'do_checkout_with_patron_blocked'
#   at t/db_dependent/SIP/Transaction.t line 534.
t/db_dependent/SIP/Transaction.t .. 16/16 # Looks like you failed 1 test of 16.
t/db_dependent/SIP/Transaction.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/16 subtests 

Test Summary Report
---
t/db_dependent/SIP/Transaction.t (Wstat: 256 Tests: 16 Failed: 1)
  Failed test:  10
  Non-zero exit status: 1
Files=1, Tests=16,  8 wallclock secs ( 0.04 usr  0.01 sys +  5.13 cusr  0.82
csys =  6.00 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #2 from Alex Buckley  ---
Created attachment 145249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145249=edit
Bug 32602: Unit tests

Test plan:
1. sudo koha-shell 
2. prove -v t/db_dependent/SIP/Transaction.t
3. Confirm all tests pass

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

Alex Buckley  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32602] SIP Server doesn't respect IssuingInProcess system preference

2023-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32602

--- Comment #1 from Alex Buckley  ---
Created attachment 145170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145170=edit
Bug 32602: SIP server doesn't respect IssuingInProcess system preference

The system preference 'IssuingInProcess' when set to "Don't prevent" means
patrons will still be allowed to issue items if their rental charge took the
patron over the noissuescharge system preference.

However, SIP returns that a patron is fine blocked (even if 'IssuingInProcess'
equals "Don't prevent") when they try to issue items that take them over the
noissuecharge amount.

Test plan:
1. Configure the BK item type to have a rental charge of $2
2. Configure system preferences:
- noissuescharge = $5
- IssuingInProcess = Don't prevent
3. From a SIP2 device issue 3 BK items to a borrower and notice after the 2nd
item you
cannot issue the third item

4. Apply patches
5. Restart your SIP2 server
6. From a SIP2 device issue 3 BK items to a different patron and notice you can
issue all
three items

Sponsored-by: Horowhenua District Council, New Zealand

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/