[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #42 from Lucas Gass --- Not needed for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed, | |rel_22_11_candidate | --- Comment #41 from Martin Renvoize --- Final follow-up pushed to 22.11.x for 22.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #40 from Martin Renvoize --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Martin Renvoize changed: What|Removed |Added Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_11_candidate --- Comment #39 from Jonathan Druart --- (In reply to Jonathan Druart from comment #36) > Created attachment 148507 [details] [review] > Bug 32923: Allow to embed user_roles for agreements Patch pushed to master for 23.05. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added CC||agustinmoy...@theke.io --- Comment #38 from Jonathan Druart --- *** Bug 33306 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --- Comment #37 from Jonathan Druart --- Is this still in time for 22.11.04? Or should I open a new bug? The agreement list table is not displayed correctly without this last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #36 from Jonathan Druart --- Created attachment 148507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148507=edit Bug 32923: Allow to embed user_roles for agreements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Martin Renvoize changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #35 from Martin Renvoize --- Final follow-up also pushed to 22.11.x for 22.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Martin Renvoize changed: What|Removed |Added Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #34 from Pedro Amorim --- Adding some thougths here for discussion, please discard if it doesn't make sense: Changes to biblios_item_groups.yaml, checkouts.yaml and items.yaml in attachment 147292 may make sense to backport to 22.05, but that attachment also contains ERM changes that will likely not apply nicely. Other attachments in this bug are exclusive to ERM so don't need to be considered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #33 from Pedro Amorim --- Created attachment 148413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148413=edit Bug 32923: Fix licenses spec Bug 32713 is now validating embed and brought this flaw to light. Before this patch, listing licenses on ERM would result in a 400 bad request -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #32 from Matt Blenkinsop --- Backported to 22.11.x, keeping additonal_work_required flag for 22.05 maintainer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Matt Blenkinsop changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #31 from Matt Blenkinsop --- Follow-up noted, added to queue for backporting to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #30 from Tomás Cohen Arazi --- Follow-up pushed. Thanks Jonathan. Keeping the additional_work_needed so stable is aware. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #29 from Jonathan Druart --- Created attachment 148349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148349=edit Bug 32923: (follow-up) Fix x-koha-embed from EHoldings/*/* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED --- Comment #28 from Lucas Gass --- Not backporting to 22.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Bug 32923 depends on bug 32898, which changed state. Bug 32898 Summary: Cypress tests are failing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #27 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #26 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Matt Blenkinsop changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|23.05.00|23.05.00,22.11.04 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #25 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923
Tomás Cohen Arazi changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--- Comment #24 from Tomás Cohen Arazi ---
After an exchange with the Mojolicious::Plugin::OpenAPI maintainer and
exchanging pull requests, the conclusion is:
- Validation is not supposed to happen twice
- The validation step is expected to normalize the ->params and ->headers in a
specific way, and we shouldn't be relying on the $c->validation->output
structure as it subject to change and at some point they thought of removing
it. Once validation happens we need to use ->params and ->headers.
- When valid_input is called, the header effectively gets converted into an
array and expecting it to still be a CSv string will lead to problems as we've
seen.
- When collectionFormat is used, we should be using multi, the maintainer
really dislikes the 'csv' implementation.
- I would've expected the plugin to provide us a consistent and usable way to
access parameters through ->validation->output and leave the params untouched,
but this is not the case, by design. And is not going to change.
Having said all that, I agree with this patchset
QA note: I have doubts about the real need for this API spec that points to an
intermediate controller that later calls the *real controller*. I would've just
duplicated the endpoint spec, hardcoding 'ebsco' and 'local' and calling the
appropriate method. The only reason I would accept to keep this, is because you
(ERM devs) might be thinking of extending this with plugins that implement
provider-specific implementations, along the lines of this mocked code:
```perl
sub get {
my $c = shift->openapi->valid_input or return;
my @plugins = GetPlugins({ method => 'erm_packages' });
my $provider = $c->validation->param('provider');
if ( $provider eq 'ebsco' ) {
return Koha::REST::V1::ERM::EHoldings::Packages::EBSCO::get($c,
$validated_output);
} elsif (@plugins) {
foreach my $plugin (@plugins) {
if ( $provide eq $plugin->erm_provider ) {
return $plugin->erm_package_controller::get($c);
}
}
}
return Koha::REST::V1::ERM::EHoldings::Packages::Local::get($c,
$validated_output);
}
```
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Tomás Cohen Arazi changed: What|Removed |Added URL||https://github.com/jhthorse ||n/mojolicious-plugin-openap ||i/pull/243/files Status|Passed QA |BLOCKED --- Comment #23 from Tomás Cohen Arazi --- Ok, I agree with the patches, generally. I'd like a separate bug for the non-ERM fixes to the specs, so it can be backported more easily. Regarding the last patch, I've added a regression test patch for Mojolicious::Plugin::OpenAPI to highlight the issue we are making a workaround for. Let's see what the maintainer says and then decide how to move forward with this. Deadline for the rmaint answer is next monday, so we all know this is to be pushed anyway and nothing blocks the dependencies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > I would not backport these patches, they can introduce hard to catch > side-effects. Having reviewed it, I think this needs to be backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923
--- Comment #21 from Nick Clemens ---
Created attachment 147295
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147295=edit
Bug 32923: Fix x-koha-embed from EHoldings/*/*
We were validating twice the input and it broke the x-koha-embed header.
I don't really know what's happening, but here is how to recreate the
problem:
1. Edit Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm
2. Add the following lines in Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm, in
the list method
warn $c->req->headers->header('x-koha-embed');
3. curl -v -s -u koha:koha --request GET
http://kohadev-intra.mydnsname.org:8081/api/v1/erm/eholdings/ebsco/packages
--header "x-koha-embed: resources+count,vendor"
=> There is no vendor in the response
=> The warn displays "resources+count"
If you apply this patch you will notice that "vendor" is part of the
response and the warn displays "resources+count, vendor"
Signed-off-by: Pedro Amorim
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #20 from Nick Clemens --- Created attachment 147294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147294=edit Bug 32923: Add 'vendor' for local packages Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #19 from Nick Clemens --- Created attachment 147293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147293=edit Bug 32923: Some fixes in ERM specs Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Nick Clemens changed: What|Removed |Added Attachment #146836|0 |1 is obsolete|| Attachment #146837|0 |1 is obsolete|| Attachment #146838|0 |1 is obsolete|| Attachment #146839|0 |1 is obsolete|| --- Comment #18 from Nick Clemens --- Created attachment 147292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147292=edit Bug 32923: Fix new occurrences of x-koha-embed at top level Signed-off-by: Pedro Amorim Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923
Pedro Amorim changed:
What|Removed |Added
Attachment #146633|0 |1
is obsolete||
--- Comment #17 from Pedro Amorim ---
Created attachment 146839
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146839=edit
Bug 32923: Fix x-koha-embed from EHoldings/*/*
We were validating twice the input and it broke the x-koha-embed header.
I don't really know what's happening, but here is how to recreate the
problem:
1. Edit Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm
2. Add the following lines in Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm, in
the list method
warn $c->req->headers->header('x-koha-embed');
3. curl -v -s -u koha:koha --request GET
http://kohadev-intra.mydnsname.org:8081/api/v1/erm/eholdings/ebsco/packages
--header "x-koha-embed: resources+count,vendor"
=> There is no vendor in the response
=> The warn displays "resources+count"
If you apply this patch you will notice that "vendor" is part of the
response and the warn displays "resources+count, vendor"
Signed-off-by: Pedro Amorim
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Attachment #146632|0 |1 is obsolete|| --- Comment #16 from Pedro Amorim --- Created attachment 146838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146838=edit Bug 32923: Add 'vendor' for local packages Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Attachment #146425|0 |1 is obsolete|| --- Comment #15 from Pedro Amorim --- Created attachment 146837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146837=edit Bug 32923: Some fixes in ERM specs Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Attachment #146421|0 |1 is obsolete|| --- Comment #14 from Pedro Amorim --- Created attachment 146836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146836=edit Bug 32923: Fix new occurrences of x-koha-embed at top level Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Attachment #146749|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Attachment #146748|0 |1 is obsolete|| --- Comment #13 from Pedro Amorim --- Created attachment 146749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146749=edit Bug 32898: Remove unecessary async/await myFetch awaits already Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 --- Comment #12 from Pedro Amorim --- Created attachment 146748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146748=edit Bug 32898: Remove unecessary async/await myFetch awaits already Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923
Pedro Amorim changed:
What|Removed |Added
CC||pedro.amo...@ptfs-europe.co
||m
--- Comment #11 from Pedro Amorim ---
(In reply to Jonathan Druart from comment #10)
> Created attachment 146633 [details] [review]
> Bug 32923: Fix x-koha-embed from EHoldings/*/*
>
> We were validating twice the input and it broke the x-koha-embed header.
> I don't really know what's happening, but here is how to recreate the
> problem:
> 1. Edit Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm
> 2. Add the following lines in Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm,
> in the list method
> warn $c->req->headers->header('x-koha-embed');
> 3. curl -v -s -u koha:koha --request GET
> http://kohadev-intra.mydnsname.org:8081/api/v1/erm/eholdings/ebsco/packages
> --header "x-koha-embed: resources+count,vendor"
>
> => There is no vendor in the response
> => The warn displays "resources+count"
>
> If you apply this patch you will notice that "vendor" is part of the
> response and the warn displays "resources+count, vendor"
Did a lot of testing with this but openapi->valid_input in EBSCO.pm is getting
rid of all arguments in the x-koha-embed header except the first one.
Lot of trial and error in erm_eholdings_packages.yaml also came up with no
breakthrough.
Found this fix related to default collectionFormat in version 5.06 (we're using
5.05) so upgraded to Mojolicious::Plugin::OpenAPI to 5.08 but result is the
same:
https://github.com/jhthorsen/mojolicious-plugin-openapi/commit/c972fdd02a05dc635257715a4b8c541b218e2817
This weird behaviour seems to be caused by mojo. The code implemented to work
around this is working as intended.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Blocks||32806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32806 [Bug 32806] Some Vue files need to be moved for better reusability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Depends on||32898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32898 [Bug 32898] Cypress tests are failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923
--- Comment #10 from Jonathan Druart ---
Created attachment 146633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146633=edit
Bug 32923: Fix x-koha-embed from EHoldings/*/*
We were validating twice the input and it broke the x-koha-embed header.
I don't really know what's happening, but here is how to recreate the
problem:
1. Edit Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm
2. Add the following lines in Koha/REST/V1/ERM/EHoldings/Packages/EBSCO.pm, in
the list method
warn $c->req->headers->header('x-koha-embed');
3. curl -v -s -u koha:koha --request GET
http://kohadev-intra.mydnsname.org:8081/api/v1/erm/eholdings/ebsco/packages
--header "x-koha-embed: resources+count,vendor"
=> There is no vendor in the response
=> The warn displays "resources+count"
If you apply this patch you will notice that "vendor" is part of the
response and the warn displays "resources+count, vendor"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Jonathan Druart changed: What|Removed |Added Attachment #146443|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 146632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146632=edit Bug 32923: Add 'vendor' for local packages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32923] x-koha-embed must a header of collectionFormat csv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32923 Martin Renvoize changed: What|Removed |Added Summary|x-koha-embed must be an |x-koha-embed must a header |enum|of collectionFormat csv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
