[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #9 from Pedro Amorim --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Pedro Amorim changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|23.11.00,23.05.03 |23.11.00,23.05.03,22.11.09 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|23.11.00|23.11.00,23.05.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 23.05.x for 23.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #7 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Katrin Fischer changed: What|Removed |Added Attachment #153927|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 154056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154056&action=edit Bug 33140: Use facet label value for mouseover text on facet removal link This patch updates the facets includes in both the staff interface and OPAC so that the title attribute on "remove" links uses the full name rather than the code of the facet. So, library name instead of branchcode, collection code description instead of authorized value code. To test, apply the patch and perform a search in the staff interface. - Click a facet in the left-hand sidebar which will return more than one result. - On the reloaded page there should be a link next to that facet: [X]. Hovering your mouse over it should show "Remove facet [facet name]" e.g. "Remove facet Centerville" instead of "Remove facet CPL" - Test on library facets, item type facets, and collection code facets. - Perform the same test in the OPAC. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Assignee|koha-b...@lists.koha-commun |andreas.jons...@kreablo.se |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #5 from Owen Leonard --- I corrected the commit message and added the test plan. Everything worked as it should in my tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Owen Leonard changed: What|Removed |Added Attachment #147773|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 153927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153927&action=edit Bug 33140: Use facet label value for mouseover text on facet removal link This patch updates the facets includes in both the staff interface and OPAC so that the title attribute on "remove" links uses the full name rather than the code of the facet. So, library name instead of branchcode, collection code description instead of authorized value code. To test, apply the patch and perform a search in the staff interface. - Click a facet in the left-hand sidebar which will return more than one result. - On the reloaded page there should be a link next to that facet: [X]. Hovering your mouse over it should show "Remove facet [facet name]" e.g. "Remove facet Centerville" instead of "Remove facet CPL" - Test on library facets, item type facets, and collection code facets. - Perform the same test in the OPAC. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||lu...@bywatersolutions.com --- Comment #3 from Lucas Gass --- Andreas, This one also looks like a good patch but lacks the proper commit message: * Commit title does not start with 'Bug X: ' - 224750a113 If you can fix this I would be happy to sign-off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Andreas Jonsson changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33139 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 Andreas Jonsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #2 from Andreas Jonsson --- Test plan: * Follow the test plan in bug 33139 but additionally add this patch * Observe the mouseover text when hovering over the facet removal button of the E-resource facet (without patch the text will be "remove facet true/false") -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33140] Use facet label value in mouseover title attribute of facet removal link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33140 --- Comment #1 from Andreas Jonsson --- Created attachment 147773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147773&action=edit Bug 33140 Use facet label value for mouseover text on facet removal link -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/