[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #19 from Lucas Gass --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Jacob O'Mara changed: What|Removed |Added CC||jacob.om...@ptfs-europe.com --- Comment #18 from Jacob O'Mara --- Hi Katrin, sorry this message slipped through my radar!!! I could be being really very stupid but was the dependency not pushed in 22.11.03? I'm probably missing something really obvious! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #17 from Katrin Fischer --- (In reply to Jacob O'Mara from comment #16) > Nice work, thanks everyone! > > Pushed to 22.11.x for the next release. Hi Jacob, the dependency is not in 22.11 - not sure if this can work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #16 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Jacob O'Mara changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.05 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #14 from Heather --- > You forgot a so line. Will add it now. Thank you, Marcel! I'm still very much at newbie at this! --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added Attachment #148640|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 148642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148642=edit Bug 33160: (QA follow-up) Adjust condition on biblio object If it is undefined, there is no biblionumber. If it is, we can safely assume that it has a biblionumber. Which is the case for most biblio records, lol. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added Attachment #148639|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 148641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148641=edit Bug 33160: Use hostinfo to display title information when 773$w is empty When a 773 entry is not linked to another record using 773$w or by using Easyanalytics, the title information would not display. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Look at the cart brief and full view in staff and OPAC. 9. Verify the In: source information only displays for the first record. 10. Apply patch 11. Veriy the In: source information now displays for both records on all 4 pages. Signed-off-by: Heather Hernandez Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #11 from Marcel de Rooy --- (In reply to Heather from comment #2) > It works! Step 3 had to be a little different, because there's no "Edit > > Add child record"--one has to "New > New child record." Also, between step > 4 & 5 one has to edit the defaul framework to make 773 $g visible in the > editor. > > Cheerio! > --h2 You forgot a so line. Will add it now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #10 from Marcel de Rooy --- Please open a new report for slight POD adjustments and testing hostinfo. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #9 from Marcel de Rooy --- Created attachment 148640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148640=edit Bug 33160: (QA follow-up) Adjust condition on biblio object If it is undefined, there is no biblionumber. If it is, we can safely assume that it has a biblionumber. Which is the case for most biblio records, lol. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added Attachment #147867|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 148639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148639=edit Bug 33160: Use hostinfo to display title information when 773$w is empty When a 773 entry is not linked to another record using 773$w or by using Easyanalytics, the title information would not display. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Look at the cart brief and full view in staff and OPAC. 9. Verify the In: source information only displays for the first record. 10. Apply patch 11. Veriy the In: source information now displays for both records on all 4 pages. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #7 from Marcel de Rooy --- Same here @@ -244,7 +244,7 @@ [% IF BIBLIO_RESULT.HOSTITEMENTRIES.biblionumber %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #6 from Marcel de Rooy --- basket.tt -[% IF BIBLIO_RESULT.HOSTITEMENTRIES %] +[% IF BIBLIO_RESULT.HOSTITEMENTRIES || BIBLIO_RESULT.HOSTINFO %] In: [% IF BIBLIO_RESULT.HOSTITEMENTRIES.biblionumber %] The change in the condition makes the next condition vulnerable. Since HOSTITEMENTRIES could be undefined now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160
--- Comment #5 from Marcel de Rooy ---
+my ( $host, $relatedparts, $hostinfo ) = $biblio->get_marc_host;
$dat->{HOSTITEMENTRIES} = $host;
HOSTITEMENTRIES is quite obscure name for a Koha::Biblio object !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #4 from Marcel de Rooy --- Looking at what happened in get_marc_host, I must say that the POD has not been fully updated and that the unit test does not even include this new hostinfo return. Thats really bad to pass thru QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #3 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Heather changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #2 from Heather --- It works! Step 3 had to be a little different, because there's no "Edit > Add child record"--one has to "New > New child record." Also, between step 4 & 5 one has to edit the defaul framework to make 773 $g visible in the editor. Cheerio! --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Katrin Fischer changed: What|Removed |Added CC||heather_hernan...@nps.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 --- Comment #1 from Katrin Fischer --- Created attachment 147867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147867=edit Bug 33160: Use hostinfo to display title information when 773$w is empty When a 773 entry is not linked to another record using 773$w or by using Easyanalytics, the title information would not display. To test: 1. Activate the UseControlNumber system preference 2. Search for a record and make sure it has 001 set to some value. 3. Use Edit > Add child record to create an analytical record from this record. 4. Make sure 773$w was filled in and finish by adding any mandatory fields, save. 5. Add this record to your cart. Also add a 773$g with the pages or similar. 6. Create another record with 773$t and $g, but without $w. 7. Also add this record to your cart. 8. Look at the cart brief and full view in staff and OPAC. 9. Verify the In: source information only displays for the first record. 10. Apply patch 11. Veriy the In: source information now displays for both records on all 4 pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33160] Make sure 773 (host item entry) displays in the cart when not linked by $w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33160 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de Depends on||16522 Severity|enhancement |trivial Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
