[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Bug 33260 depends on bug 33478, which changed state. Bug 33478 Summary: Customise the format of notices when they are printed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added CC|martin.renvoize@ptfs-europe | |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166373|0 |1 is obsolete|| --- Comment #122 from Aleisha Amohia --- Created attachment 167920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167920&action=edit Bug 33260: (QA follow-up) Add missing page-section Add the missing page-section div to the new page and include required messages.inc include as is now standard. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166372|0 |1 is obsolete|| --- Comment #121 from Aleisha Amohia --- Created attachment 167919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167919&action=edit Bug 33260: (QA follow-up) Safely continue for non-templated notices The 'letter_id'/'letter_code' field in the message queue table is a NULLable foreign key as is indeed NULL in certain circustances. We need to gracefully degrade when there isn't a template for the notice in question. Tihs patch uses the newly introduced 'template' accessor and when that returns undefined we pass 'style' as an empty string. We also use the 'is_html' method introduced in bug 35285 to set the html flag. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166371|0 |1 is obsolete|| --- Comment #120 from Aleisha Amohia --- Created attachment 167918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167918&action=edit Bug 33260: (QA follow-up) Add template relation This patch add the 'template' relation to the Koha::Notice::Message object to fetch the Koha::Notice::Template object that may have been used to generate the notice. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166370|0 |1 is obsolete|| --- Comment #119 from Aleisha Amohia --- Created attachment 167917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167917&action=edit Bug 33260: Tidy unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166369|0 |1 is obsolete|| --- Comment #118 from Aleisha Amohia --- Created attachment 167916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167916&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166368|0 |1 is obsolete|| --- Comment #117 from Aleisha Amohia --- Created attachment 167915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167915&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166367|0 |1 is obsolete|| --- Comment #116 from Aleisha Amohia --- Created attachment 167914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167914&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166366|0 |1 is obsolete|| --- Comment #115 from Aleisha Amohia --- Created attachment 167913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167913&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166365|0 |1 is obsolete|| --- Comment #114 from Aleisha Amohia --- Created attachment 167912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167912&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166364|0 |1 is obsolete|| --- Comment #113 from Aleisha Amohia --- Created attachment 167911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167911&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166363|0 |1 is obsolete|| --- Comment #112 from Aleisha Amohia --- Created attachment 167910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167910&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #166362|0 |1 is obsolete|| --- Comment #111 from Aleisha Amohia --- Created attachment 167909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167909&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Sylvain Def. changed: What|Removed |Added Keywords||Sandbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Sylvain Def. changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||s.defla...@ville-caluire.fr --- Comment #110 from Sylvain Def. --- CONFLICT (content): Merge conflict in t/db_dependent/Letters.t error: Failed to merge in the changes. Patch failed at 0001 Bug 33260: Add a patron getter method to Koha::Notice::Message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Bug 33260 depends on bug 35285, which changed state. Bug 35285 Summary: Centralise notice content wrapping for HTML output https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #109 from Martin Renvoize --- I've burnt through too much time here already but still don't feel this is quite ready and it's too close to hard feature freeze for this cycle in my opinion. # Notices management page * I don't understand why we start with a patron search up front and centre.. we already have a powerful patron search and replicating that code here seems to detract from the main purpose of the tool which is to display a list of notices filtered by things other than patron. * Once a notice search is performed, I think the table column order should match that from the synonymous page in the patron record. # Patron notices page # Both * Should print really appear for all transport types and message statuses? * Should print really print an email notice using the email template, especially when there might be a print template designed specifically for print? * Should we really be using the 'Slip' printing code rather than 'Notice' printing here? * Should the permissions not reflect that they expose access to printing functionality rather than view functionality? * I'm not sure that calling the print dialog should set the notice to 'sent'.. you can easily cancel before the print actually happens and so the updated status is a misrepresentation. With all those open questions and ongoing work elsewhere to try and clean up the notices and slips code I feel this still needs more work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #108 from Martin Renvoize --- Created attachment 166373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166373&action=edit Bug 33260: (QA follow-up) Add missing page-section Add the missing page-section div to the new page and include required messages.inc include as is now standard. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166345|0 |1 is obsolete|| --- Comment #107 from Martin Renvoize --- Created attachment 166372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166372&action=edit Bug 33260: (QA follow-up) Safely continue for non-templated notices The 'letter_id'/'letter_code' field in the message queue table is a NULLable foreign key as is indeed NULL in certain circustances. We need to gracefully degrade when there isn't a template for the notice in question. Tihs patch uses the newly introduced 'template' accessor and when that returns undefined we pass 'style' as an empty string. We also use the 'is_html' method introduced in bug 35285 to set the html flag. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166344|0 |1 is obsolete|| --- Comment #106 from Martin Renvoize --- Created attachment 166371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166371&action=edit Bug 33260: (QA follow-up) Add template relation This patch add the 'template' relation to the Koha::Notice::Message object to fetch the Koha::Notice::Template object that may have been used to generate the notice. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166343|0 |1 is obsolete|| --- Comment #105 from Martin Renvoize --- Created attachment 166370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166370&action=edit Bug 33260: Tidy unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166342|0 |1 is obsolete|| --- Comment #104 from Martin Renvoize --- Created attachment 166369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166369&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166341|0 |1 is obsolete|| --- Comment #103 from Martin Renvoize --- Created attachment 166368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166368&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166340|0 |1 is obsolete|| --- Comment #102 from Martin Renvoize --- Created attachment 166367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166367&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166339|0 |1 is obsolete|| --- Comment #101 from Martin Renvoize --- Created attachment 166366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166366&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166338|0 |1 is obsolete|| --- Comment #100 from Martin Renvoize --- Created attachment 166365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166365&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166337|0 |1 is obsolete|| --- Comment #99 from Martin Renvoize --- Created attachment 166364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166364&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166336|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 166363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166363&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166335|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 166362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166362&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #96 from Martin Renvoize --- Now I'm asking if the choice of columns/fields displayed and their order was a deliberate choice on the Notice management page.. I'd expect them to align with those displayed in the single patron display table.. especially the feedback for send failures etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Blocks||36809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36809 [Bug 36809] DRY out notice and slip printing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #95 from Martin Renvoize --- (In reply to Martin Renvoize from comment #94) > Maybe look into batch/print-notices.tt template instead of > circ/print-slip.tt here.. though I still don't understand how the new CSS > per template can possibly work here the way this is written. OK.. Whilst I think batch/print-notices.tt is better suited here, I do see that the localised CSS stuff is accounted for in circ/print-slip.tt and SlipCSS is seldom used in my experience. For now, I think this is OK as is but I would like to tidy up in the future as part of bug 36809 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Depends on||34030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34030 [Bug 34030] Print slips in a batch from the preservation module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #94 from Martin Renvoize --- Maybe look into batch/print-notices.tt template instead of circ/print-slip.tt here.. though I still don't understand how the new CSS per template can possibly work here the way this is written. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #93 from Martin Renvoize --- I've added some follow-ups.. 1) Tidy the new unit test for search_limited 2) Add a relation (Still need to add a unit test for this) for 'template' from the Koha::Notice::Message class 3) To safely degrade rather than throw a nasty 500 error to screen when a notice doesn't have a corresponding template (Try the new 'Add message - email' functionality from the patron details page to see the 500) Still a little more to do here and I will continue tomorrow (It's 8pm here already). We need that unit test adding for the new relation I introduce.. but I also want to investigate how the styling works together with a mix of HTML and non-HTML notices.. also interested in seeing how SlipCSS works with this as I'm surprised to now see it using the circ/print-slip template.. I thought that was very much intended for slip printers where as I thought this particular feature was more about printing notices to a Letter/A4 size printer.. especially 'email' notices.. does it also work with other message transport type notices? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Depends on||35285 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35285 [Bug 35285] Centralise notice content wrapping for HTML output -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #92 from Martin Renvoize --- Created attachment 166345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166345&action=edit Bug 33260: (QA follow-up) Safely continue for non-templated notices The 'letter_id'/'letter_code' field in the message queue table is a NULLable foreign key as is indeed NULL in certain circustances. We need to gracefully degrade when there isn't a template for the notice in question. Tihs patch uses the newly introduced 'template' accessor and when that returns undefined we pass 'style' as an empty string. We also use the 'is_html' method introduced in bug 35285 to set the html flag. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #91 from Martin Renvoize --- Created attachment 166344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166344&action=edit Bug 33260: (QA follow-up) Add template relation This patch add the 'template' relation to the Koha::Notice::Message object to fetch the Koha::Notice::Template object that may have been used to generate the notice. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #90 from Martin Renvoize --- Created attachment 166343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166343&action=edit Bug 33260: Tidy unit test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166178|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 166342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166342&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #166020|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 166341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166341&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #165951|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 166340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166340&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #165950|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 166339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166339&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #165949|0 |1 is obsolete|| --- Comment #85 from Martin Renvoize --- Created attachment 166338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166338&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #165948|0 |1 is obsolete|| --- Comment #84 from Martin Renvoize --- Created attachment 166337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166337&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #165947|0 |1 is obsolete|| --- Comment #83 from Martin Renvoize --- Created attachment 166336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166336&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Martin Renvoize changed: What|Removed |Added Attachment #165946|0 |1 is obsolete|| --- Comment #82 from Martin Renvoize --- Created attachment 166335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166335&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #81 from Aleisha Amohia --- Thanks for the comments, I've attached a new patch implementing Koha::Notice::Messages->search_limited. I'm not sure what you mean by non-templated notices - are you able to give me an example of this please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #80 from Aleisha Amohia --- Created attachment 166178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166178&action=edit Bug 33260: Use search_limited to protect message privacy, and unit test This patch adds a Koha::Notice::Messages->search_limited sub to allow better control over which patron's notices the user can see. Test added to t/db_dependent/Koha/Notice/Message.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #79 from Nick Clemens (kidclamp) --- Our team looked here as well. I think the privacy concern is the hard block here - if search_limited was implemented here (similar to Koha::ArticleRequests::search_limited) to limit the messages to patrons who the user can view this could move ahead. Martin's comment about non-templated notices should be addressed as well. We agree too that we need to improve the documentation and guidelines for datatables/searching/API interactions and will add that to the next dev meeting agenda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #78 from Martin Renvoize --- I'm a little worried about data privacy here I'm afraid.. I think I would expect to see use of Koha::Patrons->search_limited to limit results to patrons the logged-in user has the right to see. I'd be interested to get some feedback on that from a wider audience -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #77 from Aleisha Amohia --- (In reply to Martin Renvoize from comment #76) > Still looking here.. must admit I'm a little disappointed to find it all > coded in a style we've long since moved away from even though it's a very > recent project in the grand scheme. > It was an oversight, I started this development over a year ago but I know that standard has been in place for a while so my apologies. The API and datatables stuff has moved on quite a lot since we first started using it and it isn't documented well in the wiki, so unfortunately sometimes I do need to make mistakes and be corrected. I really appreciate any specific comments or feedback I can implement here, or links to the wiki which explains the standards for these things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #76 from Martin Renvoize --- Still looking here.. must admit I'm a little disappointed to find it all coded in a style we've long since moved away from even though it's a very recent project in the grand scheme. I'm worried about performance.. that table fills up with notice quickly and we're not paging or using API's. Also, we now have non-template driven notices and those cause a spectacular error on attempting to print. It looks like you're generating the notice from scratch at print time rather than using the notice that exists.. that also feels odd.. it could lead to viewing the preview and then printing something entirely different to what you just previewed. Anyway.. I'll come back to this asap once I've dug a little further. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #75 from Martin Renvoize --- Created attachment 166020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166020&action=edit Bug 33260: (QA follow-up) Correct relation accessor and add unit test We were missing unit tests for the patron relation accessor added to Koha::Notice::Message and once I looked at adding the test I spotted the accessor was also using a rather outdated form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #74 from David Nind --- Thanks for fixing Aleisha! This looks great, and things worked as set out in the test plan. Some things I noticed and some suggestions (but not showstoppers for me): 1. Background for search results - I think this needs the white background div. 2. Step 13 - each notice was on a separate page, I didn't notice any horizontal lines. 3. Search filters: maybe this should also have a clear button or link beside the search button. 4. Search results display after printing selected notices. If you select multiple notices and click "Print selected notices", after you have saved the PDF and returned to the notices management screen, items are still selected, the print selected notices button is still selected, and the status stays as pending. Once you do another search or refresh the page, things display as expected. Is there a way to refresh the page once the selected notices are printed? Testing notes (using KTD): 1. I added an email address to the patron(s) I generated the notices for. 2. I updated the patron messaging preferences for the patron(s) I generated the notices for (I enabled item check-in and item checkout). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Attachment #165939|0 |1 is obsolete|| --- Comment #73 from David Nind --- Created attachment 165951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165951&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Attachment #165239|0 |1 is obsolete|| --- Comment #72 from David Nind --- Created attachment 165950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165950&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Attachment #165238|0 |1 is obsolete|| --- Comment #71 from David Nind --- Created attachment 165949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165949&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Attachment #164785|0 |1 is obsolete|| --- Comment #70 from David Nind --- Created attachment 165948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165948&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Attachment #164784|0 |1 is obsolete|| --- Comment #69 from David Nind --- Created attachment 165947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165947&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Attachment #164783|0 |1 is obsolete|| --- Comment #68 from David Nind --- Created attachment 165946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165946&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #165717|0 |1 is obsolete|| --- Comment #67 from Aleisha Amohia --- Created attachment 165939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165939&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #66 from David Nind --- (In reply to Aleisha Amohia from comment #65) > (In reply to David Nind from comment #63) > > I could not test steps 5-13 (Tools > Notices management) because I get these > > errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF > > protection) (other steps all work as expected): > > > > Thanks for testing David, I believe I have addressed these errors in the > latest follow up. Thanks Aleisha for updating! The patron search block on the notices management tool page is now working. However, for the search filters on the left, I'm still getting an error when clicking on 'Search': An error has occurred! Error 403 Programming error - op 'search' must start with 'cud-' for POST http://127.0.0.1:8081/intranet/tools/notices.pl (referer: http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #65 from Aleisha Amohia --- (In reply to David Nind from comment #63) > I could not test steps 5-13 (Tools > Notices management) because I get these > errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF > protection) (other steps all work as expected): > Thanks for testing David, I believe I have addressed these errors in the latest follow up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #64 from Aleisha Amohia --- Created attachment 165717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165717&action=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #63 from David Nind ---
I could not test steps 5-13 (Tools > Notices management) because I get these
errors (maybe partially related to Bug 34478 and Bug 36192 - CSRF protection)
(other steps all work as expected):
1. Patron search: entering a partial name doesn't come up with the full name
and card number to select (for example: start typing mary). Two errors in the
console:
jQuery.Deferred exception: Cannot set properties of undefined (setting
'_renderItem') TypeError: Cannot set properties of undefined (setting
'_renderItem')
at patron_autocomplete
(http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.1200025.js:574:46)
at HTMLDocument.
(http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl:2803:21)
at e
(http://127.0.0.1:8081/intranet-tmpl/lib/jquery/jquery-3.6.0.min_23.1200025.js:2:30038)
at t
(http://127.0.0.1:8081/intranet-tmpl/lib/jquery/jquery-3.6.0.min_23.1200025.js:2:30340)
undefined
Uncaught TypeError: Cannot set properties of undefined (setting '_renderItem')
at patron_autocomplete (staff-global_23.1200025.js:574:46)
at HTMLDocument. (notices.pl:2803:21)
at e (jquery-3.6.0.min_23.1200025.js:2:30038)
at t (jquery-3.6.0.min_23.1200025.js:2:30340)
2. Browse by last name: selecting any letter displays all patrons ("showing 1
to 20 of 53 entries").
3. Selecting a patron (after choosing a letter) - nothing displays apart from
the patrons search/browse by last name box) (for example:
http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl?&borrowernumber=49)
4. Error when using the search filters. Click 'Search' (no need to change any
filter options), error displayed:
An error has occurred!
Error 403
Programming error - op 'search' must start with 'cud-' for POST
http://127.0.0.1:8081/intranet/tools/notices.pl (referer:
http://127.0.0.1:8081/cgi-bin/koha/tools/notices.pl?&borrowernumber=49)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #164787|0 |1 is obsolete|| --- Comment #62 from Aleisha Amohia --- Created attachment 165239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165239&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #164786|0 |1 is obsolete|| --- Comment #61 from Aleisha Amohia --- Created attachment 165238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165238&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Lucas Gass changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #60 from Lucas Gass --- Needs rebased on top of Bug 36490 now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162681|0 |1 is obsolete|| --- Comment #59 from Aleisha Amohia --- Created attachment 164787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164787&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162680|0 |1 is obsolete|| --- Comment #58 from Aleisha Amohia --- Created attachment 164786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164786&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162679|0 |1 is obsolete|| --- Comment #57 from Aleisha Amohia --- Created attachment 164785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164785&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162678|0 |1 is obsolete|| --- Comment #56 from Aleisha Amohia --- Created attachment 164784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164784&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162677|0 |1 is obsolete|| --- Comment #55 from Aleisha Amohia --- Created attachment 164783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164783&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #54 from Lucas Gass --- Tests are failing here and the DBUpdates need to have their file permissions corrected. Otherwise looks good! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162625|0 |1 is obsolete|| --- Comment #53 from ByWater Sandboxes --- Created attachment 162681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162681&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162624|0 |1 is obsolete|| --- Comment #52 from ByWater Sandboxes --- Created attachment 162680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162680&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162572|0 |1 is obsolete|| --- Comment #51 from ByWater Sandboxes --- Created attachment 162679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162679&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162571|0 |1 is obsolete|| --- Comment #50 from ByWater Sandboxes --- Created attachment 162678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162678&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 ByWater Sandboxes changed: What|Removed |Added Attachment #162570|0 |1 is obsolete|| --- Comment #49 from ByWater Sandboxes --- Created attachment 162677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162677&action=edit Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 --- Comment #48 from Aleisha Amohia --- (In reply to Kelly McElligott from comment #45) > When searching for a notice in the search filters within the Notice > Management Tool, several notices appear multiple times. For example, there > are 3 HOLD notices. In the sandbox I am testing in, there is only one HOLD > notice within the Notices and Slips, so it shouldn't appear three times. In > addition, there are two check-in digest and two checkout digest options in > this drop-down menu. There are many that only appear once, but some appear > more than once. I think that the notice should only appear once when the > library only has one notice. This list becomes very long with duplicates > and it is very confusing. > > Just testing, I did create a library-specific HOLD notice, which appeared in > the dropdown menu as with all the others with no indication of it being a > library-specific notice. Good catch, this was because of the many message transport types that might be available for a notice. I've fixed that up in latest patches - please test again when you can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162574|0 |1 is obsolete|| --- Comment #47 from Aleisha Amohia --- Created attachment 162625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162625&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #162573|0 |1 is obsolete|| --- Comment #46 from Aleisha Amohia --- Created attachment 162624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162624&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #45 from Kelly McElligott --- When searching for a notice in the search filters within the Notice Management Tool, several notices appear multiple times. For example, there are 3 HOLD notices. In the sandbox I am testing in, there is only one HOLD notice within the Notices and Slips, so it shouldn't appear three times. In addition, there are two check-in digest and two checkout digest options in this drop-down menu. There are many that only appear once, but some appear more than once. I think that the notice should only appear once when the library only has one notice. This list becomes very long with duplicates and it is very confusing. Just testing, I did create a library-specific HOLD notice, which appeared in the dropdown menu as with all the others with no indication of it being a library-specific notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Depends on||33478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33478 [Bug 33478] Customise the format of notices when they are printed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #158854|0 |1 is obsolete|| --- Comment #44 from Aleisha Amohia --- Created attachment 162574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162574&action=edit Bug 33260: Move patron search into main body of page This patch moves the patron search in the Notices management page to the main body of the page so that the patron search result table displays more nicely. This is a better place for it anyway, as using this search takes the user to a different page. In the sidebar, where it was previously, it implied it would have the same results display as the search filters. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #158853|0 |1 is obsolete|| --- Comment #43 from Aleisha Amohia --- Created attachment 162573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162573&action=edit Bug 33260: Add Notice management tool This enhancement makes it easy for the library to view sent notices and filter by various search parameters. You can also print sent notices, individually or in a batch. This enhancement uses a new system preference NoticesManagement and a new view_generated_notices user permission. This enhancement has been built on top of Bug 33478 so print format settings are taken into account when printing notices. To test: 1. Apply patches, install database updates, restart services 2. Make sure your logged in user has the view_generated_notices permission checked 3. Enable the NoticesManagement system preference 4. Generate a few notices. There are a few ways to do this including: - place holds, check in items and confirm the holds - place recalls, check in items and confirm the recalls 5. Go to Tools -> Notices management 6. There are two search functions on the left navigation. Confirm the patron search box works by searching for one of the patrons you generated a notice for, you should be redirected to their Notice history. 7. Go back to Notices management. Use the set of search filters to search for notices. Leaving the search filters empty will return all notices generated. Confirm the filters work as expected by using different combinations of filters. 8. Conduct a search so your notices show in a table. Confirm the information fetched about the notices is correct. 9. Click on a notice title. Confirm the contents of the notice show in a pop-up box. 10. Click one of the Print buttons next to a notice. Confirm the notice is opened to be printed. 11. Redo your notices search. Confirm the status of the notice you just printed has now been updated to 'sent'. 12. Use the 'Select all' and 'Clear all' buttons to select or clear the checkboxes. 13. Select a few checkboxes and click the button at the bottom of the table to 'Print selected notices'. Confirm the notices have been collated into one document, separated by horizontal lines, and prints successfully. The statuses for the notices should all be updated to 'sent'. 14. Confirm the Notices management page is not visible without the view_generated_notices permission 15. Confirm the Notices management page is not visible without the NoticesManagement system preference being enabled. 16. Go to a patron's Notices history. If the view_generated_notices user permission is checked for your logged in patron, you should see a Print button for each notice. Confirm this works. Confirm this button doesn't show if your logged in patron does not have the view_generated_notices user permission. It does not require the NoticesManagement system preference. 17. Go to Tools -> Notices & slips 18. Edit the format settings of a few different notices i.e. HOLD and WELCOME 19. Generate these notices by filling a hold for a patron and sending a welcome email 20. Search for all notices under Tools -> Notices management 21. Select all notices and print selected notices 22. Confirm the notices different format settings are taken into account in the printed PDF Sponsored-by: Colorado Library Consortium -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #158852|0 |1 is obsolete|| --- Comment #42 from Aleisha Amohia --- Created attachment 162572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162572&action=edit Bug 33260: Add a patron getter method to Koha::Notice::Message Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #149595|0 |1 is obsolete|| --- Comment #41 from Aleisha Amohia --- Created attachment 162571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162571&action=edit Bug 33260: Add NoticesManagement system preference Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
