[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Blou  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #29 from Blou  ---
(In reply to MichaƂ from comment #27)
> which I'm not sure if there's any reasonable use-case. The author mentions
> example "noindex,nofollow" to prevent ALL opac pages from being indexed. 
> I think that if some library wants that, they'd be better off using the more 
> widely used and known robots.txt file

Your solution doesn't work.  Robots.txt doesn't prevent sites from being
indexed, Google itself instructs
https://developers.google.com/search/docs/crawling-indexing/block-indexing

Our use case is very valid and a basic option in Wordpress: websites wants ways
to not be found (while developping).  Here we have test and production systems,
and of course our customers do not want their users to find the test system. 
Two koha, similar data, user search google for their library and click on the
test link.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #28 from M  ---
By the way, having programmatic robots.txt generation could allow having
sitemaps linked there with "Sitemap:" directive, provided the generated files
are there, and that would remove one obstacle from having the sitemap
generation enabled by default in the Debian installation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

M  changed:

   What|Removed |Added

 CC||schodkowy.omegi-0r@icloud.c
   ||om

--- Comment #27 from M  ---
Wait, so this simply adds the same robots tag for the entirety of OPAC? I've
been redirected here from Bug 35812 due to conflicts. And I think this bug
right here is questionable and I'm not sure if it should be merged, at least
as-is.

> Websites must have a robots meta tag

That is not true, this tag is very much optional and meant for granular
page-level steering of crawling bots. The way this preference is implemented,
the rules are going to apply to ALL opac pages, which I'm not sure if there's
any reasonable use-case. The author mentions example "noindex,nofollow" to
prevent ALL opac pages from being indexed. I think that if some library wants
that, they'd be better off using the more widely used and known robots.txt
file, which is more likely to be supported by various crawlers, and will
prevent them from downloading the pages in the first place (instead of
downloading the pages it wanted to and then discarding them upon discovering
the meta tag for particular page).

I think the better direction is to diversify manually which pages should be
crawlable by default and which shouldn't like in Bug 35812, ie. search results
and so on (dynamic pages) shouldn't be indexed to decreate the amount of junk
(but they should be crawled to extract links from it), while main page/info
subpages/user-created lists/biblio records should probably be indexed by
default and it's probably what most libraries would want by default.

With that said, there currently there's no "obvious"/"easy" way of specifying
custom robots.txt file, apart from doing something like `Alias /robots.txt
/var/www/html/robots.txt` in Apache config for opac (it works well enough btw).

So, in the spirit of what OP originally wanted, I believe it could be better to
consider instead adding a user preference for textarea of robots.txt file
contents, in place of site-wide robots meta tag contents. This would allow
libraries to set more granular rules, but someone who wants to block everything
could still just do:

User-agent: *
Disallow: /

Btw this is already documented in README.robots file in Koha's main git
directory (last edited 13 years ago, the last paragraph there is probably
outdated).

So I believe my idea above could solve the conflict between our two patches,
robots.txt usage is more widely documented on the Internet I believe, and
that'd override any rules that Koha devs could specify on per-template basis
manually in robots tag on pages like I did in Bug 35812...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #26 from Katrin Fischer  ---
I feel like the system preference description is a bit sparse. Could we add an
example or a link to documentation to make it clearer what you are supposed to
add?

+-
+- "Improve search engine crawling."
+- pref: OpacMetaRobots
+  type: textarea

Also, the pref description shoudl be formed as a sentencee and connect with the
input field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds a new
  release notes||system preference,
   ||OpacMetaRobots which allows
   ||libraries to tell search
   ||engine robots how to crawl
   ||and index OPAC pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160541|0   |1
is obsolete||

--- Comment #25 from Lucas Gass  ---
Created attachment 160546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160546=edit
Bug 33317: (follow-up) Perltidy

Signed-off-by: Owen Leonard 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160540|0   |1
is obsolete||

--- Comment #24 from Lucas Gass  ---
Created attachment 160545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160545=edit
Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent
incorrect data entry

Signed-off-by: Owen Leonard 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160539|0   |1
is obsolete||

--- Comment #23 from Lucas Gass  ---
Created attachment 160544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160544=edit
Bug 33317: Add system preference to set meta robots for the OPAC

Websites must have a robots meta tag to improve search engine crawling,
so we could tell search engines to not index OPAC pages for example.

To test:

1) Look at opac-main source and see that meta name=robots is missing.
2) Apply patch.
3) Run ./installer/data/mysql/updatedatabase.pl
4) Go to system preferences > OPAC and add some directives to
   OpacMetaRobots (ex: noindex,nofollow).
5) Look at opac-main source and confirm that meta name=robots now has
   content equal to the text set in the OpacMetaRobots system
   preference.
6) This should Prevent search engines from indexing Opac pages (if
   OpacMetaRobots is set to noindex)

Signed-off-by: Owen Leonard 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #22 from Lucas Gass  ---
Looks good now, passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #21 from Owen Leonard  ---
Created attachment 160541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160541=edit
Bug 33317: (follow-up) Perltidy

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #20 from Owen Leonard  ---
Created attachment 160540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160540=edit
Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent
incorrect data entry

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Owen Leonard  changed:

   What|Removed |Added

 Attachment #150420|0   |1
is obsolete||
 Attachment #158820|0   |1
is obsolete||
 Attachment #160534|0   |1
is obsolete||

--- Comment #19 from Owen Leonard  ---
Created attachment 160539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160539=edit
Bug 33317: Add system preference to set meta robots for the OPAC

Websites must have a robots meta tag to improve search engine crawling,
so we could tell search engines to not index OPAC pages for example.

To test:

1) Look at opac-main source and see that meta name=robots is missing.
2) Apply patch.
3) Run ./installer/data/mysql/updatedatabase.pl
4) Go to system preferences > OPAC and add some directives to
   OpacMetaRobots (ex: noindex,nofollow).
5) Look at opac-main source and confirm that meta name=robots now has
   content equal to the text set in the OpacMetaRobots system
   preference.
6) This should Prevent search engines from indexing Opac pages (if
   OpacMetaRobots is set to noindex)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #18 from Hammat wele  ---
Created attachment 160534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160534=edit
Bug 33317: (follow-up) Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2024-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Attachment #160126|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #17 from Lucas Gass  ---
Hammat, 

The qa tool still complains. Please fix:

 FAIL   installer/data/mysql/atomicupdate/bug_33317.pl
   FAIL   file permissions
File must have the exec flag
   WARN   tidiness
The file is less tidy than before (bad/messy lines before: 0,
now: 1)


-perltidy all of bug_33317.pl
-Also make sure bug_33317.pl has the proper permissions set ( File must have
the exec flag )

sudo chmod 755 bug_33317.pl should do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #16 from Hammat wele  ---
Created attachment 160126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160126=edit
Bug 33317: (follow-up) Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Attachment #160125|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #15 from Hammat wele  ---
Created attachment 160125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160125=edit
Bug 33317: (follow-up) Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Attachment #159653|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #14 from Liz Rea  ---
This is a very good feature - put the power in the user's hands instead of the
sysadmin. Strong approval.

Agree with Lucas that freetext is probably better avoided, since it can be
error prone.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #13 from Owen Leonard  ---
The qa tool still has complaints about the atomicupdate. Please take another
look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #12 from Hammat wele  ---
Created attachment 159653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159653=edit
Bug 33317: (follow-up) Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Lucas Gass  ---
Looks good Hammat. Only issue now is to perltidy
'installer/data/mysql/atomicupdate/bug_33317.pl'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #10 from Hammat wele  ---
Created attachment 158820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158820=edit
Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent
incorrect data entry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #9 from David Cook  ---
(In reply to Lucas Gass from comment #7)
> I have a few follow-up questions:
> 
> 1. Should a default value of noindex, nofollow be used here?  
> 
> 2. Is freetext the right thing to use here? Using conflicting or
> inconsistent values can confuse search engine crawlers and cause them to
> make incorrect assumptions about how to treat your pages in their index.

Good questions...

With Google is looks like there are quite a few valid rules:
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag#directives

But then free-text is error prone as Lucas says...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-11-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Lucas Gass  ---
Failing QA here until my questions are addressed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #7 from Lucas Gass  ---
I have a few follow-up questions:

1. Should a default value of noindex, nofollow be used here?  

2. Is freetext the right thing to use here? Using conflicting or inconsistent
values can confuse search engine crawlers and cause them to make incorrect
assumptions about how to treat your pages in their index.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Attachment #148593|0   |1
is obsolete||

--- Comment #6 from Hammat wele  ---
Created attachment 150420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150420=edit
Bug 33317: Add system preference to set meta robots for the OPAC

Websites must have a robots meta tag to improve search engine crawling, so we
could tell search engines to not index OPAC pages for example.
To test:
1) Look at opac-main source and see that meta name=robots is missing.
2) Apply patch.
3) Run ./installer/data/mysql/updatedatabase.pl
4) Go to system preferences > OPAC and add some directives to OpacMetaRobots
(ex: noindex,nofollow).
5) Look at opac-main source and confirm that meta name=robots now has content
equal to the text set in the OpacMetaRobots system preference.
6) This should Prevent search engines from indexing Opac pages (if
OpacMetaRobots is set to noindex)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-04-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||lu...@bywatersolutions.com

--- Comment #5 from Lucas Gass  ---
Hammat,

This is missing a DB update. Have a look at Bug 30403 for an example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #4 from Sally  ---
(In reply to Sally from comment #3)
> I think this is 99% of the way there and I'm not sure if I'm being picky
> with this, so I've signed off so QA can take a look.
> 
> Adding a value works perfectly.
> Changing a value works perfectly.
> 
> But if you've added a value and you later decide to reset to the original
> defaults, you can't do so by deleting the values and saving the empty input
> field.
> 
> To replicate:
> 
> - Enter a value into OpacMetaRobots
> - Save 
> - Open the OPAC and view the source; note the value matches
> - Change the value in OpacMetaRobots
> - Save
> - Refresh the OPAC and view the source; note the value matches
> - Remove the value from OpacMetaRobots so the input field is empty
> - Save
> - Refresh the OPAC and view the source; this time, note that the last saved
> value still remains
> 
> Given that 'index' is the default value if no robot meta tag is listed,
> maybe just a note to say 'to reset to default values, use: index' would work?

This error didn't make sense to me, so I wondered if I was having sandbox woes
again. 

I repeated the tests on a different sandbox and it all worked perfectly.

So please ignore the above comment - it's working as described.  Sorry for the
noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk
 Status|Needs Signoff   |Signed Off

--- Comment #3 from Sally  ---
I think this is 99% of the way there and I'm not sure if I'm being picky with
this, so I've signed off so QA can take a look.

Adding a value works perfectly.
Changing a value works perfectly.

But if you've added a value and you later decide to reset to the original
defaults, you can't do so by deleting the values and saving the empty input
field.

To replicate:

- Enter a value into OpacMetaRobots
- Save 
- Open the OPAC and view the source; note the value matches
- Change the value in OpacMetaRobots
- Save
- Refresh the OPAC and view the source; note the value matches
- Remove the value from OpacMetaRobots so the input field is empty
- Refresh the OPAC and view the source; this time, note that the last saved
value still remains

Given that 'index' is the default value if no robot meta tag is listed, maybe
just a note to say 'to reset to default values, use: index' would work?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #148575|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 148593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148593=edit
Bug 33317: Add system preference to set meta robots for the OPAC

Websites must have a robots meta tag to improve search engine crawling, so we
could tell search engines to not index OPAC pages for example.
To test:
1) Look at opac-main source and see that meta name=robots is missing.
2) Apply patch.
3) Go to system preferences > OPAC and add some directives to OpacMetaRobots
(ex: noindex,nofollow).
4) Look at opac-main source and confirm that meta name=robots now has content
equal to the text set in the OpacMetaRobots system preference.
5) This should Prevent search engines from indexing Opac pages (if
OpacMetaRobots is set to noindex)

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

--- Comment #1 from Hammat wele  ---
Created attachment 148575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148575=edit
Bug 33317: Add system preference to set meta robots for the OPAC

Websites must have a robots meta tag to improve search engine crawling, so we
could tell search engines to not index OPAC pages for example.
To test:
1) Look at opac-main source and see that meta name=robots is missing.
2) Apply patch.
3) Go to system preferences > OPAC and add some directives to OpacMetaRobots
(ex: noindex,nofollow).
4) Look at opac-main source and confirm that meta name=robots now has content
equal to the text set in the OpacMetaRobots system preference.
5) This should Prevent search engines from indexing Opac pages (if
OpacMetaRobots is set to noindex)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com,
   ||hammat.w...@inlibro.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33317] Add system preference to set meta robots for the OPAC

2023-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33317

Hammat wele  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |hammat.w...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/